- 02 Apr, 2015 1 commit
-
-
Sean Hammond authored
-
- 31 Mar, 2015 1 commit
-
-
Sean Hammond authored
An annotation's document.title is used as the citation when displaying an annotation. If this is an older annotation that has no document, fall back to using the domain as the citation title instead. Fixes #1542
-
- 30 Mar, 2015 5 commits
-
-
Randall Leeds authored
Handle internal server errors in the registration form
-
Sean Hammond authored
Add a test for how the frontend handles an invalid response from the server when trying to register a user account. This happens if the server has an uncaught exception.
-
Sean Hammond authored
Merge branch '1755-handle-internal-server-error-in-registration-form' of github.com:hypothesis/h into 1755-handle-internal-server-error-in-registration-form Conflicts: h/static/scripts/account/auth-controller.coffee
-
Sean Hammond authored
Add a frontend test for when the server returns an error response with a "reason" but no "errors" in the JSON-object response body.
-
Sean Hammond authored
When catching a non-JSON error response from the server, when trying to register a user.
-
- 27 Mar, 2015 9 commits
-
-
Randall Leeds authored
Hide orphan annotations in the sidebar
-
csillag authored
-
csillag authored
-
csillag authored
-
csillag authored
-
csillag authored
-
Sean Hammond authored
This fixes #1755: no error is shown on the client side when an attempt to register an account receives a 500 Server Error response. The failure() method in AuthController gets called and tries to do {errors, reason} = response.data, but this raises a TypeError because response.data is undefined (because the response didn't have a valid JSON body), so the client crashes as well. The fix is to catch this exception on the client side, and show a generic error to the user.
-
Nick Stenning authored
Improve packaging, bundling and module boilerplate
-
Randall Leeds authored
Prevent negative interactions with module systems present in injected pages and refactor browserify interactions with angular to increase CommonJS accessibility / legibility and isolate angular module system boilerplate. - Avoid issues due to mis-detected module environments - In the injection script, load only Annotator and jQuery in the global scope and then both removed with `noConflict()`. Both are loaded with browserify-shim, which prevents jQuery from registering itself against require.js, if present (fix #2026). - Be explicit about registration of common cross-frame components (fix #2090). - Lift angular glue into app.coffee. Individual components are exported as CommonJS modules. - Lift Annotator glue into bootstrap.js (renamed hypothesis.js). - Break up all modules that contained multiple services/directives/etc, such as the formHelpers and uiHelpers modules, as well as catch-all files like services.coffee and directives.coffee. For a summary of these movements see the bottom of this commit message. - Rename all services, dropping the -service suffix, to match their injected names. This is consistent with how directives are being treated, and controllers as well (controllers are registered and injected done with the "Controller" suffix). - Move Annotator subclasses into the annotator subdirectory. This change avoids having `Annotator.Host` clash with the `host` service and makes it easy to glob dependencies in assets.yaml to minimally rebuild either the app or the inject. --- Summary of structural reorganisation. Modules that have been trivially renamed (from "foo-service" to "foo") are not included in this list: controllers:AppController app-controller controllers:AnnotationUIController annotation-ui-controller controllers:AnnotationViewerController annotation-viewer-controller controllers:ViewerController widget-controller directives:match directive/match directives:repeatAnim directive/repeat-anim directives:whenscrolled directive/whenscrolled directives/thread:pulse pulse filters:Converter filter/converter filters:momentFilter filter/moment filters:personaFilter filter/persona filters:urlEncodeFilter filter/urlencode guest annotator/guest host annotator/host helpers/form-helpers:createFormHelpers form-respond helpers/form-helpers:formInput directive/form-input helpers/form-helpers:formValidate directive/form-validate helpers/string-helpers:createStringHelpers unicode helpers/tag-helpers tags helpers/time-helpers time helpers/ui-helpers:tabbable directive/tabbable helpers/ui-helpers:tabReveal directive/tab-reveal searchfilters:QueryParser query-parser searchfilters:SearchFilter search-filter searchfilters:StreamFilter stream-filter services:DraftProvider drafts services:ViewFilter view-filter services:renderFactory render session/session-service session streamsearch stream-controller
-
- 26 Mar, 2015 1 commit
-
-
Sean Hammond authored
This fixes #1755: no error is shown on the client side when an attempt to register an account receives a 500 Server Error response. The failure() method in AuthController gets called and tries to do {errors, reason} = response.data, but this raises a TypeError because response.data is undefined (because the response didn't have a valid JSON body), so the client crashes as well. The fix is to catch this exception on the client side, and show a generic error to the user.
-
- 25 Mar, 2015 2 commits
-
-
Randall Leeds authored
Add details on how to run dockerised dependencies
-
Nick Stenning authored
Move CSRF handling into a tween
-
- 24 Mar, 2015 6 commits
-
-
Randall Leeds authored
Scroll to login form when clicking sign in link
-
Sean Hammond authored
This fixes an issue that if the login form is already shown but the iframe is taller than the window and scrolled down so that the form is out of view, then clicking on Sign in would do nothing. With this fix, clicking Sign in scrolls the iframe up to the login form.
-
Randall Leeds authored
Realtime notifications for pages with the same link
-
Randall Leeds authored
Namespaced NSQ
-
Randall Leeds authored
Simplify code
-
csillag authored
Some more cleanup / simplification about the "Refresh UX" PR.
-
- 23 Mar, 2015 15 commits
-
-
Randall Leeds authored
Removed some dead code
-
csillag authored
-
Randall Leeds authored
Add an atom feed for /stream
-
Randall Leeds authored
Refresh welcome page
-
Randall Leeds authored
AppController listens to 'beforeAnnotationCreated'
-
Randall Leeds authored
-
Gergely Ujvari authored
By doing that it catches newly created annotations and clear the current selection/search result for the newly created card to be visible. Fix #1979
-
Gergely Ujvari authored
-
Kristof Csillag authored
Sync annotation state after anchoring
-
Gergely Ujvari authored
It was never called when the anchoring was finished. This code adds the missing sync. It is required for show diff to work. Fix #2041
-
gergely-ujvari authored
Separate the Host service
-
csillag authored
.. from AnnotionUISync. Earlier, the show/hide frame functionality was implemented as a background functionality of the AnnotationUISync service, and it was not directly available for the sidebar code. This commit separated that functionality into a new service, and exposes it over a public API. The test have been updated accordingly, too.
-
gergely-ujvari authored
Do angular magic differently
-
csillag authored
This commit changes how we trigger the refreshing of the markdown previews in the editor. It has to do with how angular apply / digest cycles interwene and crash in some cases. The change was suggested by @RawKStar77 here: https://github.com/hypothesis/h/pull/2038#discussion_r26867418
-
Randall Leeds authored
Explicitly disallow implicit relative imports
-