1. 10 Jun, 2016 13 commits
  2. 09 Jun, 2016 9 commits
  3. 07 Jun, 2016 3 commits
  4. 06 Jun, 2016 3 commits
    • Robert Knight's avatar
      Implement new design for hovered conversation threads (#3376) · a3f910d3
      Robert Knight authored
      * Implement new design for hovered conversation threads
      
      Implement the new design for hovered replies from
      https://trello.com/c/aXCXxzx2 .
      
      The most visible effect is that conversation threads have a grey
      background when hovered.
      
      In the process of implementing the new styling, there is some cleanup
      of the CSS:
      
       * Use `--reply`/`--top-reply` modifier classes on <annotation> and
         <annotation-thread> elements to style annotations, top-level replies
         and nested replies differently. This makes the CSS simpler and
         reduces the risk of unexpected side effects that come with descendant
         selectors.
      
       * Rename `thread` CSS classes to match the name of the component
         that they are used in, `annotation-thread`.
      
      * Move 'annotation-unavailable-message' styling to app.scss
      
      This class is used in the root template (viewer.html) not the
      <annotation-thread> component.
      
      * Darken expand/collapse toggle arrow only when annotation itself is hovered
      
      Darken the expand/collapse arrow when an annotation is hovered but not
      when its replies are hovered.
      
      * Remove no-op CSS class
      
      The `clear: both` styling had no effect because <annotation-thread>
      is now using flexbox rather than floats for layout.
      
      * Do not show 'Hide replies' link for replies
      
      For replies there were two different ways to collapse the annotation
      card, the expand/collapse toggle arrow and the 'Hide replies' link.
      
      Removing the 'Hide replies' link avoids having two ways to do the same
      thing and makes the cards look cleaner.
      
      * Remove the light grey background for hovered replies
      
      Following design review, remove the grey background for hovered replies.
      
      * Make rendering of dashed lines to the left of replies better in Chrome
      
      Previously the dashed line started at the top of the <annotation-thread>
      component and the top part was covered up by the thread expand/collapse
      toggle.
      
      In Chrome the alignment of dashes within a dashed border varies as the
      height of the element changes [1]. Therefore depending on the height of
      the reply, this could result in the visible part of the line below the
      collapse/expand toggle starting at either a gap or dash in the line.
      
      By instead moving the dashed line to a separate element which is
      positioned beneath the expand/collapse toggle, the first visible dash in
      the reply line always appears in the same place and is aligned correctly
      with the annotation content to its right.
      
      [1] See http://www.impressivewebs.com/comparison-css-border-style/
          for a visual representation of why this is done.
      a3f910d3
    • Robert Knight's avatar
      Add integration test for anchoring (#3377) · d6f1a7ec
      Robert Knight authored
      This adds an integration test for anchoring of annotations loaded
      into the annotator guest via the sidebar.
      
      This was extracted from https://github.com/hypothesis/h/pull/3313
      
      The test case for nested annotations has been marked as an expected
      failure until a better resolution for #3278 has been found.
      d6f1a7ec
    • Robert Knight's avatar
      Merge pull request #3402 from hypothesis/fix-phantom-404s · 24495385
      Robert Knight authored
      Fix distracting 404s in karma/phantom test output
      24495385
  5. 03 Jun, 2016 4 commits
  6. 02 Jun, 2016 5 commits
  7. 01 Jun, 2016 3 commits
    • Nick Stenning's avatar
      Remove additional margin at foot of annotation card · 3c184583
      Nick Stenning authored
      There should be 15px, not 20px of margin at the bottom of the annotation
      card, just as at the top.
      
      Removing this CSS means that the annotation footer has no bottom margin
      and the 15px is provided for all sizes of the card by padding on
      .annotation-card.
      3c184583
    • Nick Stenning's avatar
      Don't rely on whitespace insertion for correct spacing · 670192b9
      Nick Stenning authored
      The annotation action buttons are inline-block elements which means that
      whitespace between the tags results in inserted whitespace in the
      document when rendered. This rendered whitespace is roughly 4px wide.
      
      Instead, switch the layout of the annotation actions div to use flexbox,
      in which no such whitespace is inserted, and add 4px to the margin on
      the buttons.
      670192b9
    • Nick Stenning's avatar
      Remove excess whitespace on either side of icon glyphs · 32593060
      Nick Stenning authored
      The annotation action icons didn't seem to be equally spaced due to
      excess whitespace on either side of the icons within the font glyphs.
      This commit updates the edit, reply and share icons to remove excess
      whitespace.
      
      Where previously these three icons were 16px wide (and the trash icon
      was 9.5px wide) they are now 14px, 13.5px, and 12px wide respectively.
      32593060