- 19 May, 2020 1 commit
-
-
Lyza Danger Gardner authoredDifferent browsers format Fetch errors differently; give them some sort of consistency by re-throwing something with a common string. This will allows us to filter out fetch errors from sentry logging, as well.
-
- 13 May, 2020 6 commits
-
-
Kyle Keating authored
Change the client RPC request to optionally bypass the timeout. There could be a case where it's waiting for user input to proceed with authorization and could take any number of seconds.
-
Lyza Gardner authored
Hide menu item toggle button if there are no items
-
Kyle Keating authored
Pass undefined to MenuItem to hide the submenu and its toggle button.
-
Lyza Gardner authored
Add negative top margin to “show x more in conversation” buttons
-
Robert Knight authored
Focus first item in menu when opened by any input method
-
Robert Knight authored
Remove unused annotator CSS
-
- 12 May, 2020 11 commits
-
-
Robert Knight authored
Bump fetch-mock from 9.4.0 to 9.5.1
-
Robert Knight authored
Merge pull request #2144 from hypothesis/dependabot/npm_and_yarn/karma-coverage-istanbul-reporter-3.0.2 Bump karma-coverage-istanbul-reporter from 2.1.1 to 3.0.2
-
Robert Knight authored
Bump puppeteer from 3.0.2 to 3.0.4
-
Robert Knight authored
Bump postcss from 7.0.29 to 7.0.30
-
dependabot-preview[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.29 to 7.0.30. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/7.0.29...7.0.30) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
Robert Knight authored
Bump aws-sdk from 2.669.0 to 2.673.0
-
Robert Knight authored
Bump npm-packlist from 2.1.1 to 2.1.2
-
Robert Knight authored
Bump karma from 5.0.4 to 5.0.5
-
Robert Knight authored
- Remove several unused classes and styles - Group all the CSS reset style rules for `.annotator-frame` together
-
Robert Knight authored
Remove unused icons
-
Robert Knight authored
Remove icomoon font and associated infrastructure
-
- 11 May, 2020 22 commits
-
-
Kyle Keating authored
-
Lyza Danger Gardner authored
Fine-tune the vertical alignment of the “Show x more in conversation” hidden-thread toggling buttons so that they better align with thread toggle chevrons. Fixes #2097
-
Lyza Gardner authored
Adjust accessible text for groups menu label
-
Robert Knight authored
Override `<button>` padding from page styles in toolbar
-
Robert Knight authored
Revert to hard-coded padding for the toolbar buttons to override any default padding the page may have for `<button>` elements. This affects PDF.js amongst other apps/sites. Instead of setting the padding to 0 as before, set it to `1px 6px` which matches Chrome's defaults that looked reasonable. A better solution will be to use Shadow DOM for the whole sidebar UI, but that is a larger change.
-
Robert Knight authored
Fix sidebar vertical toolbar button alignment
-
Robert Knight authored
The client's test page was missing a `<!DOCTYPE html>` declaration and as a result rendered in _quirks mode_ rather than _standards mode_. This hid an issue where the toolbar buttons were not centered correctly in standards-mode documents. This incorrect centering was caused by: 1. The CSS bundle for the "annotator" part of the app not including the CSS styles for the `SvgIcon` component 2. An unnecessary `padding` declaration on the `.annotator-frame-button` class I haven't investigated in detail exactly which quirks-vs-standards mode difference resulted in the centering still being OK in quirks-mode. This commit fixes these two issues and fixes toolbar button centering in both quirks and standards-mode documents. It also updates the client's test page to add the `<!DOCTYPE html>` declaration since standards mode is what most web content uses. -
dependabot-preview[bot] authored
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.10 to 2.0.11. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.0.10...2.0.11) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
dependabot-preview[bot] authored
Bumps [jquery](https://github.com/jquery/jquery) from 3.5.0 to 3.5.1. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.5.0...3.5.1) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
dependabot-preview[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Commits](https://github.com/npm/npm-packlist/compare/v2.1.1...v2.1.2) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 3.0.2 to 3.0.4. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v3.0.2...v3.0.4) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.669.0 to 2.673.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.669.0...v2.673.0) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
dependabot-preview[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 5.0.4 to 5.0.5. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.0.4...v5.0.5) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
dependabot-preview[bot] authored
Bumps [karma-coverage-istanbul-reporter](https://github.com/mattlewis92/karma-coverage-istanbul-reporter) from 2.1.1 to 3.0.2. - [Release notes](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/releases) - [Changelog](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/blob/master/CHANGELOG.md) - [Commits](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/compare/v2.1.1...v3.0.2) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
dependabot-preview[bot] authored
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.4.0 to 9.5.1. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.4.0...v9.5.1) Signed-off-by:
dependabot-preview[bot] <support@dependabot.com> -
Robert Knight authored
Fix sidebar toggle button when using VoiceOver on iOS
-
Robert Knight authored
Rename this module to distinguish it from `src/sidebar/util/dom.js` which are generic DOM utilities that are not ponyfills for standard methods. See https://github.com/hypothesis/client/pull/2106/files#r420296891
-
Robert Knight authored
When using iOS with VoiceOver enabled, double-tapping the sidebar toggle button caused the sidebar to open and then immediately close. The immediate close was caused by the `onElementTouchStart` handler in `guest.coffee` that is intended to hide the sidebar when the user taps somewhere in the document outside the sidebar. This handler did not check however whether the event originated from annotator UI or not. The fix here is to ignore any events which occur inside the sidebar frame's container. Fixes #1765
-
Robert Knight authored
Previously the `Menu` component would focus the first item in the list if it was opened by pressing Enter or Space but not if it was clicked. This meant that it was not possible to mix input modalities (open menu with mouse, navigate using keyboard) easily when using the menu. More importantly if the menu was opened using a screen reader shortcut (eg. VoiceOver Key + Space on macOS) per the screen reader's verbal instructions, the focus didn't change. My understanding is that SR shortcuts generally simulate mouse rather than keyboard input.
-
Robert Knight authored
Following https://github.com/hypothesis/client/pull/2138 all icons in the client are rendered with inline SVGs via the `SvgIcon` component.
-
Robert Knight authored
Use SVG icons in annotator toolbar
-
Robert Knight authored
Add `src/annotator/icons.js` which mirrors `src/sidebar/icons.js`. It contains all the icons used by the "annotator" part of the application. Remove from `src/sidebar/icons.js` those icons which were not used by the sidebar but are referenced in tests for annotator components. The annotator icons are now registered for use in tests by `bootstrap.js`.
-