Commits · 299106f8863d607e4d5ec0c7b08f60b019ea7ee9 · 孙灵跃 Leon Sun / coopwire-hypothesis

19 May, 2020 2 commits

Update sentry config to ignore unhandled fetch exceptions · 299106f8
Lyza Danger Gardner authored May 18, 2020
```
Fixes #2018
```
299106f8

Re-throw Fetch Errors to make them consistent · 138b2498

Lyza Danger Gardner authored May 18, 2020

Different browsers format Fetch errors differently; give them some
sort of consistency by re-throwing something with a common string.

This will allows us to filter out fetch errors from sentry logging,
as well.

138b2498

13 May, 2020 6 commits
- requestGroups RPC call should not timeout (#2159) · cd6c4c31
  Kyle Keating authored May 13, 2020
```
Change the client RPC request to optionally bypass the timeout. There could be a case where it's waiting for user input to proceed with authorization and could take any number of seconds.
```
  cd6c4c31
- Merge pull request #2155 from hypothesis/hide-menu-toggle · ec84d3be
  Lyza Gardner authored May 13, 2020
```
Hide menu item toggle button if there are no items
```
  ec84d3be
- Hide menu item toggle button if there are no submenu items · 95b95b52
  Kyle Keating authored May 11, 2020
```
Pass undefined to MenuItem to hide the submenu and its toggle button.
```
  95b95b52
- Merge pull request #2154 from hypothesis/show-hidden-thread-alignment · 98a266d1
  Lyza Gardner authored May 13, 2020
```
Add negative top margin to “show x more in conversation” buttons
```
  98a266d1
- Merge pull request #2135 from hypothesis/focus-menu-on-click-open · 7b771604
  Robert Knight authored May 13, 2020
```
Focus first item in menu when opened by any input method
```
  7b771604
- Merge pull request #2157 from hypothesis/annotator-css-cleanup · 82b12e5e
  Robert Knight authored May 13, 2020
```
Remove unused annotator CSS
```
  82b12e5e
12 May, 2020 11 commits
- Merge pull request #2143 from hypothesis/dependabot/npm_and_yarn/fetch-mock-9.5.1 · 045c7b9c
  Robert Knight authored May 12, 2020
```
Bump fetch-mock from 9.4.0 to 9.5.1
```
  045c7b9c
- Merge pull request #2144 from... · 36597ae3
  Robert Knight authored May 12, 2020
```
Merge pull request #2144 from hypothesis/dependabot/npm_and_yarn/karma-coverage-istanbul-reporter-3.0.2

Bump karma-coverage-istanbul-reporter from 2.1.1 to 3.0.2
```
  36597ae3
- Merge pull request #2150 from hypothesis/dependabot/npm_and_yarn/puppeteer-3.0.4 · dd5fb9aa
  Robert Knight authored May 12, 2020
```
Bump puppeteer from 3.0.2 to 3.0.4
```
  dd5fb9aa
- Merge pull request #2149 from hypothesis/dependabot/npm_and_yarn/postcss-7.0.30 · b6bf99db
  Robert Knight authored May 12, 2020
```
Bump postcss from 7.0.29 to 7.0.30
```
  b6bf99db
- Bump postcss from 7.0.29 to 7.0.30 · 96d809bb
  dependabot-preview[bot] authored May 12, 2020
```
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.29 to 7.0.30.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/7.0.29...7.0.30)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
```
  96d809bb
- Merge pull request #2148 from hypothesis/dependabot/npm_and_yarn/aws-sdk-2.673.0 · 4a49311a
  Robert Knight authored May 12, 2020
```
Bump aws-sdk from 2.669.0 to 2.673.0
```
  4a49311a
- Merge pull request #2151 from hypothesis/dependabot/npm_and_yarn/npm-packlist-2.1.2 · 99ad7bfc
  Robert Knight authored May 12, 2020
```
Bump npm-packlist from 2.1.1 to 2.1.2
```
  99ad7bfc
- Merge pull request #2147 from hypothesis/dependabot/npm_and_yarn/karma-5.0.5 · 187889eb
  Robert Knight authored May 12, 2020
```
Bump karma from 5.0.4 to 5.0.5
```
  187889eb
- Remove unused annotator CSS · 023cf630
  Robert Knight authored May 12, 2020
```
 - Remove several unused classes and styles

 - Group all the CSS reset style rules for `.annotator-frame` together
```
  023cf630
- Merge pull request #2156 from hypothesis/svg-icon-cleanup2 · 7c8473b1
  Robert Knight authored May 12, 2020
```
Remove unused icons
```
  7c8473b1
- Merge pull request #2141 from hypothesis/remove-icomoon · bd4107ea
  Robert Knight authored May 12, 2020
```
Remove icomoon font and associated infrastructure
```
  bd4107ea
11 May, 2020 21 commits

Remove unused icons · 84cb056f
Kyle Keating authored May 11, 2020

84cb056f

Add negative top margin to “show x more in conversation” buttons · 3d146756

Lyza Danger Gardner authored May 11, 2020

Fine-tune the vertical alignment of the “Show x more in conversation”
hidden-thread toggling buttons so that they better align with thread
toggle chevrons.

Fixes #2097

3d146756

Merge pull request #2137 from hypothesis/aria-label-the-revenge · b24cd902
Lyza Gardner authored May 11, 2020
```
Adjust accessible text for groups menu label
```
b24cd902
Merge pull request #2153 from hypothesis/hardcode-toolbar-button-padding · 9dc86fda
Robert Knight authored May 11, 2020
```
Override `<button>` padding from page styles in toolbar
```
9dc86fda

Override `<button>` padding from page styles in toolbar · e1fc5e8c

Robert Knight authored May 11, 2020

Revert to hard-coded padding for the toolbar buttons to override any
default padding the page may have for `<button>` elements. This affects
PDF.js amongst other apps/sites. Instead of setting the padding to 0 as
before, set it to `1px 6px` which matches Chrome's defaults that looked
reasonable.

A better solution will be to use Shadow DOM for the whole sidebar UI,
but that is a larger change.

e1fc5e8c

Merge pull request #2152 from hypothesis/fix-toolbar-icon-alignment · 3d0d9330
Robert Knight authored May 11, 2020
```
Fix sidebar vertical toolbar button alignment
```
3d0d9330

Fix sidebar vertical toolbar button alignment · 5277df4c

Robert Knight authored May 11, 2020

The client's test page was missing a `<!DOCTYPE html>` declaration and
as a result rendered in _quirks mode_ rather than _standards mode_. This
hid an issue where the toolbar buttons were not centered correctly in
standards-mode documents.

This incorrect centering was caused by:

 1. The CSS bundle for the "annotator" part of the app not including the
    CSS styles for the `SvgIcon` component
 2. An unnecessary `padding` declaration on the `.annotator-frame-button`
    class

I haven't investigated in detail exactly which quirks-vs-standards mode
difference resulted in the centering still being OK in quirks-mode.

This commit fixes these two issues and fixes toolbar button centering in
both quirks and standards-mode documents.

It also updates the client's test page to add the `<!DOCTYPE html>`
declaration since standards mode is what most web content uses.

5277df4c

Bump dompurify from 2.0.10 to 2.0.11 · dc2d1304

dependabot-preview[bot] authored May 11, 2020

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.10 to 2.0.11.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.0.10...2.0.11)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

dc2d1304

Bump jquery from 3.5.0 to 3.5.1 · d550cd51

dependabot-preview[bot] authored May 11, 2020

Bumps [jquery](https://github.com/jquery/jquery) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/jquery/jquery/releases)
- [Commits](https://github.com/jquery/jquery/compare/3.5.0...3.5.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

d550cd51

Bump npm-packlist from 2.1.1 to 2.1.2 · 4fa74a83

dependabot-preview[bot] authored May 11, 2020

Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 2.1.1 to 2.1.2.
- [Release notes](https://github.com/npm/npm-packlist/releases)
- [Commits](https://github.com/npm/npm-packlist/compare/v2.1.1...v2.1.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

4fa74a83

Bump puppeteer from 3.0.2 to 3.0.4 · b8006eff

dependabot-preview[bot] authored May 11, 2020

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 3.0.2 to 3.0.4.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Commits](https://github.com/puppeteer/puppeteer/compare/v3.0.2...v3.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

b8006eff

Bump aws-sdk from 2.669.0 to 2.673.0 · f616b7a2

dependabot-preview[bot] authored May 11, 2020

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.669.0 to 2.673.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js/compare/v2.669.0...v2.673.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

f616b7a2

Bump karma from 5.0.4 to 5.0.5 · f615ee35

dependabot-preview[bot] authored May 11, 2020

Bumps [karma](https://github.com/karma-runner/karma) from 5.0.4 to 5.0.5.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v5.0.4...v5.0.5)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

f615ee35

Bump karma-coverage-istanbul-reporter from 2.1.1 to 3.0.2 · 69e630e5

dependabot-preview[bot] authored May 11, 2020

Bumps [karma-coverage-istanbul-reporter](https://github.com/mattlewis92/karma-coverage-istanbul-reporter) from 2.1.1 to 3.0.2.
- [Release notes](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/releases)
- [Changelog](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/compare/v2.1.1...v3.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

69e630e5

Bump fetch-mock from 9.4.0 to 9.5.1 · 63b4317f

dependabot-preview[bot] authored May 11, 2020

Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.4.0 to 9.5.1.
- [Release notes](https://github.com/wheresrhys/fetch-mock/releases)
- [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.4.0...v9.5.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

63b4317f

Merge pull request #2106 from hypothesis/fix-voiceover-sidebar-toggle · fdbd0f4a
Robert Knight authored May 11, 2020
```
Fix sidebar toggle button when using VoiceOver on iOS
```
fdbd0f4a

Rename `src/annotator/util/{dom -> dom-element.js}` · 90ba126b

Robert Knight authored May 11, 2020

Rename this module to distinguish it from `src/sidebar/util/dom.js`
which are generic DOM utilities that are not ponyfills for standard
methods.

See https://github.com/hypothesis/client/pull/2106/files#r420296891

90ba126b

Fix sidebar toggle button when using VoiceOver on iOS · 1dd909a2

Robert Knight authored May 01, 2020

When using iOS with VoiceOver enabled, double-tapping the sidebar toggle
button caused the sidebar to open and then immediately close. The
immediate close was caused by the `onElementTouchStart` handler in
`guest.coffee` that is intended to hide the sidebar when the user taps
somewhere in the document outside the sidebar. This handler did not
check however whether the event originated from annotator UI or not.

The fix here is to ignore any events which occur inside the sidebar
frame's container.

Fixes #1765

1dd909a2

Focus first item in menu when opened by any input method · fe3c9d4e

Robert Knight authored May 07, 2020

Previously the `Menu` component would focus the first item in the list if it was
opened by pressing Enter or Space but not if it was clicked. This meant that it
was not possible to mix input modalities (open menu with mouse, navigate using
keyboard) easily when using the menu. More importantly if the menu was opened
using a screen reader shortcut (eg. VoiceOver Key + Space on macOS) per the
screen reader's verbal instructions, the focus didn't change. My understanding
is that SR shortcuts generally simulate mouse rather than keyboard input.

fe3c9d4e

Remove icomoon font and associated infrastructure · 48b95888

Robert Knight authored May 11, 2020

Following https://github.com/hypothesis/client/pull/2138 all icons in
the client are rendered with inline SVGs via the `SvgIcon` component.

48b95888

Merge pull request #2138 from hypothesis/annotator-svg-icons · 12def07b
Robert Knight authored May 11, 2020
```
Use SVG icons in annotator toolbar
```
12def07b