Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 09 Dec, 2020 8 commits
    • Robert Knight's avatar
      Remove unnecessary `requestAnimationFrame` callbacks in `Guest` · 2a4045de
      Robert Knight authored 
      Profiling anchoring of large numbers of annotations in Chrome showed
that there was significant overhead for scheduling and
executing `requestAnimationFrame` callbacks. In the case of `Guest.anchor`, the
callback often did nothing (it called `removeHighlights` with an empty
array).

There isn't a need for this any more AFAICS so just invoke the logic
synchronously, which is much cheaper.
      2a4045de
    • Robert Knight's avatar
      Optimize `sortKeys` selector · 817d82f4
      Robert Knight authored 
      This was recomputing frequently even though the result only changes when
the selected tab changes.
      817d82f4
    • Lyza Danger Gardner's avatar
      Refactor `useRootThread` to memoize correctly · 945825da
      Lyza Danger Gardner authored 
      Also convert `selectionState` to use `createSelector` to avoid it
returning a different reference on each call.
      945825da
    • Lyza Danger Gardner's avatar
      Remove unused selector · 04a98682
      Lyza Danger Gardner authored 
      Remove unused selector and tidy up reference ordering
      04a98682
    • Lyza Danger Gardner's avatar
      Refactor `hasAppliedFilter` · 9fb70f45
      Lyza Danger Gardner authored 
      Refactor selectors for evaluating `hasAppliedFilter`
to remove cross-module state dependencies.
      9fb70f45
    • Lyza Danger Gardner's avatar
      Remove `threadState`, add supporting selectors · 6c2fe0f4
      Lyza Danger Gardner authored 
      Eliminate the enormous `threadState` `rootSelector`
and re-implement as multiple selectors. Refactor
`useRootThread` and threading integration tests
to account for these changes.
      6c2fe0f4
    • Lyza Danger Gardner's avatar
      Remove `filterState`; add `focusState` · 8999cc4b
      Lyza Danger Gardner authored 
      Refactor the computation of "filter state", that
is, all of the store state that impacts what
constitutes applied filters on annotations.
      8999cc4b
    • Lyza Danger Gardner's avatar
      Split `selection` store into `selection`, `filters` · e9b81457
      Lyza Danger Gardner authored 
      The `selection` store module has become overlong and
its responsibilities aren't clear. We know we'll be
adding some more filtering capabilities to the app
in the next short while, and that would make
`selection` even more complex and heavy.

Split into two store modules: `selection` and
`filters`.

Temporarily re-implement `rootSelector`s that
are needed for generating thread and filter
state for components.
      e9b81457
  3. 08 Dec, 2020 2 commits
    • Robert Knight's avatar
      Rename `dir` option to `direction` · 899a2831
      Robert Knight authored 
      The name `dir` is arguably ambiguous in this context.
      899a2831
    • Robert Knight's avatar
      Handle start or end element with no text in `TextRange.toRange` · 3d36ecee
      Robert Knight authored 
      When resolving a `TextRange` to a DOM `Range` there is an edge case
where the `start` or `end` position have an `offset` of `0` and the
element contains no text nodes.

Before this commit `toRange` would throw an `Offset exceeds text length`
error. A more useful behavior though is:

 - For the `start` position, to resolve it to the start of the next text node after
   `this.start.element`

 - For the `end` position, to resolve it to the end of the previous text
   node before `this.end.element`

This commit implements this behavior by first adding a `dir` option to
`TextPosition.resolve` to control what happens when the position's
offset is 0 and the element has no text and then specifying this option
when calling `this.{start, end}.resolve` in `TextRange.toRange`.
      3d36ecee
  5. 07 Dec, 2020 9 commits
  7. 04 Dec, 2020 1 commit
  9. 03 Dec, 2020 9 commits
    • Lyza Danger Gardner's avatar
      Correctly select Orphan tab when viewing direct-linked orphan · d7c316ea
      Lyza Danger Gardner authored 
      Previously, tab selection for direct-linked annotations was happening
before anchoring was complete—that means that orphaned annotations had
not yet been marked as being orphans (`$orphan`). Make sure that
direct-linked tab selection is checked any time the direct-linked
annotation changes.

Also fix a UI confusion in which the "Show All" button would show
the count of all annotations in this (direct-linked) state, which is
confusing because orphans don't count toward "All annotations" (nor do
page notes, FWIW).

Fixes #2686
      d7c316ea
    • Eduardo Sanz García's avatar
      Find annotation.css in a more robust way · 1ccf10d4
      Eduardo Sanz García authored 
      As indicated by @robertknight `document.styleSheets` is complete only when stylessheets are processed. This can take a while for certain heavy pages.

The alternative approach presented here to find `annotation.css` is warranted to find the url when the code is run.

Closes #2752
      1ccf10d4
    • Robert Knight's avatar
      Address minor PR feedback · 91f36486
      Robert Knight authored 
       - Add comment to explain purpose of `index.js`
 - Use a template string for readability
      91f36486
    • Robert Knight's avatar
      Remove obsolete `experimental.pdfSideBySide` config · f651eb3b
      Robert Knight authored 
      This feature is now enabled by default.
      f651eb3b
    • Robert Knight's avatar
      Extract logic for "Unload client" button out of `serve-dev.js` · e115dcec
      Robert Knight authored 
      Per discussion on the PR, it is preferable to put markup and JS in the
dev server in external files rather than as string literals in
`serve-dev.js`. This enables them to be edited without having to restart
the dev server.

 - Extract shared functions for loading and unloading client into
   `scripts/util.js`

 - Move logic specific to the index template into `scripts/index.js`.
      e115dcec
    • Robert Knight's avatar
      Change `hypothesis-asset` attribute to `data-hypothesis-asset` · 388838e6
      Robert Knight authored 
      Adding a custom attribute without a `data-` prefix could potentially
cause headaches for publishers running their code through HTML
validation tools.
      388838e6
    • Robert Knight's avatar
      Fix client load on dev server pages without toggle button · ddfe8eab
      Robert Knight authored 
      The toggle button only exists on the index page. Also I fixed an issue
where an incorrect variable name went unnoticed due to DOM element IDs
creating global variables (sigh).
      ddfe8eab
    • Robert Knight's avatar
      Add "Load client" / "Unload client" toggle button to dev server · eedbfdda
      Robert Knight authored 
      Add a button to the dev server to facilitate easy testing of unloading
and re-loading the client, as done by the browser extension and also
some third-party pages.
      eedbfdda
    • Robert Knight's avatar
      Remove all links, scripts and stylesheets when client is unloaded · a67e7787
      Robert Knight authored 
      Ensure that all links, script and stylesheet elements added to the page
by the boot script are removed when the client is unloaded.

This fixes a problem where the recently added `<link>` for the notebook
app was not removed when the page was unloaded, causing attempts to
activate the browser extension on a page where the client had previously
been loaded and then removed, to fail.

The implementation works by tagging all elements with a
`hypothesis-asset` attribute in the boot script and then removing these
elements when the client is unloaded.
      a67e7787
  11. 02 Dec, 2020 1 commit
    • Eduardo Sanz García's avatar
      Remove gap between bucket-bar and iframe · 0f4bb6e8
      Eduardo Sanz García authored 
      On mobile devices, reseting the zoom level (pinch gesture) leaves a one pixel gap between the bucket-bar and the iframe. By adding one extra pixel to the width of the bucket-bar we eliminate this issue.
      0f4bb6e8
  13. 30 Nov, 2020 10 commits