1. 14 Nov, 2017 1 commit
  2. 13 Nov, 2017 2 commits
    • Sean Hammond's avatar
      Merge pull request #573 from hypothesis/sort-oauth-tests · ed148af4
      Sean Hammond authored
      Re-arrange OAuth service tests
      ed148af4
    • Robert Knight's avatar
      Re-arrange OAuth service tests · 8666f000
      Robert Knight authored
      Move the tests for fetching and persistence of tokens from/to storage
      into the `describe('#tokenGetter', ...` block since this is the method
      called from outside the service that initiates the fetching /
      persistence.
      
      Also reword a couple of the test cases to be clearer now that the OAuth
      service now handles fetching tokens using methods other than exchanging
      grant tokens.
      8666f000
  3. 10 Nov, 2017 2 commits
    • Robert Knight's avatar
      Merge pull request #555 from hypothesis/elife-ui · a27d83b9
      Robert Knight authored
      Change UI for Elife.
      a27d83b9
    • Sheetal Umesh Kumar's avatar
      Implement new customisation options for the sidebar’s display. · 396fce0e
      Sheetal Umesh Kumar authored
      See https://github.com/hypothesis/product-backlog/issues/350
      
      Add config options for the following:
      
      disableToolbarCloseBtn: false/true
      Disables and hides the close button on the toolbar
      
      disableToolbarMinimizeBtn: true/false
      Disables and hides the minimize button on the toolbar
      
      disableToolbarHighlightsBtn: true/false
      Disables and hides the highlights button on the toolbar
      
      disableToolbarNewNoteBtn: true/false
      Disables and hides the new note button on the toolbar
      
      disableBucketBar: true/false
      Disables and hides the bucket bar
      
      enableSidebarDropShadow: true/false
      Turns on the dropshadow for the sidebar
      
      theme: 'clean'
      Turns on the 'clean' theme for the sidebar. By default the classic view(with annotation cards) is turned on, which the rest of the Hypothesis users will see.
      
      usernameUrl: 'someurl/'
      The url to direct a user to when their username in the annotation is clicked.
      396fce0e
  4. 08 Nov, 2017 15 commits
  5. 07 Nov, 2017 16 commits
  6. 06 Nov, 2017 3 commits
  7. 26 Oct, 2017 1 commit
    • Robert Knight's avatar
      Add missing page index bounds check · a2336a7c
      Robert Knight authored
      When anchoring an annotation with a position and a quote selector, if
      the position selector fails, then PDF anchoring searches page contents
      starting with those pages nearest the position.
      
      If the position selector's `start` offset was greater than the length of
      the PDF's text, `prioritizePages` would try to fetch the text of page
      indexes beyond the valid range, causing PDF.js to throw an exception and
      quote anchoring to fail.
      
      Fix this by adding a missing bounds check.
      
      This is a partial fix for #558. It fixes anchoring of one of two test
      annotations on that page. The other fails due to differences in the
      extracted text between the HTML and PDF versions of the article.
      a2336a7c