- 30 Apr, 2014 2 commits
-
-
Randall Leeds authored
Since the token changes whenever the list of personas changes just refactor the logic in the token watcher to cause exactly one search to happen when the token changes without consulting a separate property, simply by checking the tool state.
-
Randall Leeds authored
-
- 28 Apr, 2014 1 commit
-
-
Randall Leeds authored
This reverts commit ca43ccc1d9559476f95c714c1b055194f03dd0c2.
-
- 24 Apr, 2014 9 commits
-
-
csillag authored
These should have been added along with the rest in 8c7db59e05dd7757989f6b31a19edef6cfb686fd
-
Randall Leeds authored
Since the highlight code uses jQuery's .offset() we don't need to factor in the wrapper offset. Close #931
-
Ujvari Gergely authored
The root core of problem #1179 is actually an upstream problem. Our code is only necessary until we can consume the fixed version of annotator.
-
csillag authored
-
csillag authored
-
csillag authored
When we receive updated versions of existing annotations from the other side of the bridge, not only merge those changes, but announce them with the appropriate event, too. Based on changes originally introduced here: https://github.com/hypothesis/h/commit/1d4e9f32cc4f8c7db5ffdac7adad90e9cbf88db6#diff-5
-
Ujvari Gergely authored
In the past when we were switching users the previous user data has remained inside the Permissions.options.permissions object. This way, our newly created annotations had all the previous logged in user's permissions in their permission list which wat totally wrong. In this fix when logging in/out this options.permissions object is resetted too. (Along with the user) Fixes #1179
-
Randall Leeds authored
-
Randall Leeds authored
-
- 21 Apr, 2014 2 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
Search each one individually. This was always the intent but the code was wrong.
-
- 20 Apr, 2014 3 commits
-
-
Randall Leeds authored
This is in preparation for adding these things to the site pages.
-
Randall Leeds authored
-
Randall Leeds authored
Close #1174
-
- 17 Apr, 2014 1 commit
-
-
Randall Leeds authored
This eliminates the subscriber hack and allows us to use the check_csrf view predicate in the future by making Angular send the header that Pyramid expects.
-
- 16 Apr, 2014 4 commits
-
-
Randall Leeds authored
Close #1172
-
Randall Leeds authored
And get rid of the resettable directive. Since Angular added the `$setPristine` method, we can wrap the errors in a check that the control is dirty.
-
Randall Leeds authored
This code doesn't do any DOM manipulation so its better kept as a controller.
-
Randall Leeds authored
-
- 14 Apr, 2014 2 commits
- 13 Apr, 2014 1 commit
-
-
Randall Leeds authored
This simplifies the tests a little bit, maybe it will be more robust??? Also seems like a useful thing to do anyway.
-
- 11 Apr, 2014 2 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
This reverts commit 28c48518c064b6c0769b43d7ddcdbbe89a169926. Reverted until @csillag shows me why this is a significant win because otherwise it is code here that has nothing to do with the toolbar.
-
- 10 Apr, 2014 1 commit
-
-
csillag authored
-
- 06 Apr, 2014 1 commit
-
-
Randall Leeds authored
More minor tidy of OSX docs
-
- 05 Apr, 2014 2 commits
-
-
csillag authored
-
gergely-ujvari authored
With the page search you can search for the username, but for redacted annotation the user filter gives back a null as a username, and we tried to convert this to lowercase() Fixes #1160
-
- 02 Apr, 2014 9 commits
-
-
gergely-ujvari authored
Since, for document view to had to add the new annotation manually to the rootScope.annotations, we have forgotten to check whether is it a reply or not. Now replies are not added. The original error also went away when the view(scope) was changed.
-
Randall Leeds authored
-
Randall Leeds authored
When we deploy as an extension the application baseURI is the URL of the backend, rather than the extension. As a result, templates are relative to this location. Even though we inline the templates in the extension bundle, we have to ensure the compilation isn't blocked by strict contextual escaping.
-
gergely-ujvari authored
When we sacked the scope search facets and rely on rootScope.annotations the replies were no longer tested as possible search results. It is now restored.
-
Randall Leeds authored
This was causing a race condition on app startup. Now, the worst that happens is the flash message shows in the sidebar.
-
gergely-ujvari authored
If not doing this the rootScope.predicate etc. variables are not set and angular silently fails sorting Fixes #1150
-
gergely-ujvari authored
The rootScope.annotations was not refreshed when a new real-time annotation arrived, so for comments and document view we have to insert the annotation there manually Fixes #1149
-
gergely-ujvari authored
As for the sort the page search works with threads instead of annotations so the directive should look for either annotation or thread.message in the scope Page search focuses annotations when it opens them. Thx @csillag for the help
-
gergely-ujvari authored
Originally page search was not prepared for the sort viewState, now it is. For this, the applySort() was refactored to use the rootScope instead of the scope and produces both the predicate for the viewer and for the page search Fixes #1148
-