- 21 Sep, 2020 5 commits
-
-
Robert Knight authored
- Remove an `Object.assign` in favor of object spread - Remove an unused `ctx` argument to `emitGuestEvent` - Rewrite several test descriptions for readability - Re-order stub initializations in `beforeEach` to be more alphabetical
-
Robert Knight authored
This is the result of an automated conversion by decaffeinate followed by a manual review and clean-up of the result.
-
Robert Knight authored
To avoid confusion with different meanings of `this` between the callback and surrounding scope, get the element from callback arguments instead.
-
Robert Knight authored
The `options` field is always initialized to an object, so the `|| {}` is not necessary.
-
Robert Knight authored
-
- 18 Sep, 2020 1 commit
-
-
Eduardo Sanz García authored
closes #2009
-
- 17 Sep, 2020 6 commits
-
-
https://github.com/hypothesis/clientEduardo Sanz García authored
Merge branch 'master' of https://github.com/hypothesis/client into bucket-bar-background-opaque-2526
-
Eduardo Sanz García authored
-
dependabot-preview[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.32 to 8.0.3. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/7.0.32...8.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Eduardo Sanz García authored
-
https://github.com/hypothesis/clientEduardo Sanz García authored
Merge branch 'master' of https://github.com/hypothesis/client into bucket-bar-background-opaque-2526
-
Eduardo Sanz García authored
Added a better structure, comments, and a variable
-
- 16 Sep, 2020 3 commits
-
-
Eduardo Sanz García authored
-
dependabot-preview[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.1.1...2.1.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.752.0 to 2.753.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.752.0...v2.753.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 15 Sep, 2020 12 commits
-
-
Lyza Danger Gardner authored
Fixes #1537
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.22.3 to 5.23.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.22.3...5.23.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 5.2.1 to 5.3.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v5.2.1...v5.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-core/compare/v4.0.1...v4.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [terser](https://github.com/terser/terser) from 5.3.0 to 5.3.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/compare/v5.3.0...v5.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 5.2.1 to 5.2.2. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.2.1...v5.2.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
-
Robert Knight authored
As part of the gradual removal of jQuery from the annotator part of the app, replace it with DOM APIs in `Host` and `Sidebar`.
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.0.5 to 18.0.6. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.0.5...v18.0.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.1.0 to 4.1.2. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.8.1 to 7.9.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.8.1...v7.9.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.747.0 to 2.752.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.747.0...v2.752.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 14 Sep, 2020 1 commit
-
-
Robert Knight authored
When store modules were refactored to only receive their local state in selectors, the code in `store/modules/real-time-updates` which directly uses selectors from other modules rather than calling `store.<selectorMethod>(...)` was not updated to pass in the appropriate part of the state. Fixing this resolves two problems: - An error when processing notifications of deleted annotations from the server. These notifications are currently not getting delivered due to a server-side issue (see https://github.com/hypothesis/h/pull/6214). - Filtering notifications of new or updated annotations not excluding annotations from groups that are not currently focused. Fixing this second issue has the side effect that it _appears_ to fix https://github.com/hypothesis/support/issues/137 from the user's point of view. I say _appears to_ because the backend is still incorrectly delivering notifications that the user shouldn't be able to see. That is fixed by https://github.com/hypothesis/h/pull/6202
-
- 11 Sep, 2020 3 commits
-
-
dependabot[bot] authored
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Rename `injectToFrame` => `injectIntoFrame` and make some small improvements to the function.
-
Robert Knight authored
Convert this class to JS and make some basic documentation improvements.
-
- 10 Sep, 2020 1 commit
-
-
Robert Knight authored
Convert the `Delegator` base class to JS and rewrite the documentation to match current functionality and usage. Also simplify the `options` initialization and add a note about why the constructor reads `this.options` before assigning it. I tried to convert the `Plugin` class as well but encountered an issue with interaction between Babel-compiled derived classes and CoffeeScript sub-classes (in particular, the `BucketBar` class), so it looks like `Plugin` sub-classes will need to be converted first.
-
- 09 Sep, 2020 2 commits
-
-
Lyza Danger Gardner authored
Consolidate annotation-editing logic and sub-components within `AnnotationEditor`. `AnnotationBody` is for rendering content, and `Annotation` is relieved of managing editing-related callbacks. These changes also add a new feature: When saving an annotation, `AnnotationEditor` will check the contents of `TagEditor`'s input element. If any text remains there that has not yet bet "committed" as a tag, that text will be added as a tag. This is to prevent tags accidentally getting "lost" on save. Fixes https://github.com/hypothesis/product-backlog/issues/1122
-
Lyza Danger Gardner authored
This component will take over the editing-related responsibilities from `AnnotationBody` and `Annotation`
-
- 08 Sep, 2020 6 commits
-
-
Robert Knight authored
This selector is not referenced anywhere else in the code.
-
Robert Knight authored
- Fold `highlightsAt` into `annotationsAt` as it is only used in one place - Rename `xor` variable to a more obvious name
-
Robert Knight authored
The `Delegator` events system was used for handling two kinds of event: - DOM events on highights and document elements - Custom events internal to the "annotator" module The handling of DOM events has been moved into the `Guest` class, so `Delegator` is now used only to subscribe to and publish internal events. This commit removes the DOM event handling code. There is an existing issue, noted in this commit, that the `destroy` method only removed event handlers declared via the `events` property and not those added later by `subscribe`.
-
Robert Knight authored
This removes the last remaining usage of the `events` property of `Delegator`, enabling that code to be removed.
-
Robert Knight authored
The way that the `Guest` class listened to clicks on highlights and the document involved a DOM event-listening abstraction in `Delegator` that is no longer used for anything else in the code. This indirection made it more complicated to follow how these events were handled. This commit replaces the event handling for clicks, hovers and taps on highlights and the page with regular DOM event listeners in the `Guest` class.
-
dependabot-preview[bot] authored
Bumps [whatwg-fetch](https://github.com/github/fetch) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/github/fetch/releases) - [Commits](https://github.com/github/fetch/compare/v3.4.0...v3.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-