1. 21 Sep, 2020 5 commits
  2. 18 Sep, 2020 1 commit
  3. 17 Sep, 2020 6 commits
  4. 16 Sep, 2020 3 commits
  5. 15 Sep, 2020 12 commits
  6. 14 Sep, 2020 1 commit
    • Robert Knight's avatar
      Fix real-time update action processing · 9479612f
      Robert Knight authored
      When store modules were refactored to only receive their local state in
      selectors, the code in `store/modules/real-time-updates` which directly
      uses selectors from other modules rather than calling
      `store.<selectorMethod>(...)` was not updated to pass in the appropriate
      part of the state.
      
      Fixing this resolves two problems:
      
       - An error when processing notifications of deleted annotations from
         the server. These notifications are currently not getting delivered
         due to a server-side issue (see https://github.com/hypothesis/h/pull/6214).
      
       - Filtering notifications of new or updated annotations not excluding
         annotations from groups that are not currently focused.
      
         Fixing this second issue has the side effect that it _appears_ to fix
         https://github.com/hypothesis/support/issues/137 from the user's
         point of view. I say _appears to_ because the backend is still
         incorrectly delivering notifications that the user shouldn't be able
         to see. That is fixed by https://github.com/hypothesis/h/pull/6202
      9479612f
  7. 11 Sep, 2020 3 commits
  8. 10 Sep, 2020 1 commit
    • Robert Knight's avatar
      Convert `Delegator` base class to JS · 2e0eee75
      Robert Knight authored
      Convert the `Delegator` base class to JS and rewrite the documentation
      to match current functionality and usage. Also simplify the `options`
      initialization and add a note about why the constructor reads
      `this.options` before assigning it.
      
      I tried to convert the `Plugin` class as well but encountered an issue
      with interaction between Babel-compiled derived classes and CoffeeScript
      sub-classes (in particular, the `BucketBar` class), so it looks like
      `Plugin` sub-classes will need to be converted first.
      2e0eee75
  9. 09 Sep, 2020 2 commits
  10. 08 Sep, 2020 6 commits