- 04 Apr, 2017 2 commits
-
-
Sean Hammond authored
Remove unused controller properties
-
Sean Hammond authored
Remove obsolete `ng-cloak` directives
-
- 03 Apr, 2017 12 commits
-
-
Robert Knight authored
Add Slack link to README
-
Robert Knight authored
Invite users and potential contributors to join us on Slack as well as IRC.
-
Robert Knight authored
Add docs explaining how to test the client on a real mobile device
-
Robert Knight authored
Use angle brackets to indicate that HOSTNAME is a placeholder rather than a dollar-sign to avoid confusion with the `$HOSTNAME` env var.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
* Add note about possible need to add `.local` or `.home` suffix or use IP address instead of hostname. * Use title case for heading.
-
Robert Knight authored
Merge pull request #333 from hypothesis/fix-annotating-sites-with-broken-Function.bind-polyfills-take-3 Fix annotating sites with broken function.bind polyfills take 3
-
Robert Knight authored
Add a lint rule to ensure that new developers do not use `bind` in annotator/ code. This only applies to first-party code. Third-party code used in the annotation layer is still at-risk of being broken by old `bind` polyfills.
-
Sean Hammond authored
Don't call the parent browsing environment's Function.bind() function from the src/annotator code. Some parent pages modify Function.protoype.bind(), for example replacing it with their own broken bind() polyfill, and this causes our code to crash. Work around this by just not using bind(). Fixes #245
-
Robert Knight authored
Translate annotation-sync.coffee to JavaScript
-
Sheetal Umesh Kumar authored
Use new endpoint for creating an annotation flag
-
- 31 Mar, 2017 24 commits
-
-
Sean Hammond authored
This function has no tests and I don't know what it does but sometimes `undefined` is passed to it as the `annotations` arg and it crashes, so fix that.
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
This was a CoffeeScript-generated variable.
-
Sean Hammond authored
This was a CoffeeScript-generated variable.
-
Sean Hammond authored
These were generated by CoffeeScript (due to its implicit returns) but don't actually appear to be necessary.
-
Sean Hammond authored
Minimal changes to the CoffeeScript-generated annotation-sync.js to stop `make lint` complaining about it, while still having `make test` pass.
-
Sean Hammond authored
annotation-sync.js is the unmodified output of `coffee -bc src/annotator/annotation-sync.coffee`.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fix Mobile Safari Scrolling
-
Sean Roberts authored
* master: Add tests for sidebar closing when user clicks or taps in document Fixing tapping anchored annotations not opening sidebar Fixing sidebar not closing on outside content click issue eslint: Ignore docs/_build Update ESLint to v3.18.0
-
Robert Knight authored
Since the `<thread-list>` is now contained within a scrollable element which is not `document.body`, it needs to scroll that element rather than the window in order to scroll the element into view. * Remove the hard-coded selector used to find the scroll root and instead search for the closest ancestor element to the `<thread-list>` whose computed style has `overflowY` set to `scroll`. * Set the scroll root Element's `scrollTop` to scroll the thread list instead of calling `window.scroll` * Compute the maximum scroll offset based on the `scrollTop` and `scrollHeight` properties of the scroll root element instead of using `document.body.scrollHeight`. * Update tests for `<thread-list>` to check for the scrollable ancestor being scrolled instead of the window.
-
Robert Knight authored
Fixing sidebar not closing on outside content click issue
-
Robert Knight authored
-
Robert Knight authored
Fixing tapping anchored annotations not opening sidebar
-
Robert Knight authored
Testing the client on a mobile device currently requires several steps which will be non-obvious to new developers. Add documentation to guide users through the process.
-
- 30 Mar, 2017 2 commits
-
-
Sean Roberts authored
-
Sean Roberts authored
-