1. 08 Nov, 2017 15 commits
  2. 07 Nov, 2017 16 commits
  3. 06 Nov, 2017 3 commits
  4. 26 Oct, 2017 1 commit
    • Robert Knight's avatar
      Add missing page index bounds check · a2336a7c
      Robert Knight authored
      When anchoring an annotation with a position and a quote selector, if
      the position selector fails, then PDF anchoring searches page contents
      starting with those pages nearest the position.
      
      If the position selector's `start` offset was greater than the length of
      the PDF's text, `prioritizePages` would try to fetch the text of page
      indexes beyond the valid range, causing PDF.js to throw an exception and
      quote anchoring to fail.
      
      Fix this by adding a missing bounds check.
      
      This is a partial fix for #558. It fixes anchoring of one of two test
      annotations on that page. The other fails due to differences in the
      extracted text between the HTML and PDF versions of the article.
      a2336a7c
  5. 25 Oct, 2017 1 commit
    • Robert Knight's avatar
      Strip unknown query params when generating Internet Archive embed URLs · 4d05b426
      Robert Knight authored
      Internet Archive details pages may include params in the query string
      as well as "start" and "end" params in the path. In that case invalid
      URLs were being generated.
      
      Use a more robust approach to generating embed URLs and add some missing
      test cases. Any unrecognized query params are ignored when generating
      the embed URLs.
      4d05b426
  6. 23 Oct, 2017 4 commits