Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 23 Apr, 2019 2 commits
  3. 22 Apr, 2019 16 commits
  5. 20 Apr, 2019 8 commits
  7. 19 Apr, 2019 1 commit
  9. 18 Apr, 2019 2 commits
    • Hannah Stepanek's avatar
      Add sidebar-content-error react component · 95884580
      Hannah Stepanek authored
      95884580
    • Robert Knight's avatar
      Remove fragment anchoring support · f8784b2c
      Robert Knight authored 
      dom-anchor-fragment is shipped as a UMD module which causes problems on
pages that declare a global function called `define` (see #479).

While we could fix the module, fragment anchoring is not very useful at
the moment. The client primarily anchors to the quote and uses other
anchors only as an optimization. The Wikipedia baseline tests changed in
this PR show how little value a fragment has on real websites.
Therefore, just remove support for generating and using fragment selectors.

This change should not cause anchoring regressions, as anchoring would
only have succeeded previously if the quote selector matched. Now it will just
fall through to anchoring using the range, position or quote selectors instead.

Fixes #479
      f8784b2c
  11. 17 Apr, 2019 2 commits
    • Hannah Stepanek's avatar
      Merge pull request #1070 from hypothesis/faster-group-selectors · a63ef4a6
      Hannah Stepanek authored 
      Make group selectors more efficient
      a63ef4a6
    • Robert Knight's avatar
      Make group selectors more efficient · ea09632a
      Robert Knight authored 
      Ensure that selectors for getting the "My groups", "Currently viewing
groups" and "Featured groups" lists only recompute when the groups state
changes. Previously they would have recomputed when _any_ part of the state changed.

More generally, we should be using `createSelector` rather than
`memoize` whenever we have a place in the app that needs to extract a subset
of data from some larger structure and derive some data from that.
      ea09632a
  13. 15 Apr, 2019 9 commits