- 09 Jun, 2016 1 commit
-
-
Sheetal Umesh Kumar authored
In order to make it easier to change the document metadata retrieved for PDFs, this commit moves the code responsible for extracting that metadata into a separate (tested) service. We also remove our reliance on the `PDFViewerApplication.loading` which was removed from the bundled version of PDF.js in August 2015. Instead we simply check to see if `PDFViewerApplication.documentFingerprint` is available. If not, we listen for the first 'documentload' event before extracting metadata from the `PDFViewerApplication`.
-
- 07 Jun, 2016 3 commits
-
-
Robert Knight authored
Remove old features from FEATURES_PENDING_REMOVAL
-
Nick Stenning authored
Load annotation from DB in streamer
-
Christof Dorner authored
Add non-nullable and default values to annotation.extra
-
- 06 Jun, 2016 3 commits
-
-
Robert Knight authored
* Implement new design for hovered conversation threads Implement the new design for hovered replies from https://trello.com/c/aXCXxzx2 . The most visible effect is that conversation threads have a grey background when hovered. In the process of implementing the new styling, there is some cleanup of the CSS: * Use `--reply`/`--top-reply` modifier classes on <annotation> and <annotation-thread> elements to style annotations, top-level replies and nested replies differently. This makes the CSS simpler and reduces the risk of unexpected side effects that come with descendant selectors. * Rename `thread` CSS classes to match the name of the component that they are used in, `annotation-thread`. * Move 'annotation-unavailable-message' styling to app.scss This class is used in the root template (viewer.html) not the <annotation-thread> component. * Darken expand/collapse toggle arrow only when annotation itself is hovered Darken the expand/collapse arrow when an annotation is hovered but not when its replies are hovered. * Remove no-op CSS class The `clear: both` styling had no effect because <annotation-thread> is now using flexbox rather than floats for layout. * Do not show 'Hide replies' link for replies For replies there were two different ways to collapse the annotation card, the expand/collapse toggle arrow and the 'Hide replies' link. Removing the 'Hide replies' link avoids having two ways to do the same thing and makes the cards look cleaner. * Remove the light grey background for hovered replies Following design review, remove the grey background for hovered replies. * Make rendering of dashed lines to the left of replies better in Chrome Previously the dashed line started at the top of the <annotation-thread> component and the top part was covered up by the thread expand/collapse toggle. In Chrome the alignment of dashes within a dashed border varies as the height of the element changes [1]. Therefore depending on the height of the reply, this could result in the visible part of the line below the collapse/expand toggle starting at either a gap or dash in the line. By instead moving the dashed line to a separate element which is positioned beneath the expand/collapse toggle, the first visible dash in the reply line always appears in the same place and is aligned correctly with the annotation content to its right. [1] See http://www.impressivewebs.com/comparison-css-border-style/ for a visual representation of why this is done.
-
Robert Knight authored
This adds an integration test for anchoring of annotations loaded into the annotator guest via the sidebar. This was extracted from https://github.com/hypothesis/h/pull/3313 The test case for nested annotations has been marked as an expected failure until a better resolution for #3278 has been found.
-
Robert Knight authored
Fix distracting 404s in karma/phantom test output
-
- 03 Jun, 2016 4 commits
-
-
Sean Hammond authored
Use new TokenAuthenticationPolicy and remove cruft
-
Christof Dorner authored
Feature flags cohorts: Add Feature Cohorts admin panel
-
Sean Hammond authored
Add a TokenAuthenticationPolicy for bearer tokens
-
Christof Dorner authored
Remove additional margin at foot of annotation card
-
- 02 Jun, 2016 5 commits
-
-
Robert Knight authored
Move canonical annotation list sort state to Redux store
-
Nick Stenning authored
This fixes some distracting warnings in the test output.
-
Nick Stenning authored
This is a minor tweak so that we don't try and use CoffeeScripts "x in y" (which reduces to "y.indexOf(x) !== -1") when y is undefined).
-
Robert Knight authored
This is a step towards getting us to a place where all important state in the front-end app is managed in the same way - kept in the Redux store and modified only via actions. The sort state was duplicated as a property on the $scope and also stored in the Redux store. Instead just expose functions on the scope which retrieve this state directly from the store and dispatch an action to the store when the user selects a different sort mode. In addition, the terminology for sorting has been normalised across the application (sortBy/sortOptions -> sortKey/sortKeysAvailable), and the ability to sort the stream has been removed, as it was nonsensical and broken.
-
Christof Dorner authored
Fix icon spacing
-
- 01 Jun, 2016 10 commits
-
-
Nick Stenning authored
There should be 15px, not 20px of margin at the bottom of the annotation card, just as at the top. Removing this CSS means that the annotation footer has no bottom margin and the 15px is provided for all sizes of the card by padding on .annotation-card.
-
Nick Stenning authored
The annotation action buttons are inline-block elements which means that whitespace between the tags results in inserted whitespace in the document when rendered. This rendered whitespace is roughly 4px wide. Instead, switch the layout of the annotation actions div to use flexbox, in which no such whitespace is inserted, and add 4px to the margin on the buttons.
-
Nick Stenning authored
The annotation action icons didn't seem to be equally spaced due to excess whitespace on either side of the icons within the font glyphs. This commit updates the edit, reply and share icons to remove excess whitespace. Where previously these three icons were 16px wide (and the trash icon was 9.5px wide) they are now 14px, 13.5px, and 12px wide respectively.
-
Sean Hammond authored
Use the "HTML" link for the annotation timestamp
-
Nick Stenning authored
The timestamp wasn't originally specified to be switched to the "in-context" link, so this commit makes sure that it always points to the "HTML" representation of the annotation, if that link is available.
-
Sean Hammond authored
Fix display of <ul>, <ol> in annotations
-
Sean Hammond authored
URL encode share links
-
Nick Stenning authored
9be804d broke the display of <ul> and <ol> tags in annotation cards by overriding a bit more than intended -- specifically, it set `list-style: none;` on <li> in reset.scss when the Compass reset mixins didn't do that. This commit fixes the issue by only setting `list-style: none;` on <ul> and <ol>, which means that the list styles in styled-text.scss can take effect as originally intended.
-
Nick Stenning authored
The URL query parameter in these links needs to be URL encoded in order to guarantee that the receiving services can correctly parse the URL. Sending an incorrectly-encoded URL such as http://example.com/hello world.pdf can result in the parameter just being ignored (by, for example, the Twitter intent endpoint).
-
Nick Stenning authored
To allow URL encoding strings in Angular templates.
-
- 31 May, 2016 1 commit
-
-
chdorner authored
The streamer will now only send the annotation id when the action is delete. Thus we can't check if the annotation's group is currently focused when the action is `delete`.
-
- 30 May, 2016 11 commits
-
-
Robert Knight authored
Prepare the direct_linking feature flag for removal
-
Robert Knight authored
-
Christof Dorner authored
Show adder when the selection changes
-
Christof Dorner authored
Fix client on pages that define a variable called `global`
-
Robert Knight authored
Modules which assume the existence of a global variable called "global" (which exists in Node) are wrapped by Browserify during the build which normally results in "global" being aliased to "self" or "window" in a browser environment. If code on the page into which H is loaded defines a global variable called "global" however, that gets used instead and this can break such modules. In the case of https://www.civilsprep.com, "global" is a reference to a DOM node for example. This commit fixes the issue by only aliasing "global" (as seen by the module using it) to either "window" or "self" and not to any existing variable called "global". Fixes #2723
-
Nick Stenning authored
This is now deployed and enabled for everyone so we can remove the flag.
-
Robert Knight authored
Make "/app" endpoints relative to serviceUrl
-
Nick Stenning authored
As reported by Donny Donovan from EJP, requests to "/app*" related endpoints weren't correctly being constructed relative to the configured "serviceUrl", which makes the client less portable. This change removes a leading slash from the path supplied to the URL constructor, ensuring that if "serviceUrl" is not at the root of a domain, the "/app*" paths will still be correctly constructed.
-
Robert Knight authored
Extract functions for generating and manipulating observable streams which are not text-selection-specific out of `selections.js` into a separate utility module.
-
Robert Knight authored
When using touch input to manipulate the selection there are no mousedown/mouseup events that we can listen to and the touchstart/touchend events are not triggered when manipulating the OS-provided selection handles in the browser. Instead listen for selectionchange events and show the adder in response. To avoid showing the adder every time the selection handle moves which would be distracting, we instead buffer selectionchange events and only show them after a pause. When the user is using mouse input to make a selection, we ignore selectionchange events so that the adder does not appear until the user finishes making their selection.
-
Robert Knight authored
In preparation for some more complex handling of document events in order to show the adder when the selection changes on mobile, refactor the processing of events to use observables. The zen-observable package is used as a lightweight implementation of the proposed ES2017 [Observable](https://github.com/zenparsing/es-observable) API.
-
- 27 May, 2016 1 commit
-
-
Christof Dorner authored
devserver: Extend ALLOWED_ORIGINS instead of overriding it
-
- 26 May, 2016 1 commit
-
-
Robert Knight authored
Add padding, fix hover state colours, tweak shadow
-