- 22 Jan, 2024 3 commits
-
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1536.0 to 2.1540.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1536.0...v2.1540.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.4.16 to 10.4.17. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/10.4.16...10.4.17) --- updated-dependencies: - dependency-name: autoprefixer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
When a selection exists, it replaces other filters rather than being combined with them. Disable the other filter controls in the UI in this case to make it more obvious how the filters are being applied.
-
- 19 Jan, 2024 5 commits
-
-
Robert Knight authored
Several pieces of code tested only for the presence of keys in `focusFilters` to determine whether a focus filter was configured, rather than whether the property was set to a "valid" value for that particular filter. The `changeFocusModeUser` store action would always set this property, instead of removing it when the passed user info was empty (logically meaning "no user is focused"). Fixes https://github.com/hypothesis/client/issues/6109
-
Robert Knight authored
When the user clicks highlight(s) in the document and makes a "selection" in the sidebar, we want the selected threads to always be visible. Previously this was handled by clearing other types of filter when the selection was made, in addition to setting the selection. This however meant that after the selection was cleared, the state was different than prior to making the selection, with any non-selection filters being disabled. This commit changes the behavior so that the selection, if present, temporarily overrides other filters rather than being combined with them. This allows the selection to later be removed to revert back to the previous state.
-
Robert Knight authored
When focus filters are in use (eg. user / page filters) it is annoying if clicking a highlight in the document and then clearing the selection has the effect of disabling the focus filters. Instead the plan is to have the selection temporarily replace filters when active.
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
- 18 Jan, 2024 4 commits
-
-
Robert Knight authored
When the search panel is open, filter controls are displayed inside it. To make filter controls accessible when the search panel is closed, render standalone controls from `SidebarView`, wrapper in a container card. Rendering of the card is handled by `FilterControls`, so that the logic for conditionally rendering depending on whether filters are configured, does not need to be duplicated.
-
Robert Knight authored
Now that the icon has been added to @hypothesis/frontend-shared, use it in the filter controls.
-
Robert Knight authored
-
Alejandro Celaya authored
-
- 17 Jan, 2024 5 commits
-
-
Robert Knight authored
Update style of filter toggle buttons to align them with the current mocks. Also fix accessibility of the pressed state by using the `pressed` button prop to indicate whether the toggle is active. Part of https://github.com/hypothesis/client/issues/6006.
-
Robert Knight authored
Update the watch glob used by the gulp task.
-
Robert Knight authored
Take initial steps to update the design of the search panel and filter controls to align with the mocks in https://github.com/hypothesis/client/issues/6006. - Move the filter status UI into the search panel. This reduces the amount of vertical space required when a search and/or filter are active. - Replace the filter status description string + single filter state toggle with a row of toggle buttons, one per filter. Using one toggle button per filter allows the user to toggle the different filter states independently. Removing the filter description saves space and also it was getting increasingly complicated to construct descriptions of all the possible search/filter combinations.
-
Alejandro Celaya authored
-
Robert Knight authored
-
- 16 Jan, 2024 8 commits
-
-
Robert Knight authored
As part of the filter UI overhaul we want to make it easier to toggle filters independently, which enables going back / forward one step at a time. For the search panel, this means that closing search should not affect other filters.
-
Robert Knight authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Robert Knight authored
Align how `useRootThread` determines the `showTabs` argument it passes to `threadAnnotations` with the way `SidebarView` determines whether to render the tabs. The logic is not quite the same because `SidebarView` has some additional conditions related to direct-linking errors. However this has been ignored to align with the way `useRootThread` worked prior to the most recent changes. The changes here are intended to be temporary: once the new search UI is enabled for everyone, the tabs will always be shown and the logic will become much simpler.
-
Alejandro Celaya authored
-
- 15 Jan, 2024 15 commits
-
-
Robert Knight authored
These should not appear on any tab or be included in `tabCounts` output.
-
Robert Knight authored
This matches the behavior from earlier versions when tabs were shown. Unlike previously, we now always show tabs in the sidebar, so this means that conversations without a root annotation will always be hidden in this context, whereas previously they could be hidden until you performed a search, which could be confusing.
-
Robert Knight authored
The `store.clearSelection()` call currently clears the selection and also all other filters, which means that switching tabs changed several things in the UI beyond just the current tab. Change this so it just changes the tab.
-
Robert Knight authored
This makes the UI more consistent across filter active/inactive states and removes the need to show a total number of annotations in the search result summary, since that continues to be visible on the tabs when a filter is active.
-
Robert Knight authored
Previously the thread counts shown on tabs in the sidebar were computed from the full set of annotations in the store, not taking into account any filters that are active. This was acceptable because the tabs were hidden if a filter was active. However we are planning to change this and thus we need to compute tab counts that include the effects of active filters. - Change `threadAnnotations` to compute thread counts per tab, as well as the thread itself. This is done by not filtering top-level threads in `buildThread` but instead doing a filtering pass later, which also computes the thread count for each tab. - Change `SelectionTabs` to take the tab counts as a prop, instead of getting the count from the store.
-
Alejandro Celaya authored
-
Robert Knight authored
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 3.1.1 to 3.2.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/3.1.1...3.2.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the sentry group with 2 updates: [@sentry/browser](https://github.com/getsentry/sentry-javascript) and [@sentry/cli](https://github.com/getsentry/sentry-cli). Updates `@sentry/browser` from 7.92.0 to 7.93.0 - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.92.0...7.93.0) Updates `@sentry/cli` from 2.24.1 to 2.25.0 - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/2.24.1...2.25.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the rollup group with 1 update: [rollup](https://github.com/rollup/rollup). Updates `rollup` from 4.9.4 to 4.9.5 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v4.9.4...v4.9.5) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch dependency-group: rollup ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 8.0.1 to 8.0.2. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Changelog](https://github.com/npm/npm-packlist/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/npm-packlist/compare/v8.0.1...v8.0.2) --- updated-dependencies: - dependency-name: npm-packlist dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 6.18.0 to 6.18.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.18.0 to 6.18.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the babel group with 1 update: [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env). Updates `@babel/preset-env` from 7.23.7 to 7.23.8 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.8/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1531.0 to 2.1536.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1531.0...v2.1536.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@npmcli/arborist](https://github.com/npm/cli/tree/HEAD/workspaces/arborist) from 7.2.2 to 7.3.0. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/workspaces/arborist/CHANGELOG.md) - [Commits](https://github.com/npm/cli/commits/v7.3.0/workspaces/arborist) --- updated-dependencies: - dependency-name: "@npmcli/arborist" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-