1. 17 Mar, 2015 30 commits
  2. 14 Mar, 2015 3 commits
  3. 13 Mar, 2015 2 commits
    • Randall Leeds's avatar
      Merge pull request #2034 from hypothesis/2033-fix-focusing · 719f2284
      Randall Leeds authored
      Fix sidebar's focusing on annotation cards
      719f2284
    • csillag's avatar
      Fix sidebar's focusing on annotation cards · abe12c47
      csillag authored
      When the user moves the mouse over a highlight in the document,
      the corresponding annotation card (in the sidebar) is supposed
      to be highlighted, to indicate focus.
      
      Our mechanism for this was broken in 3 different ways:
      
      1. AnnotationUI service's focusAnnotations() method was working
         with annotation IDs. However, annotations being created
         right now don't yet have ID, only tags. So we should be working
         with tags instead. (Like we are, in many other cases
         when cross-frame communication communication is done
         around annotations.)
      
         I fixed that, and also updated the corresponding tests.
      
      2. In controllers.coffee, when we were trying to check if a given
         annotation has focus, we were using the tag value, while on
         the other hand, it was not the tag, but the id that was put
         into the map. Of course this didn't work.
      
         Since now we are consistently using the tag, no change
         was needed here.
      
      3. We are putting $$tag:true pairs into the map, but when
         checking for membership, the `in` operator was used.
         That works for lists, but not for maps. For maps, we simply
         have to read out the value belonging to the given key,
         and see if it's true.
      
      After fixing these problems, the feature works again.
      abe12c47
  4. 12 Mar, 2015 1 commit
  5. 11 Mar, 2015 4 commits