- 09 Jan, 2017 1 commit
-
-
Sean Roberts authored
Remove initial redirect when sidebar loads
-
- 05 Jan, 2017 3 commits
-
-
Robert Knight authored
Avoid redirecting to '/viewer' when the sidebar loads. This redirect is unnecessary since the sidebar never changes its mode once loaded and it caused the viewer embedded on a page to fail to load when restoring a closed tab in Chrome. This may also resolve issues where the user agent disallows the 'replaceState' call in certain situations (search prod-client reports on Sentry for "replaceState") Fixes #178
-
Robert Knight authored
-
Robert Knight authored
-
- 23 Dec, 2016 4 commits
-
-
Robert Knight authored
Update tag service urls
-
Sean Roberts authored
Show annotations in Annotations tab but with quote struck through after anchoring timeout
-
chdorner authored
Since we're not linking to the stream anymore.
-
chdorner authored
-
- 22 Dec, 2016 1 commit
-
-
Robert Knight authored
Instead of marking annotations as orphans after the anchoring timeout expires, instead display them in the Annotations tab but with a visual indicator that they have not yet anchored. This avoids showing annotations that are still anchoring in the Orphans tab, which can be confusing when it happens in long PDF documents with many annotations. * Add an `$anchorTimeout` flag to annotations that is set if annotations fail to anchor within the timeout period. * Display annotations with this flag set in the Annotations tab, on the optimistic basis that they will eventually anchor. * When rendering annotations with this flag set, display them with a quote struck through (same as orphans) to indicate that they are pending. The visual representation of the pending state may be tweaked in future.
-
- 21 Dec, 2016 2 commits
-
-
Sean Roberts authored
Consolidate logic for annotation <-> tab assignment
-
Sean Roberts authored
Move the list of connected frames to the Redux store
-
- 20 Dec, 2016 1 commit
-
-
Robert Knight authored
Use a custom element name for highlight spans
-
- 19 Dec, 2016 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
Previously the logic for determining which tab an annotation should appear in occurred both in `root-thread.js` where it was used to filter annotations based on the selected tab, and in `widget-controller.js` where it was used to switch to the tab containing a particular annotation. Consolidate all the logic for deciding which tab an annotation should appear in into a single module. This makes it easier to test that tab assignment is correct with different combinations of feature flags and annotation states and to add additional logic in future.
-
Robert Knight authored
Move metadata about the frames that are connected to the sidebar app, such as the document's URL and fingerprint, to the central app state store. This is part of an effort to unify how important application state is managed.
-
- 16 Dec, 2016 2 commits
-
-
Robert Knight authored
Add HTML baseline tests
-
Robert Knight authored
Add a set of baseline tests for HTML anchoring which attempt to anchor a set of selectors for an annotation using data in the format returned by the Hypothesis API and then verify that the same selectors are generated when re-describing the anchored ranges.
-
- 30 Nov, 2016 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Remove 'defer_realtime_updates' feature flagging
-
- 28 Nov, 2016 2 commits
-
-
Nick Stenning authored
This is now enabled by for everyone, so we don't need the feature flag any more.
-
Robert Knight authored
When anchoring many annotations on a PDF, the text of the same page may be requested many times. The text is initially fetched via an async call to PDFViewerApplication.pdfViewer.getPageTextContent() and the result is then cached for future use. Previously the cache was only updated once this expensive call returned a result. Consequently when anchoring many annotations at once, there would be a lot of unnecessary cache misses and repeated calls to PDFViewerApplication.pdfViewer.getPageTextContent() Fix the problem by storing a promise for the result in the cache when the text for a given page is requested the first time. Consequently the text for each page will only be fetched once.
-
- 27 Nov, 2016 1 commit
-
-
Robert Knight authored
Use the same trick that was applied to the adder in d9644a80 to reduce the likelihood of the page's own CSS styling modifying the appearance of highlights. Compared to alternative methods which would raise the precedence of highlight styling (inline styles, !important !all !the !things, selector precedence hacks), this approach is simpler as it makes the conflicting rule from the page's own styling not apply at all. Fixes hypothesis/h#3520
-
- 18 Nov, 2016 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
- 17 Nov, 2016 1 commit
-
-
Robert Knight authored
Added links to help center from help panel
-
- 16 Nov, 2016 1 commit
-
-
Sean Roberts authored
-
- 15 Nov, 2016 1 commit
-
-
Christof Dorner authored
Fix Jenkins builds failing if package.json or shrinkwrap change after branch is initially pushed
-
- 08 Nov, 2016 2 commits
-
-
Robert Knight authored
This fixes a couple of incorrect usages of Sinon assertions which resulted in test failures with the latest patch version of Sinon. * assert.calledOnce() only takes one argument * Sinon assertions do not take a message argument as Chai assertions do. See http://sinonjs.org/docs/#assertions
-
Robert Knight authored
* Move event handlers out of AnnotationUISync As a step towards having all bridge event handlers in one place, move these event handlers into frameSync. * Add tests for findIDsForTags() and for re-exporting of this function from annotationUI * Move sidebarOpened event handler to FrameSync service * Remove the AnnotationUISync service Its functionality has now been moved into the FrameSync service, except for the logic that was intended to synchronize the "Show Annotation Highlights" logic across multiple frames, since this is clearly broken [1]. The two pieces of functionality related to this we need to support at the moment are: 1. The `showHighlights` config option to set whether highlights are initially visible. 2. The highlight toggle button in the sidebar's outer frame Both of these work without the sidebar app's involvement. [1] See https://github.com/hypothesis/h/issues/3433 and https://github.com/hypothesis/h/pull/3295
-
- 04 Nov, 2016 4 commits
-
-
Robert Knight authored
Jenkins is currently configured to re-use workspaces between builds of the same branch. Run `make clean` at the start of the build to ensure that any artefacts from the previous build of the branch are removed.
-
Robert Knight authored
With the following steps, the second invocation of `make` should trigger installation of npm dependencies: 1. Run `make` 2. Edit dependencies in `package.json` 3. Run `make` again
-
Robert Knight authored
The shrinkwrap was not updated when `requests` was updated from v2.71.0 to v2.72.0.
-
Lena Gunn authored
-
- 28 Oct, 2016 2 commits
-
-
Sean Roberts authored
Fix normalization of ranges that start at an element node with no children
-
Robert Knight authored
This isn't needed since we're not translating error messages.
-
- 25 Oct, 2016 4 commits
-
-
Robert Knight authored
Rename the `$$tag` annotation property to `$tag`.
-
Robert Knight authored
The range normalization code failed to take account of ranges where the start container was an empty element with no children. Fixes #73
-
Robert Knight authored
Replace the Range functions from the compiled version of Annotator 1.2.x with the latest CoffeeScript source from the v1.2.x branch of Annotator, plus the fix added in b3056d27 This includes fixes for BrowserRange#normalize from https://github.com/openannotation/annotator/commit/9bec776511a717ef944b36ed7cca3d107bd95c88 In addition, this removes the dependency on the Annotator framework from annotator/anchoring and the highlighter, getting us closer to a point where we can remove the dependency of the annotation layer on Annotator. Fixes #109
-
Sean Roberts authored
Adding code coverage reporting to Karma tests
-