Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 14 Dec, 2020 1 commit
    • Eduardo Sanz García's avatar
      Do not select/focus the input element on iOS · 6c1a8996
      Eduardo Sanz García authored 
      The text in the input element of the `annotation-share-control` is
selected and focused when the element is created. This is to
facilitate copy/paste via keyboard shorcuts. This selection/focus mechanism is working well except for iOS (both Chrome and Safari) where:

* the selection/focus is not shown in the input field except by clicking on the input element.

* the selection overflows the right margin of the input field

I tested `overflow: hidden` on the input element but that causes the selection to overflow on the left margin

Because of these two issues, I recommend to supress selection/focus on iOS devices.
      6c1a8996
  3. 11 Dec, 2020 9 commits
  5. 10 Dec, 2020 2 commits
  7. 09 Dec, 2020 12 commits
    • Robert Knight's avatar
      Improve several variable names and comments · 5bcdd787
      Robert Knight authored 
      Make several improvements following PR review.
      5bcdd787
    • Robert Knight's avatar
      Implement `useStoreProxy` hook · 8108f0fc
      Robert Knight authored 
      Implement a new `useStoreProxy` hook that provides access to read and
update the store in UI components. This will replace the existing
`useStore` hook.

The new hook has a more ergonomic API which should also prevent some of the
common mistakes made when using the previous hook.

`useStoreProxy` returns an ES proxy for the store. The UI component can
use the proxy as if it were using the store directly. The proxy however
tracks and caches the results of store selector calls. When the store
state changes the proxy checks whether any of the cached calls would
return different results and if so invalidates the cache and re-renders
the component.
      8108f0fc
    • Robert Knight's avatar
      Avoid traversing object tree in `immutable` if already frozen · bcabf15f
      Robert Knight authored 
      This makes store updates faster in debug builds when a lot of data is
loaded into the client. In this case most sub-trees in the store are
already frozen after an update (since they are objects from the previous
state) and only the new parts need to be frozen.
      bcabf15f
    • Robert Knight's avatar
      Replace remaining uses of `store.getState()` in UI components · 36e03af8
      Robert Knight authored 
      Replace remaining uses of `store.getState()` in UI components with
selectors. This will avoid unnecessary re-rendering after we change
components to use the new `useStoreProxy` hook for reading from the
store. It also simplifies the tests.
      36e03af8
    • Robert Knight's avatar
      Remove unnecessary `requestAnimationFrame` callbacks in `Guest` · 2a4045de
      Robert Knight authored 
      Profiling anchoring of large numbers of annotations in Chrome showed
that there was significant overhead for scheduling and
executing `requestAnimationFrame` callbacks. In the case of `Guest.anchor`, the
callback often did nothing (it called `removeHighlights` with an empty
array).

There isn't a need for this any more AFAICS so just invoke the logic
synchronously, which is much cheaper.
      2a4045de
    • Robert Knight's avatar
      Optimize `sortKeys` selector · 817d82f4
      Robert Knight authored 
      This was recomputing frequently even though the result only changes when
the selected tab changes.
      817d82f4
    • Lyza Danger Gardner's avatar
      Refactor `useRootThread` to memoize correctly · 945825da
      Lyza Danger Gardner authored 
      Also convert `selectionState` to use `createSelector` to avoid it
returning a different reference on each call.
      945825da
    • Lyza Danger Gardner's avatar
      Remove unused selector · 04a98682
      Lyza Danger Gardner authored 
      Remove unused selector and tidy up reference ordering
      04a98682
    • Lyza Danger Gardner's avatar
      Refactor `hasAppliedFilter` · 9fb70f45
      Lyza Danger Gardner authored 
      Refactor selectors for evaluating `hasAppliedFilter`
to remove cross-module state dependencies.
      9fb70f45
    • Lyza Danger Gardner's avatar
      Remove `threadState`, add supporting selectors · 6c2fe0f4
      Lyza Danger Gardner authored 
      Eliminate the enormous `threadState` `rootSelector`
and re-implement as multiple selectors. Refactor
`useRootThread` and threading integration tests
to account for these changes.
      6c2fe0f4
    • Lyza Danger Gardner's avatar
      Remove `filterState`; add `focusState` · 8999cc4b
      Lyza Danger Gardner authored 
      Refactor the computation of "filter state", that
is, all of the store state that impacts what
constitutes applied filters on annotations.
      8999cc4b
    • Lyza Danger Gardner's avatar
      Split `selection` store into `selection`, `filters` · e9b81457
      Lyza Danger Gardner authored 
      The `selection` store module has become overlong and
its responsibilities aren't clear. We know we'll be
adding some more filtering capabilities to the app
in the next short while, and that would make
`selection` even more complex and heavy.

Split into two store modules: `selection` and
`filters`.

Temporarily re-implement `rootSelector`s that
are needed for generating thread and filter
state for components.
      e9b81457
  9. 08 Dec, 2020 2 commits
    • Robert Knight's avatar
      Rename `dir` option to `direction` · 899a2831
      Robert Knight authored 
      The name `dir` is arguably ambiguous in this context.
      899a2831
    • Robert Knight's avatar
      Handle start or end element with no text in `TextRange.toRange` · 3d36ecee
      Robert Knight authored 
      When resolving a `TextRange` to a DOM `Range` there is an edge case
where the `start` or `end` position have an `offset` of `0` and the
element contains no text nodes.

Before this commit `toRange` would throw an `Offset exceeds text length`
error. A more useful behavior though is:

 - For the `start` position, to resolve it to the start of the next text node after
   `this.start.element`

 - For the `end` position, to resolve it to the end of the previous text
   node before `this.end.element`

This commit implements this behavior by first adding a `dir` option to
`TextPosition.resolve` to control what happens when the position's
offset is 0 and the element has no text and then specifying this option
when calling `this.{start, end}.resolve` in `TextRange.toRange`.
      3d36ecee
  11. 07 Dec, 2020 9 commits
  13. 04 Dec, 2020 1 commit
  15. 03 Dec, 2020 4 commits
    • Lyza Danger Gardner's avatar
      Correctly select Orphan tab when viewing direct-linked orphan · d7c316ea
      Lyza Danger Gardner authored 
      Previously, tab selection for direct-linked annotations was happening
before anchoring was complete—that means that orphaned annotations had
not yet been marked as being orphans (`$orphan`). Make sure that
direct-linked tab selection is checked any time the direct-linked
annotation changes.

Also fix a UI confusion in which the "Show All" button would show
the count of all annotations in this (direct-linked) state, which is
confusing because orphans don't count toward "All annotations" (nor do
page notes, FWIW).

Fixes #2686
      d7c316ea
    • Eduardo Sanz García's avatar
      Find annotation.css in a more robust way · 1ccf10d4
      Eduardo Sanz García authored 
      As indicated by @robertknight `document.styleSheets` is complete only when stylessheets are processed. This can take a while for certain heavy pages.

The alternative approach presented here to find `annotation.css` is warranted to find the url when the code is run.

Closes #2752
      1ccf10d4
    • Robert Knight's avatar
      Address minor PR feedback · 91f36486
      Robert Knight authored 
       - Add comment to explain purpose of `index.js`
 - Use a template string for readability
      91f36486
    • Robert Knight's avatar
      Remove obsolete `experimental.pdfSideBySide` config · f651eb3b
      Robert Knight authored 
      This feature is now enabled by default.
      f651eb3b