- 20 Apr, 2018 4 commits
-
-
Robert Knight authored
Fix group focus change checks
-
Robert Knight authored
The focused group change check had several issues: - The `prevFocused` variable was not updated after the focused group changed, so the `GROUP_FOCUSED` event was emitted every time the app state changed. - Groups were compared by reference rather than by ID, which means that a change which modified a property of the group but not its ID would cause the event to fire. The first issue made it impossible to create annotations because the unnecessary `GROUP_FOCUSED` event triggered a cascade of reactions which crashed the app.
-
Robert Knight authored
-
Robert Knight authored
-
- 19 Apr, 2018 5 commits
-
-
Robert Knight authored
Modernize PDFMetadata class
-
Robert Knight authored
-
Robert Knight authored
- Convert `PDFMetadata` to an ES2015 class - Convert the ad-hoc type documentation to tool-readable JSDoc - Add a little more detail in doc comments about what `documentFingerprint` is
-
Robert Knight authored
Move focused group and list of loaded groups to store
-
Robert Knight authored
As noted in CR feedback, having a selector named `focusedGroup` which returns a `Group` and a state property named `focusedGroup` is `string|null` is confusing. Also change a `g` variable to `group` for clarity.
-
- 18 Apr, 2018 1 commit
-
-
Lyza Gardner authored
Also bring `yarn.lock` into sync
-
- 17 Apr, 2018 5 commits
-
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
Remove outdated April fool joke.
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
Use group.links\.html instead of group\.url
-
- 16 Apr, 2018 3 commits
-
-
Sheetal Umesh Kumar authored
Remove used used scss block causing invalid css error after upgrading…
-
Sheetal Umesh Kumar authored
-
- 13 Apr, 2018 5 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Add organization logos to groups menu
-
Sean Hammond authored
Resolve relative URLs when getting PDF URL from PDF.js
-
Lyza Danger Gardner authored
-
- 12 Apr, 2018 3 commits
-
-
Lyza Gardner authored
-
Robert Knight authored
If PDF.js is launched with a `file` query-string parameter that is a relative URL, then `window.PDFViewerApplication.url` will be that relative URL. When capturing the metadata from the PDF in order to search for annotations or find relevant groups, we want to use an absolute URL. This commit uses the existing `normalizeURI` helper to resolve the possibly-relative URL. Fixes https://github.com/hypothesis/product-backlog/issues/579
-
Robert Knight authored
Extract the existing `normalizeURI` function from guest.coffee into a utility module and re-use it in document.coffee to convert relative URLs to absolute ones. Also implement some direct tests for this function.
-
- 10 Apr, 2018 2 commits
-
-
Robert Knight authored
Update the groups service to use the Redux store for storing and reading groups state instead of storing it internally in private variables.
-
Robert Knight authored
Add a Redux module that stores state related to groups, including the currently focused group and the list of all known groups. This is an initial step towards moving this state from the groups service into the store, which will make reacting to changes in the set of loaded groups, or the focused group, easier.
-
- 06 Apr, 2018 9 commits
-
-
Hannah Stepanek authored
Extract `createStore` helper out of `store` service
-
Sean Hammond authored
Replace "inherits" package with ES 2015 class inheritance
-
Sean Hammond authored
Convert Adder to an ES2015 class
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Remove the need to alias the `Adder` instance to `self` by using arrow-functions.
-
Robert Knight authored
This commit and the next few refactor `Adder` to a "proper" class for easier readability.
-
- 05 Apr, 2018 1 commit
-
-
Robert Knight authored
Add `expand` param to all groups.list requests
-
- 04 Apr, 2018 1 commit
-
-
Lyza Danger Gardner authored
-
- 29 Mar, 2018 1 commit
-
-
Robert Knight authored
-