- 22 Oct, 2018 1 commit
-
-
Sheetal Umesh Kumar authored
The `whatToShow`, `filter` and `expandEntityReferences` arguments for `Document.createNodeIterator()` are mandatory in IE although optional according to the spec. Pass default values to fix JS console errors. See: https://github.com/hypothesis/client/issues/762
-
- 19 Oct, 2018 4 commits
-
-
jenkins-hypothesis authored
-
Robert Knight authored
Move remaining client release steps to Jenkins
-
Robert Knight authored
-
Robert Knight authored
When performing a Jenkins CI build of the "master" branch, prompt the user to deploy and then after they approve, execute the same release process that a developer currently executes on their machine, namely: 1. Update the changelog 2. Run "yarn version" to update the package version, create a tag and GitHub release. After these steps the release process continues on Jenkins as before, with an npm package published and the build deployed to an S3-backed CDN using the s3-npm-publish tool. Enabling publishing the release entirely from Jenkins required some additional changes: - Use a Debian Stretch-based Node container, to get a newer Git version which supports "taggerdate", used by the changelog scripts. - Disable Git tag signing, since this is not set up on Jenkins. - Do not run "make test" from the preversion script, since this has already been run by Jenkins earlier in the process. Additionally to facilitate testing of this branch I added support for specifying a prerelease version suffix. This made it possible to test the whole deployment process without updating the live version of the client. In future this will likely come in useful for doing staging/QA releases.
-
- 18 Oct, 2018 1 commit
-
-
Robert Knight authored
Modify `update-changelog.js` to generate the list of changes itself
-
- 17 Oct, 2018 5 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Wrap "stage" contents in a block in Jenkinsfile
-
Robert Knight authored
This fixes a warning from Jenkins that using `stage` without specifying a block is deprecated.
-
Robert Knight authored
In preparation for executing the client release process entirely on Jenkins, make update-changelog.js automatically update CHANGELOG.md with a list of changes since the most recent tag, instead of requiring a developer to do this manually. This will lose the advantages of having a changelog written by humans, but we primarily use other channels nowadays to notify staff and users about Hypothesis product changes. - Add scripts/generate-change-list.js which generates a nicely formatted list of changes since the last release. - Use functions from generate-change-list.js to auto-populate section for new release in CHANGELOG.md when running `yarn version`.
-
- 09 Oct, 2018 7 commits
-
-
Robert Knight authored
Update API route definitions used by tests
-
Robert Knight authored
- Update the API index definitions used by the tests for the `api` service to be in sync with the actual index returned by https://hypothes.is/api/. - Move the definitions into a separate file to make them easier to update in future and add instructions on how to update them. - Fix two errors in the tests; use of "PUT" instead of "PATCH" for updating an annotation and an incorrect parameter name in the API call to remove a group member.
-
Robert Knight authored
Support serving the client over SSL in development
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Use custom name for global `require` function
-
Robert Knight authored
-
- 08 Oct, 2018 1 commit
-
-
Robert Knight authored
Following the conventions of the "h" project [1], the client's asset server (localhost:3001) and demo page server (localhost:3000) will be served over SSL if a certificate (".tlscert.pem") and private key (".tlskey.pem") are found in the root of the repository. This can be useful for testing the development client on pages served over SSL without having to disable mixed content warnings in the browser. [1] https://h.readthedocs.io/en/latest/developing/ssl/
-
- 29 Sep, 2018 1 commit
-
-
Robert Knight authored
Browserify bundles that make their modules available for other bundles to consume define a global `require` function. This is then imported by other bundles and used to resolve module lookups. This `require` name can clash with web pages that use eg. `RequireJS`. Most of the time this isn't a problem because all of the page's own code has run by the time Hypothesis loads. If however the page loads additional scripts after Hypothesis has been loaded, they will end up finding Hypothesis's `require` instead of their own. This commit resolves the issue by renaming the global `require` function to `hypothesisRequire` in two steps: - The `externalRequireName` Browserify option changes the _exported_ name. - A custom transform stream post-processes the Browserify bundle code to change the _imported_ name, since Browserify doesn't have an option for this itself. A small fix was needed to the `boot.js` script build to avoid stripping lines _after_ the sourcemap URL comment, instead of just that comment. Fixes #779
-
- 24 Sep, 2018 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
Fix leaving a group from the client
-
Robert Knight authored
https://github.com/hypothesis/h/commit/46e4bbadc991d550ca9706b5237e35d68675a6cc made a breaking change to the public API of the endpoint for removing the current user from a group by renaming the "user" path parameter to "userid". Given that this change has been out for some time, I have opted to fix the client rather than revert the change in the service. Fixes #774
-
- 18 Sep, 2018 3 commits
-
-
Dave Wolfe authored
-
Dave Wolfe authored
-
Robert Knight authored
Update core-js
-
- 17 Sep, 2018 1 commit
-
-
Dave Wolfe authored
Add aria label to share button in client menu
-
- 14 Sep, 2018 13 commits
-
-
Dave Wolfe authored
In addition to adding the label, this changes the <a> to a <button> as well. Fixes https://github.com/hypothesis/product-backlog/issues/780
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fetch config via postMessage RPC if `requestConfigFromFrame` is set
-
Robert Knight authored
This causes the client to fetch settings from an ancestor frame on startup if necessary.
-
Robert Knight authored
Implement `fetchConfig` function which fetches config from the host page / embedding web app and merges it with config rendered into the sidebar HTML page. This function supports a new method of fetching config from the embedder by performing a "requestSidebarConfig" RPC call to the origin set with the "requestSidebarConfigFromFrameWithOrigin" setting. That setting must itself by set in the page where the embed.js script is loaded. Also extract the `assertPromiseIsRejected` helper into `promise-util.js` for re-use and add a note about needing to return the result.
-
Robert Knight authored
Read sidebar app config asynchronously on startup
-
Robert Knight authored
Add client for making JSON-RPC calls over postMessage
-
Robert Knight authored
In preparation for introducing an optional new postMessage-based method for the sidebar app to fetch configuration from its embedder, make the setting fetch flow async. - Move the Angular app startup logic into a function which receives settings as an argument. - Add a function to merge config rendered into the sidebar app HTML page with config fetched asynchronously from a host frame.
-
Robert Knight authored
Add "requestConfigFromFrame" string setting
-
Robert Knight authored
Without this field all the test cases still pass, but for the wrong reason, since the origin field is checked before other event properties.
-
Robert Knight authored
Replace "var" with "const" or "let" everywhere
-
Robert Knight authored
-