- 06 Jul, 2021 11 commits
-
-
Robert Knight authored
Given the way the `Socket` helper currently works, the `connect` helper cannot be called while there is already a connection. `connect` is called once during the initial `Socket` constructor and subsequently to initiate an automatic reconnect in the event of an abnormal disconnection. In both cases there is no existing connection.
-
Robert Knight authored
Document the type and purpose of `operation` variable and fix a hazard where it was assigned a timeout ID instead of a `RetryOperation`, which would cause code expecting it to be a `RetryOperation` to fail.
-
Robert Knight authored
- Add tests for "message" and "error" events when the corresponding events are received on the underlying `WebSocket` - Add tests for eventual abort of reconnections
-
Robert Knight authored
Modernize our auto-reconnecting wrapper for `WebSocket` to match current conventions in the client and improve the documentation. - Use named rather than default exports - Convert functions to arrow functions and remove unneeded `self` alias. - Add JSDoc comments and types A circular reference between the `connect` and `onAbnormalClose` functions was broken by adding a second argument to `onAbnormalClose`.
-
dependabot[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.6.3 to 18.6.7. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.6.3...v18.6.7) --- updated-dependencies: - dependency-name: "@octokit/rest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.3.4 to 4.3.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v4.3.4...v4.3.5) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.15.1 to 3.15.2. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.15.2/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.936.0 to 2.939.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.936.0...v2.939.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 10.0.0 to 10.1.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v10.0.0...v10.1.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 9.0.1 to 9.0.2. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v9.0.1...v9.0.2) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.29.0 to 7.30.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.29.0...v7.30.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 05 Jul, 2021 1 commit
-
-
dependabot[bot] authored
Bumps [terser](https://github.com/terser/terser) from 5.7.0 to 5.7.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/compare/v5.7.0...v5.7.1) --- updated-dependencies: - dependency-name: terser dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 02 Jul, 2021 2 commits
-
-
Eduardo Sanz García authored
On Firefox, I have noticed that the notebook close button is briefly displayed and then hidden. This delay is probably caused by time that it takes to parse the CSS until it is applied. To avoid this 'blink' we render the component only when the `groupId` is set.
-
Eduardo Sanz García authored
Currently, because of the `notebook` and `sidebar` are not able to communicate directly it is not possible to place the close button on the `notebook` app itself. While waiting for the above to be fixed, I propose a few minor style changes: * Changed the `LabeledButton` to `IconButton` and only show the `X` (cancel icon). This is a widely understood and accepted pattern for modals * Increase the size of the cancel icon * Re-enable the cursor when hovering on the button (it seems that the `cursor: pointer` rule was not longer functional) * Made the margin bigger to avoid the browser scrolling bar to hidden by the button. These changes are meant to be a temporary improvement.
-
- 29 Jun, 2021 3 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.7.1 to 6.8.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.7.1...6.8.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 28 Jun, 2021 8 commits
-
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.931.0 to 2.936.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.931.0...v2.936.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [scroll-into-view](https://github.com/KoryNunn/scroll-into-view) from 1.15.0 to 1.16.0. - [Release notes](https://github.com/KoryNunn/scroll-into-view/releases) - [Commits](https://github.com/KoryNunn/scroll-into-view/commits) --- updated-dependencies: - dependency-name: scroll-into-view dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.5 to 7.14.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.1 to 2.3.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.3.1...2.3.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [commander](https://github.com/tj/commander.js) from 7.2.0 to 8.0.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/tj/commander.js/compare/v7.2.0...v8.0.0) --- updated-dependencies: - dependency-name: commander dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.15.0 to 3.15.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.15.1/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.6.0 to 18.6.3. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.6.0...v18.6.3) --- updated-dependencies: - dependency-name: "@octokit/rest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 4.2.2 to 4.2.3. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-core/compare/v4.2.2...v4.2.3) --- updated-dependencies: - dependency-name: axe-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 24 Jun, 2021 4 commits
-
-
Robert Knight authored
This could happen in the real application if text near the end of the document was annotated and an update to the document removes the text between the end of the annotated text and the end of the document. I also added a note about the preconditions for when the `search` function is guaranteed to return at least one match.
-
Mickaël Menu authored
-
Mickaël Menu authored
-
Mickaël Menu authored
-
- 23 Jun, 2021 3 commits
-
-
Kyle Keating authored
- defaultValue is now handled inside of getConfig so this code is unused. - hostPageSetting now returns undefined, rather than null, if a value is not found in the config. The undefined value will trigger the defaultValue to take effect in getConfig if a defaultValue is provided.
-
Kyle Keating authored
The default was incorrectly set to null because the previous code was setting it to null, however that null value was used to then set it a second time to "always" Part of this refactor is making the code more clear so this logic is explicit. The defaultValue for showHighlight is in fact 'always'
-
Kyle Keating authored
nb. This is now handled inside of getConfig()
-
- 22 Jun, 2021 2 commits
-
-
Kyle Keating authored
This change fixes the usage of redundant names being expressed in the configDefinitions map.
-
Kyle Keating authored
- Logic for `allowInBrowserExt` and `defaultValue` are moved up into getConfig() from various places inside settings. There are no external changes here, but there are a few subtle changes to how a config values work. 1. Previously if in a browser ext context and `allowInBrowserEx` was false (default), then the value was was changed to null. This bit of logic was not entirely explicit, but now the logic is that the value will be set to the `defaultValue` if provided or otherwise the value will be omitted entirely. Currently, all values have a `defaultValue` and most of the defaults are null. This ensures things work the same, but also helps bring clarity to what values will be transformed under this condition. Later we can revisit these config values and determine if any don't need a default or simply leave them as is. 2. The `defaultValue` was previously only used for several fields, but now its set for every field for clarity. It should also be noted that the `defaultValue` will now take precedent over the `coerce` method if settings returns an undefined value for that config key. This is in contrast to how it worked before, but was problematic under some possible circumstances. For example, if a settings value was not found or undefined, and a `defaultValue` was true and the coerce was `toBoolean`, then the value would become false rather than true and that is confusing because the default would not work due to the `coerce` taking precedent. This is now fixed. - Remove default export from is-browser-extension
-
- 21 Jun, 2021 6 commits
-
-
dependabot[bot] authored
Bumps [retry](https://github.com/tim-kos/node-retry) from 0.12.0 to 0.13.1. - [Release notes](https://github.com/tim-kos/node-retry/releases) - [Commits](https://github.com/tim-kos/node-retry/compare/v0.12.0...v0.13.1) --- updated-dependencies: - dependency-name: retry dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Kyle Keating authored
- Add a new parameter to urlFromLinkTag called "type" to allow urlFromLinkTag to get the client url as well as sidebar and notebook urls. This eliminates the need to have a custom clientUrl method in settings.js - urlFromLinkTag() will also soon be needed outside of settings.js as part of a future refactor to move logic into getConfig() which determines if the browser extension context is true. - Remove the deprecated "coerce" option from hostPageSetting as this is now moved to configDefinitions
-
Kyle Keating authored
Previously, coerce was passed to the hostPageSetting. Moving the logic up into getConfig allows any setting to have a coerce method, not just settings pulled from hostPageSetting. Eventually, other settings may need coerce logic such as showHighlights.
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.927.0 to 2.931.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.927.0...v2.931.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.14.0 to 3.15.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.15.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.7.0 to 6.7.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.7.0...6.7.1) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-