- 26 Mar, 2018 2 commits
-
-
Robert Knight authored
The `store` factory function contains some useful logic for composing a store out of a set of _modules_ which handle different parts of the application state, exposing the actions and selectors from each module as methods on the store. To facilitate re-use of this logic in tests and to make it easier to test this logic directly, extract it out of the `store` function into a separate `createStore` helper. Doing this enables removal of `modules/index.js` which existed to combine parts of the modules together.
-
Sean Hammond authored
Rename "annotationUI" => "store"
-
- 22 Mar, 2018 11 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
-
Robert Knight authored
Rename the fake/stub implementations of the Redux store used in various component and service tests.
-
Robert Knight authored
Update the name of the identifier used for the Redux store in various contexts, following the previous refactoring to move store-related code into `store/`.
-
Robert Knight authored
Move Redux modules and entry point to `store/` directory
-
Robert Knight authored
Changed background to selected element in PDF.js to visualize the searched content
-
Robert Knight authored
Remove reference to `group.url`
-
Robert Knight authored
Remove `group.public` property from annotation component
-
Robert Knight authored
Update icon for restricted groups in publish-annotation-button
-
- 21 Mar, 2018 7 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
Move away from `public` property in application components
-
Haritz Medina authored
-
Robert Knight authored
Keep the structure of having modules at higher layers (ie. with more transitive dependencies) in the app nearer the top of the list by moving the store registration to the bottom.
-
- 20 Mar, 2018 8 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
-
Robert Knight authored
Following the plan outlined in #687, restructure the Redux store as follows: - Move the entry point from `services/annotation-ui.js` to `store/index.js` - Move the modules which define bundles of reducers, action creators and selectors to `store/modules/{module-name}.js` - Move related utility code to `store/{module-name}.js`
-
Robert Knight authored
Move sidebar services to src/sidebar/services/
-
Robert Knight authored
Following the plan outlined in #687, move services into a `services/` directory. The definition of "services" in that plan (a possibly stateful module that handles interaction with an external party) is slightly more narrow than what constitutes an Angular service (a stateful singleton that has dependencies on injectable services/values). However as a first approximation most Angular services are services as defined in #687, so I've simply moved them all to the `services/` directory.
-
Robert Knight authored
Rename src/sidebar/{store => services/api}
-
- 19 Mar, 2018 1 commit
-
-
Robert Knight authored
Give the service which provides a client for the Hypothesis API a more obvious name and place it in a `services/` dir in accordance with the plan outlined in #687. The previous name of "store" was particularly confusing because of the existence of another kind of unrelated store (the Redux one) in the application. The service was previously registered with the `factory` method but has the same structure as all the other services which are registered with `service`, so I changed that for consistency.
-
- 16 Mar, 2018 2 commits
-
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
- 12 Mar, 2018 2 commits
-
-
Robert Knight authored
Show the world icon only for open groups in the groups dropdown.
-
Robert Knight authored
ADR: Sidebar application architecture
-
- 08 Mar, 2018 5 commits
-
-
Sheetal Umesh Kumar authored
private group icon otherwise. Fixes https://github.com/hypothesis/product-backlog/issues/513
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Default to notes tab when only notes present
-
Robert Knight authored
`selectedTab` is set to "note" rather than "page" if only page notes are present.
-
- 07 Mar, 2018 2 commits
-
-
Hannah Stepanek authored
This adds two tests that verify the annotations tab is selected when there are annotations present and the page notes tab is selected when only page notes are present.
-
Hannah Stepanek authored
Change the default tab to focus on page notes when there are no annotations and only page notes in a group. This way it directs the user where they need to go. Less clicking == yay! If there are no annotations at all, the annotations tab should be selected.
-