- 19 Oct, 2016 1 commit
-
-
Robert Knight authored
This function expects an ID, not an Annotation
-
- 17 Oct, 2016 3 commits
-
-
Sean Roberts authored
Add a set of HTML anchoring tests with expected failures
-
Sean Roberts authored
Fix formatting changes made via toolbar buttons not persisting
-
Sean Hammond authored
Add application state debugging utility
-
- 14 Oct, 2016 2 commits
-
-
Robert Knight authored
Add a set of tests which check that Ranges within a DOM tree are correctly 'described' as selectors and then successfully converted back to Range objects by anchoring. The tests are derived from the suite of test cases collected for the Annotator project at https://github.com/openannotation/annotator/blob/v1.2.x/test/spec/range_spec.coffee These tests found failures in describing ranges with position and quote selectors in many cases and with a range selector in one case. The test lists and checks these expected failures.
-
Robert Knight authored
When making formatting changes to the text of an annotation with the toolbar button without subsequently making a manual edit before clicking Preview or Save, the onEditText() callback was never triggered and so the unsaved changes were reverted when exiting edit mode. This happened because onEditText() was only fired in response to the 'input' event which only occurs in response to programmatic, not manual changes to the input's value. Fixes #147
-
- 13 Oct, 2016 1 commit
-
-
Robert Knight authored
This adds a debug utility which prints the application state before and after each action to the console when `window.debug` is set to a truthy value.
-
- 12 Oct, 2016 1 commit
-
-
Sean Roberts authored
Move session state to the Redux store
-
- 29 Sep, 2016 6 commits
-
-
Sean Roberts authored
-
Sean Roberts authored
-
Robert Knight authored
Fix prevent default override
-
Sean Roberts authored
-
Sean Roberts authored
-
Robert Knight authored
In current versions of PDF.js, the `RenderingStates` enum is no longer exported as a global, and the export method appears to be dependent on the build configuration. Since `RenderingStates` is a trivial enum, this commit fixes the problem by just reproducing it in `pdfjs-rendering-states.js`.
-
- 28 Sep, 2016 6 commits
-
-
Robert Knight authored
Use Node v6.2 on Travis
-
Nick Stenning authored
-
Sean Roberts authored
-
Sean Roberts authored
-
Nick Stenning authored
This keeps things consistent with the version of Node used by h: https://github.com/hypothesis/h/commit/cc71f6c571829344e1f50a05b33504a2d42725d4
-
Robert Knight authored
This fixes an error when trying to load the Hypothesis client on the stream or standalone annotation pages, caused by both the stream app and the sidebar app trying to set up a 'Discovery' server for annotation 'guests' to connect to. With this change, only the sidebar app will set up a Discovery server and hence it is now possible to annotate the stream and standalone annotation pages.
-
- 27 Sep, 2016 1 commit
-
-
Robert Knight authored
Upgrade raven node package
-
- 26 Sep, 2016 6 commits
-
-
Sean Roberts authored
-
Sean Roberts authored
Fix scrolling to direct-linked annotations
-
Robert Knight authored
Fix adder from affecting website's height on load
-
Robert Knight authored
The FrameSync service introduced in 55093ebb emitted an ANNOTATIONS_SYNCED event which unintentionally had a different type for the `tags` argument than the previous code (`string[]`, instead of `Array<{tag:string}>`) This commit updates the code in WidgetController to expect `tags` to be of type `string[]`. Fixes #129
-
Sean Roberts authored
-
Robert Knight authored
Move the session state out of the "session" service and into the Redux store. This enables logic in reducers and action creators to access the logged-in user, list of groups and active feature flags.
-
- 21 Sep, 2016 4 commits
-
-
Sean Hammond authored
Remove crossframe service and simplify communication with connected frames
-
Robert Knight authored
-
Robert Knight authored
Now that AnnotationSync is no longer used in the sidebar app, we can remove all of the handlers for events and messages arriving through the channel which are not needed by the page itself.
-
Robert Knight authored
Previously the communication between the sidebar and host frame was implemented by a shared AnnotationSync class, with a 'crossframe' service which abstracted the event bus on each side. This design however assumed that both sides wanted to listen to the same messages and react to them in similar ways. This is not the case, especially given the change to use Redux for state management in the sidebar app. This commit replaces the crossframe service and AnnotationSync class with a new 'frameSync' service which implements only the event listeners and sidebar -> page RPC calls that are actually needed. As a result, local annotation tags for annotations loaded via the API can now be assigned by the reducer in the Redux store, making this easier to test and getting us another step closer to making Annotation objects immutable in the sidebar app.
-
- 20 Sep, 2016 1 commit
-
-
Robert Knight authored
Yesterday a brief issue occurred where the server reported an incorrect (too high) total number of results for a URL due to the search index being out of date. Once the client reached the end of the actually available results, it made queries to the search endpoint which returned an empty result set but had a `total` figure implying that there should be more pages. The client then ended up polling the server indefinitely for more results. This commit defensively makes the client stop fetching more result pages if the current page is empty.
-
- 19 Sep, 2016 8 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
When calculating the count of pending updates that is used to determine whether to show the 'Apply Updates' icon or not, count deletions. In addition to changing the count calculation itself, this also requires that pending deletions are discarded for annotations that are not currently loaded. Such notifications may be received because the deletion may have happened in an un-focused group. Unlike create/update notifications, no group information is included in the notification itself so we look up the ID in the local store.
-
Nick Stenning authored
Update icon for applying updates to the current page
-
Robert Knight authored
As per discussion at https://hypothes-is.slack.com/archives/frontend/p1474276933000039, adjust the wording of the 'Apply Update' icon tooltip to avoid "update" being misinterpreted as referring to a software update.
-
Robert Knight authored
-
Robert Knight authored
Update icon to match current design from https://trello.com/c/tRZ2H7iH and remove the update count, as per the most recent comments on the Trello card.
-
Robert Knight authored
The deferred update UI was added primarily to avoid the problem of annotation updates being distracting while a user is composing annotations in the sidebar. This is less relevant on the stream. Additionally fix a bug where updates from unfocused groups were not shown on the stream, since the stream shows updates from all groups.
-