- 04 Sep, 2023 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
- 01 Sep, 2023 4 commits
-
-
Robert Knight authored
The `/* istanbul ignore next */` comment was not working as expected. Just writing the test was the easiest solution.
-
Robert Knight authored
This truncation is unicode-aware. There are other places in the app where do truncation that are not. These could reuse the `truncate` utility to fix this in future.
-
Robert Knight authored
- Add the document title to the suggested filename for exports, to make it unique across different documents by default. - Move `export-annotations.ts` to the `helpers/` directory, since it contains functions that are very much application-specific. The `util/` directory contains code which is potentially usable in other applications or libraries / is less domain specific. - Add a note about how filenames that are invalid on the user's system are handled Part of https://github.com/hypothesis/client/issues/5709
-
Alejandro Celaya authored
-
- 31 Aug, 2023 2 commits
-
-
Alejandro Celaya authored
-
Robert Knight authored
Since we capture these errors and present a toast to the user, they won't get sent via the usual unhandled exception mechanisms, so forward them explicitly to Sentry. Part of https://github.com/hypothesis/client/issues/5741
-
- 30 Aug, 2023 6 commits
-
-
Alejandro Celaya authored
-
Robert Knight authored
This will make triaging any user reports of issues easier. It would look better if we could present the details in a separate dialog, but this is a starting point. Also disable auto-dismiss for non-success statuses so the user is less likely to miss them. Part of https://github.com/hypothesis/client/issues/5741
-
Robert Knight authored
Fixes https://github.com/hypothesis/client/issues/5774
-
Robert Knight authored
-
Robert Knight authored
Fixes https://github.com/hypothesis/client/issues/5757
-
Robert Knight authored
Prevent the user from importing annotations until we have: - A group to import into - A set of existing annotations to match against - Document metadata to use for the new annotations I considered replacing the whole dialog with a `LoadingSpinner` until these conditions are met, like the Export dialog does, but it makes for a less jumpy transition when eg. switching groups if we just disable the button.
-
- 29 Aug, 2023 1 commit
-
-
Alejandro Celaya authored
-
- 28 Aug, 2023 10 commits
-
-
dependabot[bot] authored
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.2.1 to 6.4.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.4.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 7.0.4 to 8.0.0. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Changelog](https://github.com/npm/npm-packlist/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/npm-packlist/compare/v7.0.4...v8.0.0) --- updated-dependencies: - dependency-name: npm-packlist dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.1.6 to 5.2.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v5.1.6...v5.2.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 8.47.0 to 8.48.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.47.0...v8.48.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [chai](https://github.com/chaijs/chai) from 4.3.7 to 4.3.8. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/4.x.x/History.md) - [Commits](https://github.com/chaijs/chai/compare/v4.3.7...v4.3.8) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1440.0 to 2.1445.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1440.0...v2.1445.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.4.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@types/scroll-into-view](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/scroll-into-view) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/scroll-into-view) --- updated-dependencies: - dependency-name: "@types/scroll-into-view" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) from 15.2.0 to 15.2.1. - [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/node-resolve-v15.2.1/packages/node-resolve) --- updated-dependencies: - dependency-name: "@rollup/plugin-node-resolve" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.10 to 7.22.11. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.11/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 25 Aug, 2023 3 commits
-
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Robert Knight authored
Record the fact that imported annotations were created via the client's import mechanism, and the original ID of the annotation. This is currently stored in the `extra` field. h supports setting arbitrary fields at the top level of annotations, so we could have put the data there instead. However using the `extra` field for custom fields is a convention already used by some API clients, and is distinct from a standard/validated field if we add one later on. Fixes https://github.com/hypothesis/client/issues/5738
-
- 24 Aug, 2023 3 commits
-
-
Robert Knight authored
Speed up large imports by allowing up to 5 imports to be in-flight concurrently. The simplest approach to this would be to divide the annotations into batches and save one at a time. However due to the variability in the time that an individual import can take, this can lead to sub-optimal concurrency. Instead structure the code so that we try to always keep `MAX_CONCURRENT_IMPORTS` imports in flight at once, as long as there are that many remaining. Fixes https://github.com/hypothesis/client/issues/5739
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
- 23 Aug, 2023 8 commits
-
-
Robert Knight authored
This ensures that the count of annotations displayed in the Export tab matches the count of top-level annotations that we show in the user list, and actually import, in the Import tab. When reporting unsaved annotations, use the term "draft" which covers both annotations and replies. Part of https://github.com/hypothesis/client/issues/5742
-
Robert Knight authored
Simplify test to just check the essential `<details>`-related behavior compared to other tests.
-
Yisu Kim authored
-
Yisu Kim authored
-
Yisu Kim authored
-
Yisu Kim authored
-
Yisu Kim authored
-
Robert Knight authored
In the initial implementation of import, we have decided to exclude replies to simplify the feature. In other words, the import feature only supports importing top level annotations from a single user.
-