1. 31 Mar, 2015 1 commit
    • Sean Hammond's avatar
      Use domain as citation title if no document · bf0a27c9
      Sean Hammond authored
      An annotation's document.title is used as the citation when displaying
      an annotation. If this is an older annotation that has no document, fall
      back to using the domain as the citation title instead.
      
      Fixes #1542
      bf0a27c9
  2. 30 Mar, 2015 5 commits
  3. 27 Mar, 2015 9 commits
    • Randall Leeds's avatar
      Merge pull request #2080 from hypothesis/1612-hide-orphans · 298ea35d
      Randall Leeds authored
      Hide orphan annotations in the sidebar
      298ea35d
    • csillag's avatar
      Fixed the tests broken by the rebase · 15607e16
      csillag authored
      15607e16
    • csillag's avatar
      Simplify calculating the orphan flag · 990f2767
      csillag authored
      990f2767
    • csillag's avatar
      Add test for calculating the orphan flag · 19c817e9
      csillag authored
      19c817e9
    • csillag's avatar
      Extend test framework to cover the monkey · 18efd090
      csillag authored
      18efd090
    • csillag's avatar
      Hide orphan annotations in the sidebar · e3c473c1
      csillag authored
      e3c473c1
    • Sean Hammond's avatar
      Handle internal server errors in the registration form · 83413b9e
      Sean Hammond authored
      This fixes #1755: no error is shown on the client side when an attempt
      to register an account receives a 500 Server Error response.
      
      The failure() method in AuthController gets called and tries to do
      {errors, reason} = response.data, but this raises a TypeError because
      response.data is undefined (because the response didn't have a valid
      JSON body), so the client crashes as well.
      
      The fix is to catch this exception on the client side, and show a
      generic error to the user.
      83413b9e
    • Nick Stenning's avatar
      Merge pull request #2092 from hypothesis/2026-module-isolate-env · 5b861c1f
      Nick Stenning authored
      Improve packaging, bundling and module boilerplate
      5b861c1f
    • Randall Leeds's avatar
      Improve packaging, bundling and module boilerplate · 992efe84
      Randall Leeds authored
      Prevent negative interactions with module systems present in injected
      pages and refactor browserify interactions with angular to increase
      CommonJS accessibility / legibility and isolate angular module system
      boilerplate.
      
      - Avoid issues due to mis-detected module environments
      
        - In the injection script, load only Annotator and jQuery in the
          global scope and then both removed with `noConflict()`. Both are
          loaded with browserify-shim, which prevents jQuery from registering
          itself against require.js, if present (fix #2026).
      
        - Be explicit about registration of common cross-frame components
          (fix #2090).
      
          - Lift angular glue into app.coffee. Individual components are
            exported as CommonJS modules.
      
          - Lift Annotator glue into bootstrap.js (renamed hypothesis.js).
      
      - Break up all modules that contained multiple services/directives/etc,
        such as the formHelpers and uiHelpers modules, as well as catch-all
        files like services.coffee and directives.coffee. For a summary of
        these movements see the bottom of this commit message.
      
      - Rename all services, dropping the -service suffix, to match their
        injected names. This is consistent with how directives are being
        treated, and controllers as well (controllers are registered and
        injected done with the "Controller" suffix).
      
      - Move Annotator subclasses into the annotator subdirectory. This
        change avoids having `Annotator.Host` clash with the `host`
        service and makes it easy to glob dependencies in assets.yaml to
        minimally rebuild either the app or the inject.
      
      ---
      
      Summary of structural reorganisation. Modules that have been trivially
      renamed (from "foo-service" to "foo") are not included in this list:
      
          controllers:AppController                   app-controller
          controllers:AnnotationUIController          annotation-ui-controller
          controllers:AnnotationViewerController      annotation-viewer-controller
          controllers:ViewerController                widget-controller
      
          directives:match                            directive/match
          directives:repeatAnim                       directive/repeat-anim
          directives:whenscrolled                     directive/whenscrolled
      
          directives/thread:pulse                     pulse
      
          filters:Converter                           filter/converter
          filters:momentFilter                        filter/moment
          filters:personaFilter                       filter/persona
          filters:urlEncodeFilter                     filter/urlencode
      
          guest                                       annotator/guest
          host                                        annotator/host
      
          helpers/form-helpers:createFormHelpers      form-respond
          helpers/form-helpers:formInput              directive/form-input
          helpers/form-helpers:formValidate           directive/form-validate
          helpers/string-helpers:createStringHelpers  unicode
          helpers/tag-helpers                         tags
          helpers/time-helpers                        time
          helpers/ui-helpers:tabbable                 directive/tabbable
          helpers/ui-helpers:tabReveal                directive/tab-reveal
      
          searchfilters:QueryParser                   query-parser
          searchfilters:SearchFilter                  search-filter
          searchfilters:StreamFilter                  stream-filter
      
          services:DraftProvider                      drafts
          services:ViewFilter                         view-filter
          services:renderFactory                      render
      
          session/session-service                     session
      
          streamsearch                                stream-controller
      992efe84
  4. 26 Mar, 2015 1 commit
    • Sean Hammond's avatar
      Handle internal server errors in the registration form · d7750027
      Sean Hammond authored
      This fixes #1755: no error is shown on the client side when an attempt
      to register an account receives a 500 Server Error response.
      
      The failure() method in AuthController gets called and tries to do
      {errors, reason} = response.data, but this raises a TypeError because
      response.data is undefined (because the response didn't have a valid
      JSON body), so the client crashes as well.
      
      The fix is to catch this exception on the client side, and show a
      generic error to the user.
      d7750027
  5. 25 Mar, 2015 2 commits
  6. 24 Mar, 2015 6 commits
  7. 23 Mar, 2015 16 commits