This makes it more obvious which part of the method the variables are
relevant for.

Test `isFirstLoad` once instead of in each branch. This makes it more
obvious that a group is only ever focused on first load.

This is a slightly subjective change, but I think it makes it a little
easier to follow if the reader can see that none of the variables
holding API results are re-assigned.

Following the elimination of Promise chains, the load() method
can be shortened by eliminating some variables.

Refactor groups service's `load` method

 - Capitalize "API" consistently
 - Remove a couple of comments that repeated the code below

Import fix for a warning caused by a "quietly" failing test.

As pointed out during code review, mixing the terms "selected" and
"direct-linked" to refer to direct-linked annotations and groups is
potentially confusing. Use the term direct-linked consistently.

Fix a silently failing test

The `HypothesisAppController#login()` method returns a Promise and calls
`fakeStore.clearGroups` asynchronously. This means we need to wait for
the result before checking the spy, and return the result in the test
case so Mocha knows when the test has finished.

Clarify what the method does and add some comments to explain to the
reader the high-level steps that it goes through.

The first block produced a result synchronously, so it could be combined
into the second block.

Rework the block that fetches the direct-linked annotation's group and
adds it to the featured groups list so that there is only one return
point at the end.

Remove unused babel-preset-env dependency

This has been superceded by @babel/preset-env

Fix direct linked private login flow

For easier debugging when tests fail, ensure that `it` cases that refer
to specific functions in a module are grouped under a `describe` block
labeled with the function's name.

Despite the name of the settings key where this value is read from
(`settings.annotations`), only a single annotation is currently
supported. See the `initialSelection` function in
`store/modules/selection.js`.

- Clear groups service state on login and logout.
- Handle case where focus group is null when watching the focused group
and userid for changes. This can happen when clearGroups is called since
it sets the focus group to null which triggers a call to the watch
function. There are two watch function that get triggered; one in
sidebar-content, the other in the group service.
- Clear direct-linked id states on clearSelection and when a new
focusedGroup is selected.

- Rename direct-linked-group store module to direct-linked so that it
may track the state of all direct-linked related items.
- Add directLinkedAnnotationsId and directLinkedGroupId to direct-linked
store module. This provides an official location to track/change the
state of the settings.annotations and settings.group rather than
modifying them directly.

Bump @octokit/rest from 16.25.2 to 16.25.4

Merge pull request #1118 from hypothesis/dependabot/npm_and_yarn/babel-plugin-mockable-imports-1.5.0

Bump babel-plugin-mockable-imports from 1.4.0 to 1.5.0

Bump katex from 0.10.1 to 0.10.2

Bump codecov from 3.3.0 to 3.4.0

Bump scroll-into-view from 1.9.6 to 1.9.7

Bump gulp from 4.0.1 to 4.0.2

Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.25.2 to 16.25.4.
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](https://github.com/octokit/rest.js/compare/v16.25.2...v16.25.4)
Signed-off-by: dependabot[bot] <support@dependabot.com>

Bumps [babel-plugin-mockable-imports](https://github.com/robertknight/babel-plugin-mockable-imports) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/robertknight/babel-plugin-mockable-imports/releases)
- [Changelog](https://github.com/robertknight/babel-plugin-mockable-imports/blob/master/CHANGELOG.md)
- [Commits](https://github.com/robertknight/babel-plugin-mockable-imports/compare/v1.4.0...v1.5.0)
Signed-off-by: dependabot[bot] <support@dependabot.com>

Bumps [katex](https://github.com/KaTeX/KaTeX) from 0.10.1 to 0.10.2.
- [Release notes](https://github.com/KaTeX/KaTeX/releases)
- [Changelog](https://github.com/KaTeX/KaTeX/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KaTeX/KaTeX/compare/v0.10.1...v0.10.2)
Signed-off-by: dependabot[bot] <support@dependabot.com>

Bumps [codecov](https://github.com/codecov/codecov-node) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Commits](https://github.com/codecov/codecov-node/compare/v3.3.0...v3.4.0)
Signed-off-by: dependabot[bot] <support@dependabot.com>

Bumps [scroll-into-view](https://github.com/KoryNunn/scroll-into-view) from 1.9.6 to 1.9.7.
- [Release notes](https://github.com/KoryNunn/scroll-into-view/releases)
- [Changelog](https://github.com/KoryNunn/scroll-into-view/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KoryNunn/scroll-into-view/commits)
Signed-off-by: dependabot[bot] <support@dependabot.com>

Bumps [gulp](https://github.com/gulpjs/gulp) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/gulpjs/gulp/releases)
- [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gulpjs/gulp/compare/v4.0.1...v4.0.2)
Signed-off-by: dependabot[bot] <support@dependabot.com>

Fix overlapping text in headings in annotation bodies

Parent elements of annotation cards set line heights to absolute pixel
values. Annotation card headings then inherit this and as a result,
their line height is too small for the font size.

We ought to reconsider the way line heights are set elsewhere in the
app, but resetting the line height in the `styled-text` mixin ensures
that annotation body styles are protected from whatever the parent
elements do with it.