Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 12 Nov, 2024 1 commit
  3. 11 Nov, 2024 9 commits
  5. 06 Nov, 2024 3 commits
    • Robert Knight's avatar
      Fix sidebar container initialization when "clean" theme is used · e15e597b
      Robert Knight authored 
      When the "clean" theme is used, the sidebar's toggle button is not created and
constructing the `DragHandler` failed because it was passed a `null` target.
Update the types in `ToolbarController.sidebarToggleButton` to reflect that the
value can be null and handle this in `Sidebar` by not initializing
`_dragResizeHandler` in this case.
      e15e597b
    • Robert Knight's avatar
      Update browser baseline for boot script · 39cf23df
      Robert Knight authored 
      The client's boot script supports older browsers than the rest of the client so
it can log a warning if it can't start in "somewhat" older browsers.

Update the boot script's supported officially browsers from ~2013 (IE 11) to
~2017 (Safari 11), although the code will probably still run in older browsers.
This allows dropping an async/await Babel plugin, although async is not actually
used in the current boot script.
      39cf23df
    • Robert Knight's avatar
      Replace hammer.js with local code · 1b5c4076
      Robert Knight authored 
      Hammer.js is used to facilitate resizing the sidebar by dragging the sidebar
button. For this use case, we can avoid a dependency which is not actively
maintained, get more visibility into what the code is doing and make testing
easier by using a small amount of our own code.

In the process the tests for drag resizing in the sidebar were refactored to
avoid referencing private fields of `Sidebar` and mocking `getComputedStyle`.

The user-facing behavior should be unchanged.
      1b5c4076
  7. 05 Nov, 2024 2 commits
  9. 04 Nov, 2024 9 commits
  11. 30 Oct, 2024 2 commits
    • Robert Knight's avatar
      Update `allowLeavingGroups` docs to match reality · 2522dc18
      Robert Knight authored 
      Update the documentation to match the current behavior. As noted in
https://github.com/hypothesis/client/pull/6638, the code comments and behavior
were inconsistent. Since changing the behavior is potentially disruptive, that
PR changed the comments instead. This commit updates the publisher-facing
documentation.
      2522dc18
    • Robert Knight's avatar
      Show "Leave group" option for open and restricted groups that user is a member of · d14c255b
      Robert Knight authored 
      Previously the "Leave group" option was only shown for private groups on the
basis that membership of open and restricted groups was managed by h admins.
However first-party Hypothesis users can now create open and restricted groups
themselves and members of these groups will see an option to leave the group on
activity pages. Align whether the client shows the "Leave group" option with h's
behavior.

During this change it was noticed that the documentation in the code and test
descriptions did not match the actual handling of `allowLeavingGroups`. The
comments said that services had to explicitly set `allowLeavingGroups` to
prevent users leaving. However the code would treat `allowLeavingGroups` as false
if a) service configuration was present and b) the value of `allowLeavingGroups`
was falsey (including undefined). Changing this behavior may cause issues for
existing users of third party authorities, so this commit updates the
documentation and tests to accurately describe the current behavior.

Fixes https://github.com/hypothesis/client/issues/6637
      d14c255b
  13. 28 Oct, 2024 11 commits
  15. 23 Oct, 2024 1 commit
  17. 22 Oct, 2024 2 commits