- 04 Jul, 2017 3 commits
-
-
Sean Hammond authored
Fix decoding of the query section in "#annotations" fragments.
-
Robert Knight authored
Fix view switcher flash on iOS
-
Robert Knight authored
Use `decodeURIComponent` instead of `decodeURI` because `decodeURIComponent` decodes reserved characters (eg. ":", "/") whereas `decodeURI` does not. Avoid stubbing decodeURIComponent() in the tests and instead just use a malformed escape sequence which triggers an actual URIError when decoding.
-
- 03 Jul, 2017 1 commit
-
-
Sean Hammond authored
The view switcher tabs at the top of the sidebar would flash grey for a moment after you clicked one. This removes the flash. This webkit "tap highlight" is actually an iOS Safari usability feature, it indicates to the user that their tap is being successfully recognized, and indicates which element they're tapping on. But I don't think it looks good with these tabs of ours, and it seems to interact badly with the background colour animated transition we're using (it seems to do the animated transition first and _then_ flash the tap highlight colour for a second). We're providing this indication by changing the colour of the tab anyway, so disable it.
-
- 30 Jun, 2017 2 commits
-
-
Sean Hammond authored
-
Sean Hammond authored
-
- 29 Jun, 2017 7 commits
-
-
Sean Roberts authored
Frame destruction
-
Sean Roberts authored
Set the visibleHighlights state for multiple Guests
-
Sean Hammond authored
Convert Unicode service & tests to JS
-
Sean Hammond authored
Replace selection tabs with view switcher (feature flagged)
-
Sean Hammond authored
-
Sean Hammond authored
If the 'view-switcher' feature flat is enabled then use the new view switcher component, otherwise uses the old selection tabs component. The view switcher component is just a placeholder for now.
-
Robert Knight authored
Also remove use of Angular mock/inject because it really isn't necessary for testing this service.
-
- 28 Jun, 2017 3 commits
-
-
Sean Hammond authored
Allow "oauthEnabled" setting to be overridden in client config
-
Robert Knight authored
-
Juan Corona authored
-
- 27 Jun, 2017 22 commits
-
-
Juan Corona authored
It makes more sense that this method is implemented in the Sidebar instead of Host
-
Juan Corona authored
-
Robert Hodan authored
-
Juan Corona authored
-
Robert Hodan authored
-
Juan Corona authored
-
Juan Corona authored
This means that sub-frames will get injected with the same set of whitelisted config values from the top level. It’s good that there’s a whitelisting of the config before reaching this point, so there’s less of a security concern with the injection This was done so I can have the sub-frame guests read the `config.showHighlights` option in order to set the initial highlight visibility at that level.
-
Juan Corona authored
I want to prevent the potential chaining of config params here since I plan to pass the config object around in new places, the sub-frame guest level for example.
-
Robert Knight authored
This will enable testing of 1st party OAuth in the client by creating a custom bookmarklet or test page which embeds the client.
-
Sean Roberts authored
Adding waitForFrameObserver in frame manipulation tests
-
Sean Roberts authored
-
Sean Roberts authored
Multiple frame detection improvements
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Improve tests for different localStorage-not-accessible situations
-
Robert Knight authored
Run all of the existing tests to check behavior when localStorage is not accessible, for the case where accessing `window.localStorage` throws. The previous tests for this situation only tested the behavior of the service constructor.
-
Robert Knight authored
Use fallback when local storage throws
-
Sean Roberts authored
Whitelist config settings needed by multi-frame support
-
Juan Corona authored
Better differentiation from .isLoaded
-
Juan Corona authored
The tests are in a response to an issue found when frames get added/removed in quick succession. It was due to the timing of the debounce used in FrameObserver. This also works to test against possible edge cases and ensures robustness of the feature by going full circle.
-
Juan Corona authored
Reduces the footprint of CrossFrame by shifting away responsibility into this new module.
-
Juan Corona authored
To my knowledge this is temporarily until a better flagging or set of options comes by
-
- 26 Jun, 2017 2 commits
-
-
Sean Roberts authored
Use CrossFrame to show/hide the Sidebar
-
Sean Roberts authored
-