1. 08 Nov, 2017 5 commits
    • Robert Knight's avatar
      Coalesce anchoring status updates · d0c1e748
      Robert Knight authored
      Profiling the test case in #556 showed significant overhead from the
      processing involved in or triggered by each `UPDATE_ANCHOR_STATUS`
      action handled by the store. Previously one `UPDATE_ANCHOR_STATUS`
      action was dispatched for each annotation whose anchoring status
      changed.
      
      Improve the situation by making the `UPDATE_ANCHOR_STATUS` action handle
      updates for multiple annotations at once and modifying the `frameSync`
      service to coalesce anchoring status updates from the host page into
      a smaller number of `UPDATE_ANCHOR_STATUS` actions.
      
      Fixes #556
      d0c1e748
    • Robert Knight's avatar
      Do not update tags in UPDATE_ANCHOR_STATUS action · 649b6e31
      Robert Knight authored
      Historically annotations did not have local tags until after they had
      been anchored in the page.
      
      This is no longer the case as annotations are assigned local tags as
      soon as they are added into the app state by ADD_ANNOTATIONS.
      
      Therefore, it is no longer necessary for the UPDATE_ANCHOR_STATUS action
      to support updating the tags of annotations or to support identifying
      the annotation which has been anchored by its ID instead of its tag.
      649b6e31
    • Sean Hammond's avatar
      Merge pull request #542 from hypothesis/remove-cookie-auth · 5a14c16b
      Sean Hammond authored
      Remove cookie auth related code
      5a14c16b
    • Robert Knight's avatar
      Update docstrings for `session` service · f4e91be4
      Robert Knight authored
      Update docstrings in response to CR feedback. In particular, document
      parameter and return types more clearly.
      f4e91be4
    • Robert Knight's avatar
      Remove remaining references to the "openLoginForm" setting · 2b0b7839
      Robert Knight authored
      This is now obsolete since login always happens in a popup window.
      2b0b7839
  2. 07 Nov, 2017 16 commits
  3. 06 Nov, 2017 3 commits
  4. 26 Oct, 2017 1 commit
    • Robert Knight's avatar
      Add missing page index bounds check · a2336a7c
      Robert Knight authored
      When anchoring an annotation with a position and a quote selector, if
      the position selector fails, then PDF anchoring searches page contents
      starting with those pages nearest the position.
      
      If the position selector's `start` offset was greater than the length of
      the PDF's text, `prioritizePages` would try to fetch the text of page
      indexes beyond the valid range, causing PDF.js to throw an exception and
      quote anchoring to fail.
      
      Fix this by adding a missing bounds check.
      
      This is a partial fix for #558. It fixes anchoring of one of two test
      annotations on that page. The other fails due to differences in the
      extracted text between the HTML and PDF versions of the article.
      a2336a7c
  5. 25 Oct, 2017 1 commit
    • Robert Knight's avatar
      Strip unknown query params when generating Internet Archive embed URLs · 4d05b426
      Robert Knight authored
      Internet Archive details pages may include params in the query string
      as well as "start" and "end" params in the path. In that case invalid
      URLs were being generated.
      
      Use a more robust approach to generating embed URLs and add some missing
      test cases. Any unrecognized query params are ignored when generating
      the embed URLs.
      4d05b426
  6. 23 Oct, 2017 4 commits
  7. 20 Oct, 2017 1 commit
  8. 09 Oct, 2017 2 commits
  9. 03 Oct, 2017 3 commits
  10. 29 Sep, 2017 1 commit
    • Sean Hammond's avatar
      Send search URIs to other frames by postMessage() · 9ea6b7d4
      Sean Hammond authored
      Add support for receiving postMessage() requests from other windows or
      frames and responding by sending the list of search URIs that the client
      is using for the current document to search the Hypothesis API for
      annotations.
      
      This can be used by our LTI app to get the search URIs when the student
      submits an assignment. The app needs the search URIs to later search the
      API for the student's annotations.
      9ea6b7d4
  11. 27 Sep, 2017 1 commit
  12. 22 Sep, 2017 2 commits