1. 28 May, 2014 5 commits
    • Randall Leeds's avatar
      Include the query when rebasing heatmap SVG refs · d7b9dbf8
      Randall Leeds authored
      Some browsers seem to care about this. Close #1241.
      d7b9dbf8
    • csillag's avatar
      ffaf4253
    • csillag's avatar
      Revert "Add simple on/off option to whether load dtm or not" · b09290fc
      csillag authored
      This reverts commit 4eb0de8ea0de8098e2771c8a276d75434f2c99f6.
      b09290fc
    • Ujvari Gergely's avatar
      Add simple on/off option to whether load dtm or not · cf210db6
      Ujvari Gergely authored
      This commit removes the dtm plugin and all dtm dependent plugins from
      the guest.coffee and introduces a dtm parameter inside the embed.txt
      If this parameter is true (by default  it is) it loads the
      DomTextMapper, TextPosition, FuzzyTextAnchors, PDF plugins.
      
      Fixes #1233
      cf210db6
    • Randall Leeds's avatar
      beforeAnnotationCreated before setupAnnotation · ee7b3c18
      Randall Leeds authored
      When always on highlights and the highlighter mode were introduced in
      ddf17189fbf2d428b21fd31065a1c2d2bc6ab08b the beforeAnnotationCreated
      event was not fired in the guest frame. Instead, a special inject call
      was added to the bridge to send the annotation and the event fired in
      the iframe first. Later, when I removed this, I added the event after
      the call to setupAnnotation.
      
      The change in 3613c7d91682a438b1d243b9573cb941b26cdc43 uses the
      annotationsLoaded event to notify listeners when highlights change as a
      result of realizing anchors. This presents a problem because the bridge
      ignores the beforeAnnotationCreated event for annotations that have
      already been tagged by the bridge, but this load event causes the new
      highlight to be tagged and serialized.
      
      Move the beforeAnnotationCreated event to before the setupAnnotation
      call, which is the order of things in non-highlighter mode, so that
      the event is properly propagated to the sidebar iframe.
      
      Close #1240
      ee7b3c18
  2. 27 May, 2014 7 commits
    • Randall Leeds's avatar
      33a2e7b9
    • Randall Leeds's avatar
      Switch view/sort to fixed position · 2d92c812
      Randall Leeds authored
      Close #1232
      2d92c812
    • Randall Leeds's avatar
      Don't rely on cookies to provide the csrf token · cba2320b
      Randall Leeds authored
      Angular won't see the cookie value when running from the extension
      because the app page is served from the extension bundle and is
      therefore on a different origin than the backend.
      
      Similarly, Angular doesn't set the header when making cross-origin
      requests.
      
      Work around the issue by sending the token in responses from the
      backend and setting the header ourselves.
      cba2320b
    • csillag's avatar
      Set the default sort to , as requested in #1231. · b17d4dce
      csillag authored
      b17d4dce
    • csillag's avatar
      Implement location sort. · 5fc45562
      csillag authored
      The only way to get information about the location of the annotations
      in the document is to request this information from the highlights.
      
      This information can't be read out from the selectors, because anchoring
      can place them *anywhere* in the document.
      
      They also can't be read from the anchors, because anchors can contain
      any kind of description; there is no mapping to any uniform coordinate
      system.
      
      The only way to get this information is to ask the hights for
      the coordinates, after they have been rendered.
      
      So this must be done after the second-phase of anchoring; after the
      rendering of the highlights in the DOM.
      
      So now we query this info from the highlights (upon rendering
      in the host fram), and then store it back into the targets,
      which are then sent back to the sidebar, so that this information
      is available for sorting.
      
      Fixes #1217.
      5fc45562
    • csillag's avatar
      Don't try to show annotations with null IDs in the sidebar · eb42da74
      csillag authored
      When an annotation has not been saved yet, it does not have
      a real ID. In these cases, it does not make sense to try to
      send the empty ID over the RPC channel to try to display the
      (yet) non-exisitent annotation card in the sidebar.
      
      There is already some filtering for this on the other side,
      but I think it makes sense to filter out invalid element
      as soon as possible.
      eb42da74
    • Randall Leeds's avatar
      Remove unused dark-noise CSS · 53bb07a8
      Randall Leeds authored
      53bb07a8
  3. 26 May, 2014 1 commit
  4. 24 May, 2014 1 commit
  5. 23 May, 2014 3 commits
  6. 22 May, 2014 7 commits
  7. 21 May, 2014 2 commits
  8. 20 May, 2014 5 commits
  9. 16 May, 2014 2 commits
  10. 15 May, 2014 7 commits