The way our coffee is being bundled is actually problematic because
each of the individual files insn't wrapped in an anonymous function,
only the whole coffee bundle is. Therefore, the configure reference
in socket.coffee should have failed. It doesn't. Who knows what else
might be confused as a result of this situation. I'll sort it all out
this week.

And remove leftover plus_1.png reference.

Drop heatmap comment tab and convert tabs to css

CSStweaks3

Kicking off work on revamping the heatmap a little bit. This change
removes the comment tab. Clearly, something needs to be done to restore
discoverability to comments, but there seemed to be some consensus that
the comment tab was not comprehensible enough.

Additionally, I got pretty sick of the tabs bouncing around. I removed
the transitions, slimmed the tabs down a litle bit, and remade them in
pure CSS. The pure CSS has the advantage of avoiding extra network
requests to fetch the tab SVGs. Also, the SVGs contained some padding
and borders that is easier to account for if its all in the CSS.

My last commit here (https://github.com/hypothesis/h/commit/5f56d8ad0424f11e52736fd9a1f9b8c30ab0f6a1)
has broken this function for or operators, because it forgets to apply the rule.format() call
to the search terms

I.e the user field uses this to transform the username to the full user format (acct:username@domain)
And because of this the user streams were broken.

Fix #1391

There seems to be some combination of conditions which cause Firefox
to infinite loop on the $location service's watchers. Bisecting pointed
to the commit where I removed this. For now, let's slap this bandaid
on. The proper fix probably has to do with making the parameters we
pass to the iframe in its src actually do something (like validating
the origin of frames that connect to the sidebar) and then clearing the
parameters from the URL so they don't cause a reload after the initial
redirection to /viewer.

It's never called except within the AppController.

Another step toward #1207

It slows things down, especially on mobile devices and on the stream
where many annotations are loaded at once, and it doesn't add much
as it is.

Close #1119

I find the tab blinking to be too subtle to be meaningful and not
a worthy enough feature to justify more jQuery UI use or storing
an additional property on the annotation (see #1207).

If we want a feature like this we'll have to come back and revisit
it with a more critical eye.

Reply email notifications

This part of the code survived the refactoring.
In the past it has received the values in a comma separated string,
now it receives them as a list.

Also, the operator for tag search is 'and' not 'or'

If new annotation data arrives via websocket, the applyUpdates()
function processes it and injects the new annotation data into our
client-side annotation-db.

Some annotations (depending on the viewstate) are put immediately into the viewer
by adding them to the $rootScope.annotations

However, in the case of the stream page reply annotations can arrive without
their parent annotation, and because that they didn't get inserted into
the rootScope and thus never displayed

This commit fixes that, by letting these annotations inserted into
the rootScope.annotations for document viewstate (which the stream uses)

Search ui tweaks

Fix server errors in login form
Fix #1375

In the formValidate directive, previously the error would only be reset
once the form was resubmitted, this caused confusing behaviour.

Fixes #1375.

This seems to be the correct way to interact with Angular views.