1. 17 May, 2019 2 commits
    • Robert Knight's avatar
      Merge pull request #1127 from hypothesis/simplify-manifest-rebuild · db2d5282
      Robert Knight authored
      Fix/simplify manifest rebuild when running "gulp watch"
      db2d5282
    • Robert Knight's avatar
      Fix/simplify manifest rebuild when running "gulp watch" · 5ad858ef
      Robert Knight authored
      On my system "gulp watch" was failing to generate the client's entry
      point script `build/boot.js` correctly. This may have happened after
      recent upgrades to gulp or Node.
      
      The issue was that `generateManifest` was run after "gulp
      watch" started, before build/scripts/boot.bundle.js was generated,
      producing an empty output file in build/boot.js. It was not re-run later
      after build/scripts/boot.bundle.js was generated.
      
      After some experimentation, removing use of `gulp-batch` in the
      `watch-manifest` task resolved the issue. I haven't verified whether the
      node upgrade or a gulp upgrade was the root cause. Since gulp-batch was
      non-essential, I've just removed it to simplify things and reduce the
      risk of similar issues happening in future.
      5ad858ef
  2. 16 May, 2019 1 commit
  3. 15 May, 2019 2 commits
  4. 14 May, 2019 4 commits
  5. 13 May, 2019 29 commits
  6. 10 May, 2019 2 commits