• Robert Knight's avatar
    Fix/simplify manifest rebuild when running "gulp watch" · 5ad858ef
    Robert Knight authored
    On my system "gulp watch" was failing to generate the client's entry
    point script `build/boot.js` correctly. This may have happened after
    recent upgrades to gulp or Node.
    
    The issue was that `generateManifest` was run after "gulp
    watch" started, before build/scripts/boot.bundle.js was generated,
    producing an empty output file in build/boot.js. It was not re-run later
    after build/scripts/boot.bundle.js was generated.
    
    After some experimentation, removing use of `gulp-batch` in the
    `watch-manifest` task resolved the issue. I haven't verified whether the
    node upgrade or a gulp upgrade was the root cause. Since gulp-batch was
    non-essential, I've just removed it to simplify things and reduce the
    risk of similar issues happening in future.
    5ad858ef
Name
Last commit
Last update
.github Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.prettierrc Loading commit data...
.travis.yml Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
yarn.lock Loading commit data...