- 22 Feb, 2022 1 commit
-
-
Robert Knight authored
Fix various errors and omissions found when TypeScript's `noImplicitAny` option is enabled.
-
- 21 Feb, 2022 13 commits
-
-
dependabot[bot] authored
Bumps [showdown](https://github.com/showdownjs/showdown) from 1.9.1 to 2.0.0. - [Release notes](https://github.com/showdownjs/showdown/releases) - [Changelog](https://github.com/showdownjs/showdown/blob/2.0.0/CHANGELOG.md) - [Commits](https://github.com/showdownjs/showdown/compare/1.9.1...2.0.0) --- updated-dependencies: - dependency-name: showdown dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.17.2 to 7.17.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.5/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.49.7 to 1.49.8. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.49.7...1.49.8) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.6.5 to 10.6.6. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.6.5...10.6.6) --- updated-dependencies: - dependency-name: preact dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.17.7 to 6.17.9. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.17.7...6.17.9) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.0.22 to 3.0.23. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/compare/v3.0.22...v3.0.23) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.3.5 to 2.3.6. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.3.5...2.3.6) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [express](https://github.com/expressjs/express) from 4.17.2 to 4.17.3. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](https://github.com/expressjs/express/compare/4.17.2...4.17.3) --- updated-dependencies: - dependency-name: express dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 13.3.1 to 13.3.2. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v13.3.1...v13.3.2) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.0 to 9.2.1. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v9.2.0...v9.2.1) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js) from 3.21.0 to 3.21.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/compare/v3.21.0...v3.21.1) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [rollup](https://github.com/rollup/rollup) from 2.67.2 to 2.67.3. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.67.2...v2.67.3) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1073.0 to 2.1077.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1073.0...v2.1077.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 16 Feb, 2022 1 commit
-
-
Eduardo Sanz García authored
Previously the following attributes in the meta tag: ``` <meta name="DC_IDENTIFIER" .../> <meta name="EPRINTS.TITLE_" .../> <meta property="OG:URL" .../> <meta name="CITATION_DOI" .../> <meta name="PRISM_TITLE" .../> <meta name="TWITTER:SITE" .../> ``` produced a metadata dictionary like this: ``` { dc: {IDENTIFIER: [...] }, eprints: {TITLE: [...]}, facebook: {URL: [...]}, highwire: {DOI: [...]}, twitter: {SITE: [...]} } ``` Now, with the modifications introduced in this PR, it produces a metadata dictionary where all the keys are lowercase: ``` { dc: {identifier: [...] }, eprints: {title: [...]}, facebook: {url: [...]}, highwire: {doi: [...]}, twitter: {site: [...]} } ``` I have confirmed that `h` expects the lowercase version of the keys `identifier` and `doi`: https://github.com/hypothesis/h/blob/73dacc722367c44903ff3c6f610712ba8f43934d/h/util/document_claims.py#L222 https://github.com/hypothesis/h/blob/73dacc722367c44903ff3c6f610712ba8f43934d/h/util/document_claims.py#L247 Hence, if they are not provided as lowercase version, they will be ignored and the document equivalence will not work.
-
- 15 Feb, 2022 2 commits
-
-
Robert Knight authored
Notify newly connected guest frames of the current sidebar layout. This allows newly created guests to properly activate side-by-side mode if the sidebar is already open and the guest supports it. This is relevant when navigating between chapters in a VitalSource book.
-
Robert Knight authored
Only load the `pdfjs-overrides.css` bundle when the client is loaded in PDF.js. This fixes an issue where a global styling change that was recently added specifically for PDF.js [1] ended up affecting other web pages [2]. [1] https://github.com/hypothesis/client/pull/4208 [2] https://github.com/hypothesis/product-backlog/issues/1270#issuecomment-1039647361
-
- 14 Feb, 2022 16 commits
-
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1069.0 to 2.1073.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1069.0...v2.1073.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.17.0 to 7.17.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.2/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Eduardo authored
Co-authored-by: Robert Knight <robertknight@gmail.com>
-
Eduardo Sanz García authored
Before this PR, when there was two frames, A and B, if the adder was in frame A, it was necessary to __double click__ on frame B to remove the adder and the selection from frame A. After this PR, __a single click__ on frame B removes the adder and text selection from frame A. This behaviour is similar to what happens on a single frame scenario, where a single click removes the adder and the selection.
-
dependabot[bot] authored
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Tests sometimes failed because a PortRPC method handler was not called after the fixed message delivery delay that the tests allowed. I have not been able to reproduce locally, but attempt to resolve the issue by waiting for a specific message to be delivered to the MessagePort instead of waiting a fixed amount of time. For some test cases which assert that a message was *not* delivered, a fixed delay is still used. This is acceptable because the test will still pass in the rare cases where the fixed delay is too short.
-
Eduardo Sanz García authored
In #4195, we removed `clearSelectionExceptIn` RPC event. Instead, the host frame sends `clearSelection` RPC events to specific guest frames.
-
Robert Knight authored
The `hasHypothesis` function always returned false because it relied on a global variable that no longer exists. The fact that it was broken didn't cause noticeable problems because the client's boot script also has a check for whether Hypothesis is already injected. Replace the broken check with a working one that corresponds to the nearby `injectHypothesis` function.
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 8.8.0 to 8.9.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.8.0...v8.9.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.15 to 6.3.16. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.3.15...v6.3.16) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.0.18 to 3.0.22. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/compare/v3.0.18...v3.0.22) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@rollup/plugin-replace](https://github.com/rollup/plugins/tree/HEAD/packages/replace) from 3.0.1 to 3.1.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/replace/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/yaml-v3.1.0/packages/replace) --- updated-dependencies: - dependency-name: "@rollup/plugin-replace" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.17.4 to 6.17.7. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.17.4...6.17.7) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 13.1.3 to 13.3.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v13.1.3...v13.3.1) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 1.72.1 to 1.72.2. - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/1.72.1...1.72.2) --- updated-dependencies: - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [rollup](https://github.com/rollup/rollup) from 2.67.1 to 2.67.2. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.67.1...v2.67.2) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 11 Feb, 2022 7 commits
-
-
Lyza Danger Gardner authored
PDFjs' CSS sets `font-size: 10px` on the `html` element. This sets 1rem = `10px` which is tiny. Our styles work in rem units for spacing, so padding, margins, etc. are too tight with that `10px` base size. Set `html` font-size back to 100% for now. This does not have any apparent effect on PDFjs styling, as `body` sets `font-size: 16px` anyway. See https://github.com/mozilla/pdf.js/issues/14555
-
Eduardo Sanz García authored
For simplicity, combine `prefix` and `delimiter` into a single argument.
-
Robert Knight authored
This property is already set when frames are added to the fake store.
-
Robert Knight authored
The result of `store.frames()` needs to be kept in sync with `store.connectFrame()` and `store.destroyFrame()` calls. Change the way these methods are faked in the FrameSyncService tests to ensure this happens.
-
Robert Knight authored
Handle the case when an annotation is returned from the backend whose URL does not match the frame URL and where there is no "main" guest frame. This can happen in VitalSource, where no guest is created in the host frame. The general solution to this is to change the client and h so that it can always determine which query URL an annotation from h matched. See [1]. This is an interim step which will work in VitalSource and similar scenarios. [1] https://github.com/hypothesis/client/issues/4191
-
Eduardo Sanz García authored
The new order feels more logical, `attributeName="{prefix}{delimiter}..."`: 1. attribute name to be parsed in the metatags 2. prefix 3. delimiter
-
Lyza Danger Gardner authored
-