• Robert Knight's avatar
    Scroll correct Element when scrolling a thread into view · 03ab296f
    Robert Knight authored
    Since the `<thread-list>` is now contained within a scrollable element
    which is not `document.body`, it needs to scroll that element rather
    than the window in order to scroll the element into view.
    
     * Remove the hard-coded selector used to find the scroll root and
       instead search for the closest ancestor element to the
       `<thread-list>` whose computed style has `overflowY` set to `scroll`.
     * Set the scroll root Element's `scrollTop` to scroll the thread list
       instead of calling `window.scroll`
     * Compute the maximum scroll offset based on the `scrollTop` and
       `scrollHeight` properties of the scroll root element instead of
       using `document.body.scrollHeight`.
     * Update tests for `<thread-list>` to check for the scrollable
       ancestor being scrolled instead of the window.
    03ab296f
Name
Last commit
Last update
..
test Loading commit data...
annotation-share-dialog.js Loading commit data...
annotation-thread.js Loading commit data...
annotation-viewer-content.js Loading commit data...
annotation.js Loading commit data...
dropdown-menu-btn.js Loading commit data...
excerpt.js Loading commit data...
group-list.js Loading commit data...
help-link.js Loading commit data...
help-panel.js Loading commit data...
hypothesis-app.js Loading commit data...
loggedout-message.js Loading commit data...
login-control.js Loading commit data...
login-form.js Loading commit data...
markdown.js Loading commit data...
moderation-banner.js Loading commit data...
publish-annotation-btn.js Loading commit data...
search-input.js Loading commit data...
search-status-bar.js Loading commit data...
selection-tabs.js Loading commit data...
share-dialog.js Loading commit data...
sidebar-content.js Loading commit data...
sidebar-tutorial.js Loading commit data...
sort-dropdown.js Loading commit data...
stream-content.js Loading commit data...
svg-icon.js Loading commit data...
tag-editor.js Loading commit data...
thread-list.js Loading commit data...
timestamp.js Loading commit data...
top-bar.js Loading commit data...