• Robert Knight's avatar
    Scroll correct Element when scrolling a thread into view · 03ab296f
    Robert Knight authored
    Since the `<thread-list>` is now contained within a scrollable element
    which is not `document.body`, it needs to scroll that element rather
    than the window in order to scroll the element into view.
    
     * Remove the hard-coded selector used to find the scroll root and
       instead search for the closest ancestor element to the
       `<thread-list>` whose computed style has `overflowY` set to `scroll`.
     * Set the scroll root Element's `scrollTop` to scroll the thread list
       instead of calling `window.scroll`
     * Compute the maximum scroll offset based on the `scrollTop` and
       `scrollHeight` properties of the scroll root element instead of
       using `document.body.scrollHeight`.
     * Update tests for `<thread-list>` to check for the scrollable
       ancestor being scrolled instead of the window.
    03ab296f
Name
Last commit
Last update
..
annotation-share-dialog-test.js Loading commit data...
annotation-test.js Loading commit data...
annotation-thread-test.js Loading commit data...
annotation-viewer-content-test.js Loading commit data...
excerpt-test.js Loading commit data...
group-list-test.js Loading commit data...
hypothesis-app-test.js Loading commit data...
login-control-test.js Loading commit data...
login-form-test.coffee Loading commit data...
markdown-test.js Loading commit data...
moderation-banner-test.js Loading commit data...
publish-annotation-btn-test.js Loading commit data...
search-input-test.js Loading commit data...
search-status-bar-test.js Loading commit data...
selection-tabs-test.js Loading commit data...
share-dialog-test.js Loading commit data...
sidebar-content-test.js Loading commit data...
sidebar-tutorial-test.js Loading commit data...
sort-dropdown-test.js Loading commit data...
stream-content-test.js Loading commit data...
svg-icon-test.js Loading commit data...
tag-editor-test.js Loading commit data...
thread-list-test.js Loading commit data...
timestamp-test.js Loading commit data...
top-bar-test.js Loading commit data...