• Robert Knight's avatar
    Replace the `BEFORE_ANNOTATION_CREATED` event · 75a0e8aa
    Robert Knight authored
    The `BEFORE_ANNOTATION_CREATED` event was used for two purposes:
    
     1. Invoke `annotationsService.create(...)` to create the annotation in
        the sidebar.
     2. Scroll the newly created annotation into view
    
    Resolve (1) by calling `annotationsService.create` directly from the
    `frameSync` service and resolve (2) by watching for changes to
    `unsavedAnnotations()` in the store and scrolling to the new annotation
    when it appears.
    
    There is one functional change which is that replies will be scrolled
    into view, as this seems like a useful behavior if the user clicks the
    "Reply" button for a thread and the input field appears below the bottom
    of the screen.
    75a0e8aa
Name
Last commit
Last update
..
annotation-action-bar-test.js Loading commit data...
annotation-body-test.js Loading commit data...
annotation-document-info-test.js Loading commit data...
annotation-header-test.js Loading commit data...
annotation-publish-control-test.js Loading commit data...
annotation-quote-test.js Loading commit data...
annotation-share-control-test.js Loading commit data...
annotation-share-info-test.js Loading commit data...
annotation-test.js Loading commit data...
annotation-user-test.js Loading commit data...
annotation-viewer-content-test.js Loading commit data...
autocomplete-list-test.js Loading commit data...
button-test.js Loading commit data...
excerpt-test.js Loading commit data...
focused-mode-header-test.js Loading commit data...
group-list-item-test.js Loading commit data...
group-list-section-test.js Loading commit data...
group-list-test.js Loading commit data...
help-panel-test.js Loading commit data...
hypothesis-app-test.js Loading commit data...
logged-out-message-test.js Loading commit data...
login-prompt-panel-test.js Loading commit data...
markdown-editor-test.js Loading commit data...
markdown-view-test.js Loading commit data...
menu-item-test.js Loading commit data...
menu-keyboard-navigation-test.js Loading commit data...
menu-section-test.js Loading commit data...
menu-test.js Loading commit data...
moderation-banner-test.js Loading commit data...
new-note-btn-test.js Loading commit data...
search-input-test.js Loading commit data...
search-status-bar-test.js Loading commit data...
selection-tabs-test.js Loading commit data...
share-annotations-panel-test.js Loading commit data...
share-links-test.js Loading commit data...
sidebar-content-error-test.js Loading commit data...
sidebar-content-test.js Loading commit data...
sidebar-panel-test.js Loading commit data...
slider-test.js Loading commit data...
sort-menu-test.js Loading commit data...
spinner-test.js Loading commit data...
stream-content-test.js Loading commit data...
stream-search-input-test.js Loading commit data...
tag-editor-test.js Loading commit data...
tag-list-test.js Loading commit data...
thread-card-test.js Loading commit data...
thread-list-test.js Loading commit data...
thread-test.js Loading commit data...
timestamp-test.js Loading commit data...
toast-messages-test.js Loading commit data...
top-bar-test.js Loading commit data...
tutorial-test.js Loading commit data...
user-menu-test.js Loading commit data...
version-info-test.js Loading commit data...