• Robert Knight's avatar
    Remove ThreadList debugging code · b4fe9177
    Robert Knight authored
    I believe we know what was causing the issue in ThreadList where an
    effect callback was sometimes called with closed-over variables which
    did not match the most recent render. See [1] for details. The issue
    really needs to be resolved in a more general way than trying to work
    around it in individual components.
    
    This commit removes code added for debugging this and also adds a check
    for a legitimate way (ie. without anything going wrong inside Preact)
    that the problem could occur, although it should never happen in the
    actual app as we never render `ThreadList` in a container that is
    disconnected from the document.
    
    [1] https://github.com/hypothesis/client/pull/3665#issuecomment-895857072
    b4fe9177
Name
Last commit
Last update
..
AnnotationView-test.js Loading commit data...
AutocompletList-test.js Loading commit data...
Excerpt-test.js Loading commit data...
FilterSelect-test.js Loading commit data...
FilterStatus-test.js Loading commit data...
HelpPanel-test.js Loading commit data...
HypothesisApp-test.js Loading commit data...
LaunchErrorPanel-test.js Loading commit data...
LoggedOutMessage-test.js Loading commit data...
LoginPromptPanel-test.js Loading commit data...
MarkdownEditor-test.js Loading commit data...
MarkdownView-test.js Loading commit data...
Menu-test.js Loading commit data...
MenuItem-test.js Loading commit data...
MenuKeyboardNavigation-test.js Loading commit data...
MenuSection-test.js Loading commit data...
ModerationBanner-test.js Loading commit data...
NotebookFilters-test.js Loading commit data...
NotebookResultCount-test.js Loading commit data...
NotebookView-test.js Loading commit data...
PaginatedThreadList-test.js Loading commit data...
PaginationNavigation-test.js Loading commit data...
SearchInput-test.js Loading commit data...
SelectionTabs-test.js Loading commit data...
ShareAnnotationsPanel-test.js Loading commit data...
ShareLinks-test.js Loading commit data...
SidebarContentError-test.js Loading commit data...
SidebarPanel-test.js Loading commit data...
SidebarView-test.js Loading commit data...
SortMenu-test.js Loading commit data...
Spinner-test.js Loading commit data...
StreamSearchInput-test.js Loading commit data...
StreamView-test.js Loading commit data...
TagEditor-test.js Loading commit data...
TagList-test.js Loading commit data...
Thread-test.js Loading commit data...
ThreadCard-test.js Loading commit data...
ThreadList-test.js Loading commit data...
ToastMessages-test.js Loading commit data...
TopBar-test.js Loading commit data...
Tutorial-test.js Loading commit data...
UserMenu-test.js Loading commit data...
VersionInfo-test.js Loading commit data...
slider-test.js Loading commit data...