• Robert Knight's avatar
    Do not set "aria-pressed" attribute for non-toggle buttons · fd927d6b
    Robert Knight authored
    Setting the `aria-pressed` attribute on a button indicates to assistive
    technology that it is a toggle button. Because the `Button` component
    always set this attribute and the `isActive` prop had a default value of
    false, this meant that every `Button` in the UI was identified as a
    toggle button by screen readers.
    
    Fix the issue by renaming `isActive` to `isPressed` and aligning it with
    the behavior of `aria-pressed`:
    
     - If `true`, the button is a pressed toggle button
     - If `false`, the button is a non-pressed toggle button
     - If undefined, the button is a regular button and `aria-pressed` is
       not set
    fd927d6b
Name
Last commit
Last update
..
annotation-action-bar-test.js Loading commit data...
annotation-body-test.js Loading commit data...
annotation-document-info-test.js Loading commit data...
annotation-header-test.js Loading commit data...
annotation-omega-test.js Loading commit data...
annotation-publish-control-test.js Loading commit data...
annotation-quote-test.js Loading commit data...
annotation-share-control-test.js Loading commit data...
annotation-share-info-test.js Loading commit data...
annotation-test.js Loading commit data...
annotation-thread-test.js Loading commit data...
annotation-user-test.js Loading commit data...
annotation-viewer-content-test.js Loading commit data...
autocomplete-list-test.js Loading commit data...
button-test.js Loading commit data...
excerpt-test.js Loading commit data...
focused-mode-header-test.js Loading commit data...
group-list-item-test.js Loading commit data...
group-list-section-test.js Loading commit data...
group-list-test.js Loading commit data...
help-panel-test.js Loading commit data...
hypothesis-app-test.js Loading commit data...
logged-out-message-test.js Loading commit data...
markdown-editor-test.js Loading commit data...
markdown-view-test.js Loading commit data...
menu-item-test.js Loading commit data...
menu-section-test.js Loading commit data...
menu-test.js Loading commit data...
moderation-banner-test.js Loading commit data...
new-note-btn-test.js Loading commit data...
search-input-test.js Loading commit data...
search-status-bar-test.js Loading commit data...
selection-tabs-test.js Loading commit data...
share-annotations-panel-test.js Loading commit data...
share-links-test.js Loading commit data...
sidebar-content-error-test.js Loading commit data...
sidebar-content-test.js Loading commit data...
sidebar-panel-test.js Loading commit data...
slider-test.js Loading commit data...
sort-menu-test.js Loading commit data...
spinner-test.js Loading commit data...
stream-content-test.js Loading commit data...
stream-search-input-test.js Loading commit data...
svg-icon-test.js Loading commit data...
tag-editor-test.js Loading commit data...
tag-list-test.js Loading commit data...
thread-list-test.js Loading commit data...
timestamp-test.js Loading commit data...
top-bar-test.js Loading commit data...
tutorial-test.js Loading commit data...
user-menu-test.js Loading commit data...
version-info-test.js Loading commit data...