• Robert Knight's avatar
    Extract `quote` function from annotation / view-filter · d4374884
    Robert Knight authored
    Both `components/annotation` and `view-filter` modules had logic and
    tests for extracting a quote from an annotation object. Extract these
    into a shared `quote` function in `util/annotation-metadata`.
    
    One small change is that `view-filter`'s implementation allowed
    annotation objects with _no_ `target` property. These should never
    occur. There is a known issue where creating a Page Note results in an
    annotation with an _empty_ `target` property until the annotation is
    saved (see [1]). That case, which is still handled, looks like a mistake,
    but resolving it is outside the scope of this change.
    
    [1] https://github.com/hypothesis/client/issues/1290
    d4374884
Name
Last commit
Last update
..
components Loading commit data...
directive Loading commit data...
filter Loading commit data...
services Loading commit data...
store Loading commit data...
templates Loading commit data...
test Loading commit data...
util Loading commit data...
build-thread.js Loading commit data...
cross-origin-rpc.js Loading commit data...
events.js Loading commit data...
ga.js Loading commit data...
get-api-url.js Loading commit data...
host-config.js Loading commit data...
index.js Loading commit data...
live-reload-client.js Loading commit data...
markdown-commands.js Loading commit data...
media-embedder.js Loading commit data...
render-markdown.js Loading commit data...
search-client.js Loading commit data...
service-config.js Loading commit data...
ui-constants.js Loading commit data...
virtual-thread-list.js Loading commit data...
websocket.js Loading commit data...