• Robert Knight's avatar
    Move margin between `ThreadCard`s to `ThreadList` · ebee0db9
    Robert Knight authored
    Move the bottom margin on thread cards from the root `<div>` rendered by
    `ThreadCard` to the wrapper div that contains it rendered by
    `ThreadList`.
    
    Aside from making conceptual sense that the list component controls the
    spacing of list items, this also fixes an issue where the thread list
    would sometimes jump when scrolling. This happened because the height of
    individual threads was computed by calling `getElementHeightWithMargins`
    on the wrapper div, which only accounted for margins on the wrapper div,
    not margins on descendants. Note that due to margin collapsing, the descendant
    margins did not contribute to the `getBoundingClientRect()` of the
    wrapper div.
    ebee0db9
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.prettierrc Loading commit data...
.python-version Loading commit data...
.travis.yml Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
yarn.lock Loading commit data...