-
Robert Knight authored
Move the bottom margin on thread cards from the root `<div>` rendered by `ThreadCard` to the wrapper div that contains it rendered by `ThreadList`. Aside from making conceptual sense that the list component controls the spacing of list items, this also fixes an issue where the thread list would sometimes jump when scrolling. This happened because the height of individual threads was computed by calling `getElementHeightWithMargins` on the wrapper div, which only accounted for margins on the wrapper div, not margins on descendants. Note that due to margin collapsing, the descendant margins did not contribute to the `getBoundingClientRect()` of the wrapper div.
ebee0db9
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
annotator | ||
boot | ||
images/icons | ||
shared | ||
sidebar | ||
styles | ||
test-util | ||
.eslintrc | ||
karma.config.js | ||
tsconfig.json |