• Lyza Danger Gardner's avatar
    Don't show edited timestamps if annotations haven't been updated · 81a45e4a
    Lyza Danger Gardner authored
    Previously, the `AnnotationHeader` component checked the equivalency
    of `annotation.created` and `annotation.updated` to determine if an
    annotation had been updated subsequent to its creation. This is
    problematic if an annotation has a very small difference between its
    `created` and `updated` dates.
    
    `created` and `updated` are returned by the API as ISO-8601 date strings
    with microsecond resolution. These days, annotations created by the `h`
    service will have exactly equivalent `created` and `updated` timestamps
    (assuming they haven't actually been edited subsequently, of course). In
    the past, however, annotations often had negligible (sub-second)
    differences in their `created` and `updated` dates. This resulted in
    an edited timestamp misleadingly appearing in the UI for older
    annotations.
    
    These changes add a `hasBeenEdited` function to the
    `annotation-metadata` util module that considers an annotation edited
    only if `created` and `updated` differ by at least 2 seconds.
    
    Tests for `annotation-metadata` have also been modernized somewhat here.
    
    Fixes #2684
    81a45e4a
Name
Last commit
Last update
..
test Loading commit data...
account-id.js Loading commit data...
annotation-metadata.js Loading commit data...
annotation-sharing.js Loading commit data...
build-thread.js Loading commit data...
collections.js Loading commit data...
copy-to-clipboard.js Loading commit data...
date.js Loading commit data...
disable-opener-for-external-links.js Loading commit data...
dom.js Loading commit data...
fetch-config.js Loading commit data...
group-list-item-common.js Loading commit data...
group-organizations.js Loading commit data...
groups.js Loading commit data...
immutable.js Loading commit data...
is-sidebar.js Loading commit data...
is-third-party-service.js Loading commit data...
memoize.js Loading commit data...
oauth-client.js Loading commit data...
observe-element-size.js Loading commit data...
on-activate.js Loading commit data...
permissions.js Loading commit data...
postmessage-json-rpc.js Loading commit data...
random.js Loading commit data...
retry.js Loading commit data...
search-filter.js Loading commit data...
sentry.js Loading commit data...
service-context.js Loading commit data...
session.js Loading commit data...
state.js Loading commit data...
tabs.js Loading commit data...
theme.js Loading commit data...
thread-annotations.js Loading commit data...
thread.js Loading commit data...
time.js Loading commit data...
unicode.js Loading commit data...
url.js Loading commit data...
version-data.js Loading commit data...
view-filter.js Loading commit data...
visible-threads.js Loading commit data...
watch.js Loading commit data...