• Lyza Danger Gardner's avatar
    Don't show edited timestamps if annotations haven't been updated · 81a45e4a
    Lyza Danger Gardner authored
    Previously, the `AnnotationHeader` component checked the equivalency
    of `annotation.created` and `annotation.updated` to determine if an
    annotation had been updated subsequent to its creation. This is
    problematic if an annotation has a very small difference between its
    `created` and `updated` dates.
    
    `created` and `updated` are returned by the API as ISO-8601 date strings
    with microsecond resolution. These days, annotations created by the `h`
    service will have exactly equivalent `created` and `updated` timestamps
    (assuming they haven't actually been edited subsequently, of course). In
    the past, however, annotations often had negligible (sub-second)
    differences in their `created` and `updated` dates. This resulted in
    an edited timestamp misleadingly appearing in the UI for older
    annotations.
    
    These changes add a `hasBeenEdited` function to the
    `annotation-metadata` util module that considers an annotation edited
    only if `created` and `updated` differ by at least 2 seconds.
    
    Tests for `annotation-metadata` have also been modernized somewhat here.
    
    Fixes #2684
    81a45e4a
Name
Last commit
Last update
..
account-id-test.js Loading commit data...
annotation-metadata-test.js Loading commit data...
annotation-sharing-test.js Loading commit data...
build-thread-test.js Loading commit data...
collections-test.js Loading commit data...
copy-to-clipboard-test.js Loading commit data...
disable-opener-for-external-links-test.js Loading commit data...
dom-test.js Loading commit data...
fake-window.js Loading commit data...
fetch-config-test.js Loading commit data...
group-list-item-common-test.js Loading commit data...
group-organizations-test.js Loading commit data...
groups-test.js Loading commit data...
immutable-test.js Loading commit data...
is-sidebar-test.js Loading commit data...
is-third-party-service-test.js Loading commit data...
memoize-test.js Loading commit data...
oauth-client-test.js Loading commit data...
observe-element-size-test.js Loading commit data...
permissions-test.js Loading commit data...
postmessage-json-rpc-test.js Loading commit data...
random-test.js Loading commit data...
retry-test.js Loading commit data...
search-filter-test.js Loading commit data...
sentry-test.js Loading commit data...
service-context-test.js Loading commit data...
session-test.js Loading commit data...
state-test.js Loading commit data...
tabs-test.js Loading commit data...
theme-test.js Loading commit data...
thread-annotations-test.js Loading commit data...
thread-test.js Loading commit data...
time-test.js Loading commit data...
unicode-test.js Loading commit data...
url-test.js Loading commit data...
version-data-test.js Loading commit data...
view-filter-test.js Loading commit data...
visible-threads-test.js Loading commit data...
watch-test.js Loading commit data...