• Robert Knight's avatar
    Remove unnecessary array filter · f43663c6
    Robert Knight authored
    Remove a filter callback which always returned true. The first `!ann.id`
    condition is already part of the `store.unsavedAnnotations` logic. The
    second `isHighlight(...)` check did not work properly because the input
    was an annotation stub object with only `id` and `$tag` fields instead
    of the `Annotation` that `isHighlight` expects. For annotation stubs
    with no id, it always returned false.
    
    From a functional perspective the `isHighlight` check was also
    unnecessary. `store.unsavedAnnotations()` only returns IDs of
    annotations which have active drafts, but for highlights no draft is
    created.
    f43663c6
Name
Last commit
Last update
..
Annotation Loading commit data...
GroupList Loading commit data...
hooks Loading commit data...
test Loading commit data...
AnnotationView.js Loading commit data...
AutocompleteList.js Loading commit data...
Excerpt.js Loading commit data...
FilterSelect.js Loading commit data...
FilterStatus.js Loading commit data...
HelpPanel.js Loading commit data...
HypothesisApp.js Loading commit data...
LaunchErrorPanel.js Loading commit data...
LoggedOutMessage.js Loading commit data...
LoginPromptPanel.js Loading commit data...
MarkdownEditor.js Loading commit data...
MarkdownView.js Loading commit data...
Menu.js Loading commit data...
MenuItem.js Loading commit data...
MenuKeyboardNavigation.js Loading commit data...
MenuSection.js Loading commit data...
ModerationBanner.js Loading commit data...
NotebookFilters.js Loading commit data...
NotebookResultCount.js Loading commit data...
NotebookView.js Loading commit data...
PaginatedThreadList.js Loading commit data...
PaginationNavigation.js Loading commit data...
SearchInput.js Loading commit data...
SelectionTabs.js Loading commit data...
ShareAnnotationsPanel.js Loading commit data...
ShareLinks.js Loading commit data...
SidebarContentError.js Loading commit data...
SidebarPanel.js Loading commit data...
SidebarView.js Loading commit data...
Slider.js Loading commit data...
SortMenu.js Loading commit data...
StreamSearchInput.js Loading commit data...
StreamView.js Loading commit data...
TagEditor.js Loading commit data...
TagList.js Loading commit data...
Thread.js Loading commit data...
ThreadCard.js Loading commit data...
ThreadList.js Loading commit data...
ToastMessages.js Loading commit data...
TopBar.js Loading commit data...
Tutorial.js Loading commit data...
UserMenu.js Loading commit data...
VersionInfo.js Loading commit data...