- 14 Mar, 2022 4 commits
-
-
dependabot[bot] authored
Bumps [showdown](https://github.com/showdownjs/showdown) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/showdownjs/showdown/releases) - [Changelog](https://github.com/showdownjs/showdown/blob/2.0.3/CHANGELOG.md) - [Commits](https://github.com/showdownjs/showdown/compare/2.0.2...2.0.3) --- updated-dependencies: - dependency-name: showdown dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.1 to 9.2.2. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v9.2.1...v9.2.2) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.29.3 to 7.29.4. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.29.3...v7.29.4) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [rollup](https://github.com/rollup/rollup) from 2.70.0 to 2.70.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.70.0...v2.70.1) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 11 Mar, 2022 3 commits
-
-
Robert Knight authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
- 10 Mar, 2022 3 commits
-
-
Robert Knight authored
When choosing a scroll anchor to preserve the visible content after toggling side-by-side mode, ignore content in elements with `position: fixed` or `position: sticky` styles, since this content won't significantly shift its position as a result of the document content being resized.
-
Robert Knight authored
`waitFor` has a short default timeout of 10ms and this test sometimes failed in CI. Try increasing it to reduce flakiness. We might want to consider changing the `waitFor` default in future, although we also want to encourage test authors to avoid writing tests that frequently wait for long (> 10ms) periods of time.
-
Lyza Danger Gardner authored
-
- 09 Mar, 2022 4 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
- Add missing types in src/annotator and src/boot. - Simplify the return types of some config parsing functions by coercing invalid values to `null` or some other default. This reduces complexity with the types elsewhere and also potentially avoids some confusing errors if invalid values are specified here. - Add type definitions for hammerjs, scroll-into-view and lodash.debounce. The definitions for hammerjs and scroll-into-view come from DefinitelyTyped. For lodash a minimal custom definition has been written because the @types/lodash.debounce package includes types for the whole of lodash. In order to use these types the `allowSyntheticDefaultImports` flag had to be enabled in the TS configs. A consequence of adding types for scroll-into-view is that some missing null checks in sidebar components were found.
-
Lyza Danger Gardner authored
Re-implement `.styled-text` in Tailwind: * Simplify as much as possible and only impose rules that directly apply to a block of styled text * Re-generate heading size scale using `type-scale.com` (previous tool is no longer extant) * Ensure that all rules operate with `em` units (proportional to inherited font size) A subsequent step would be to extract a styled-text reusable component.
-
- 08 Mar, 2022 11 commits
-
-
dependabot[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Changelog](https://github.com/npm/npm-packlist/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/npm-packlist/compare/v3.0.0...v4.0.0) --- updated-dependencies: - dependency-name: npm-packlist dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1082.0 to 2.1088.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1082.0...v2.1088.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.16 to 6.3.17. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.3.16...v6.3.17) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.29.2 to 7.29.3. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.29.2...v7.29.3) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.18.0 to 6.18.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.18.0...6.18.1) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.7 to 8.4.8. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.7...8.4.8) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 13.4.0 to 13.5.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v13.4.0...v13.5.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [showdown](https://github.com/showdownjs/showdown) from 2.0.0 to 2.0.2. - [Release notes](https://github.com/showdownjs/showdown/releases) - [Changelog](https://github.com/showdownjs/showdown/blob/2.0.2/CHANGELOG.md) - [Commits](https://github.com/showdownjs/showdown/compare/2.0.0...2.0.2) --- updated-dependencies: - dependency-name: showdown dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 1.73.0 to 1.73.2. - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/1.73.2/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/1.73.0...1.73.2) --- updated-dependencies: - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [rollup](https://github.com/rollup/rollup) from 2.68.0 to 2.70.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.68.0...v2.70.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.5 to 4.6.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v4.5.5...v4.6.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 04 Mar, 2022 3 commits
-
-
Lyza Danger Gardner authored
This example can help test side-by-side mode on documents with a centered content area (e.g. `body` is set to `margin: 0 auto`) and a maximum content (`body`) width. This combination is used for some VitalSource EPUB books.
-
Lyza Danger Gardner authored
Make certain annotator components — the adder toolbar popup, e.g. — scale when the root font size of the underlying host page changes. Make sure other annotator UI that is associated with the sidebar — the toolbar and bucket bar — do NOT scale with text scaling. All controls should scale with user/page zoom.
-
Robert Knight authored
When a new content frame was found in VitalSource the client was only injected either if the frame is already loaded, or when the frame next emits a `load` event. In the latter case this waits until the document and its subresources have fully loaded. This can be slow in EPUB chapters that have a lot of images. Improve this by replacing the frame `load` event observer with a call to a new `onDocumentReady` function which fires as soon as a document becomes interactive (according to its `readyState`). - Rename existing `onDocumentReady` utility to `onNextDocumentReady` to make it clear that it only fires once, and change the implementation to be a wrapper around a new `onDocumentReady` function. - Add new `onDocumentReady` utility which monitors a frame for changes in the content document and invokes a callback each time a document becomes _ready_ (`readyState` is `interactive` or `complete`). - Redo the tests for utilities in `frame-observer.js` so that they use real iframes rather than fake ones. Iframes have a complex interface and loading sequence, so we really need to use the real thing for tests to give us confidence. - Use `onDocumentReady` in the VitalSource integration to respond more quickly to book content loading in a new content frame. - Modify several tests for `FrameObserver`, `VitalSourceInjector` and `HypothesisInjector` to be less sensitive to exact timings of events, as these changed between the previous and new methods for detecting when a document is ready. Fixes https://github.com/hypothesis/client/issues/4270
-
- 02 Mar, 2022 12 commits
-
-
Lyza Danger Gardner authored
Rename this class to be consistent with other class names in this module
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Now that all annotator components have been transitioned to tailwind, we no longer need to include `frontend-shared` utility styles in the built CSS, which should make it a little smaller.
-
Lyza Danger Gardner authored
Transition styling for the sidebar frame and its container to tailwind. Rename some classes for clarity: * `div.annotator-frame` -> `div.sidebar-container` as this is not a frame, and it contains the sidebar frame inside it * `iframe.h-sidebar-iframe` -> `iframe.sidebar-frame`
-
Lyza Danger Gardner authored
This classname is more descriptive about what it means.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Add a workaround for the scroll-into-view package for XHTML documents, including EPUBs. In these documents `scrollIntoView` failed to detect the <body> element correctly when finding scrollable ancestors of the target element. As a result the client did not scroll to the correct location for a highlight when clicking on annotation cards or bucket bar items. The workaround is to make `document.body.tagName` behave the same in XHTML documents as it does in HTML documents, and rely on this being unlikely to break any of the page's own JavaScript.
-
Robert Knight authored
Extract the logic for smoothly scrolling an element into view into the scrolling utility module, in preparation for adding a workaround for an issue with XHTML documents. This will also provide a place to configure common defaults and enable us to swap out the underlying implementation more easily in future.
-
Robert Knight authored
-
Robert Knight authored
-