- 09 Jun, 2021 1 commit
-
-
Kyle Keating authored
The main difference is that configFrom returned config key:value pairs, but now configDefinitions returns key:object pairs. Where the object may hold additional flags and methods for each specific config value. Currently the only method included is valueFn() which gets the value from its source. Others will follow. Additionally: - Remove `experimental` from configDefinitions/configFrom as it is not used
-
- 08 Jun, 2021 5 commits
-
-
Robert Knight authored
-
Robert Knight authored
Comments without a double `**` are not parsed as JSDoc.
-
Robert Knight authored
Convert the `initialState` functions in store modules to `const` values for modules where the state is static (ie. does not depend on `settings`) and add better type documentation. Most references to the state are not currently type-checked, but they will be in future. In the interim this serves as useful documentation for humans.
-
Lyza Danger Gardner authored
-
Robert Knight authored
`HTMLMetadata` read `document.baseURI` only once in the constructor, risking issues to the cached value becoming stale. `document.baseURI` is available in all supported browsers and is easily mocked where needed in tests, so just always read the current value when needed. Also remove a `normalizeURI` test seam that was unused. If we did want to mock this in future we'd use the `$imports` object as we do in other tests.
-
- 07 Jun, 2021 26 commits
-
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.27.0 to 7.28.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.27.0...v7.28.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.5.0 to 6.5.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.5.0...6.5.1) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Rename the `it`/`describe` blocks for tests for the `getDocumentMetadata` method to make it clearer what APIs the tests refer to. This also includes some minor related cleanup: - Function expressions => arrow functions - Fix a test for Twitter metadata being disabled because it was embedded within another test - Remove a duplicated test for the `uri` method
-
Robert Knight authored
-
Robert Knight authored
- Extract `Link` type used in several places and document it as the return type of `_getLinks` - Document the `metadata` argument to `getLinks` and provide a default value for it - Add a comment to clarify why `_getLinks` is called in the `uri` method
-
Robert Knight authored
`getDocumentMetadata` returns the first available title from a prioritized list of sources. Previously the tests only checked the highest priority source. Update the test so that it covers all cases.
-
Robert Knight authored
The `HTMLMetadata` class provided two ways to get at the document metadata: 1. A `getDocumentMetadata` method which reads the current metadata from the document and returns it 2. A `metadata` field which returns the last-read metadata The `metadata` field was not used outside the tests and shouldn't be used because it might return stale metadata (in a web page with client-side JS that updates `<meta>` and `<link>` tags etc. after the page loads). This field was also used internally by the various helper methods that gather metadata, with non-obvious constraints on the order in which the helpers are called. Remove the field to prevent external mis-use of the class and make the data flow and dependencies clearer internally.
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.3.0...2.3.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Kyle Keating authored
This reverts commit 719da85b2e82bff166376f337ff4bd5f90bb5e35.
-
Kyle Keating authored
This reverts commit e4b6004183fc4fe8b8b10000c700cdb4613b528d.
-
Kyle Keating authored
Currently, this config value is unused, but added for test coverage
-
Kyle Keating authored
The main difference is that configFrom returned config key:value pairs, but now configDefinitions returns key:object pairs. Where the object may hold additional flags and methods for each specific config value. Currently the only method included is valueFn() which gets the value from its source. Others will follow.
-
Kyle Keating authored
- Refactor config index to expose a different method for getting the config called `getConfig`. This now takes a app name (context) as a string which may return a subset of config values appropriate for a given application such as the "sidebar" or "notebook". - Segregate the config keys into various app contexts and omit keys that are either not used in a given application context or need to be excluded (e.g. `annotations` in notebook) - Fix missing config appType in annotator/config/index so it can propagate to the sidebar property (this was previously not the case) - Remove assetRoot from annotator/config/index as it is only needed in boot and not any specific app context
-
dependabot[bot] authored
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/v4.2.2/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-core/compare/v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: axe-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.13.1 to 3.14.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.14.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 9.1.1 to 10.0.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v9.1.1...v10.0.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.5.5 to 18.5.6. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.5.5...v18.5.6) --- updated-dependencies: - dependency-name: "@octokit/rest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.2 to 6.3.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.3.2...v6.3.3) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.918.0 to 2.922.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.918.0...v2.922.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.34.0 to 1.34.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.34.0...1.34.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Allow the `initialState` argument to `createStoreModule` to be a value to simplify usage for modules where the initial state is a static value (ie. has no dependency on data in `settings`).
-
Robert Knight authored
Improve the type of the `selectors` argument to `createStoreModule` to link it to the type of the initial state returned by the `initialState` argument. This enables TS to check/infer that the first argument to these functions should be of the same type that `initialState` returns. In the process it was necessary to remove the `ModuleConfig` type and declare the type of `createStoreModule`'s `config` argument inline. This works around a TypeScript limitation [1]: ``` @template State @template {SelectorMap<State>} Selectors // Unexpected error ... @typedef ModuleConfig ``` But this works: `` @template State @template {SelectorMap<State>} Selectors // OK ... function createStoreModule(...) { ... } ``` [1] https://github.com/microsoft/TypeScript/issues/43403
-
Robert Knight authored
Extract the `initialState` property out of the `config` object passed to `createStoreModule` into a separate argument which is passed before `config`. This allows TypeScript to infer the type of fields/parameters etc. which refer to the module state while processing the `config` argument. For example, given the following: ``` export default createStoreModule(initialState, { reducers: { updateThing(state, action) { ... } } }); ``` TS can infer the type of the `state` argument to `updateThing` without needing to explicitly annotate it. The same approach can work for other fields as well. This inference does not work when `initialState` is a property of the `config` object however.
-
Robert Knight authored
This function was originally written as a helper to enable us to enable TypeScript to generate more useful errors if a store module had the wrong structure. However it also provides a place that we can do runtime checks / normalization of store modules etc. Rename the function and update the documentation to make it clear that this is the correct way to define a store module.
-
Robert Knight authored
-
Robert Knight authored
Rename several fields of the configuration object for store modules to better align with the associated Redux concepts. This should make it easier for newcomers to the code to understand it if they already have some familiarity with Redux. - Rename the `init` function to `initialState` - Rename the `update` map to `reducers` - Rename the `actions` map to `actionCreators`
-
- 02 Jun, 2021 1 commit
-
-
dependabot[bot] authored
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](https://github.com/urllib3/urllib3/compare/1.26.4...1.26.5) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 01 Jun, 2021 1 commit
-
-
Lyza Danger Gardner authored
-
- 31 May, 2021 6 commits
-
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.4.1 to 6.5.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.4.1...6.5.0) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint-plugin-mocha](https://github.com/lo1tuma/eslint-plugin-mocha) from 8.1.0 to 9.0.0. - [Release notes](https://github.com/lo1tuma/eslint-plugin-mocha/releases) - [Changelog](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/lo1tuma/eslint-plugin-mocha/compare/8.1.0...9.0.0) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [mustache-express](https://github.com/bryanburgers/node-mustache-express) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/bryanburgers/node-mustache-express/releases) - [Commits](https://github.com/bryanburgers/node-mustache-express/commits) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.5.3 to 18.5.5. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.5.3...v18.5.5) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.2.5 to 10.2.6. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/10.2.5...10.2.6) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.12.1 to 3.13.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.13.1/packages/core-js) Signed-off-by: dependabot[bot] <support@github.com>
-