- 21 Jun, 2021 3 commits
-
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.28.0 to 7.29.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.28.0...v7.29.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.34.1 to 1.35.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.34.1...1.35.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.3.2 to 4.3.4. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v4.3.2...v4.3.4) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 17 Jun, 2021 5 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Components that appear in the sidebar are currently responsible for applying their own bottom-margin to keep things equally spaced. Margins (spacing) should eventually be applied by the parent element, but until then, a utility class will ensure that we maintain the same spacing, as we move to using shared components.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
`showdown` does not enable `strikethrough` support by default. Add associated test and update test module for modern conventions. Fixes https://github.com/hypothesis/support/issues/141
-
- 15 Jun, 2021 2 commits
-
-
Eduardo Sanz García authored
`ignoreOtherConfiguration` option causes other JSON hypothesis configurations included in the host page to be disregarded. In addition, by making `window.hypothesisConfig` non-configurable and non-writable we make sure that other `window.hypothesisConfig` defined afterwards can't override it. `via` has the ability to define a non-configurable `window.hypothesisConfig` before any other.
-
Eduardo Sanz García authored
If `ignoreOtherConfiguration` is used JSON configurations should be ignored. Part of https://github.com/hypothesis/viahtml/pull/192
-
- 14 Jun, 2021 13 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
dependabot[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.4 to 7.14.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.5/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 8.4.0 to 9.0.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v8.4.0...v9.0.0) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.922.0 to 2.927.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.922.0...v2.927.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.5.1 to 6.7.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.5.1...6.7.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 8.3.0 to 8.3.3. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.3.0...8.3.3) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.5.6 to 18.6.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.5.6...v18.6.0) --- updated-dependencies: - dependency-name: "@octokit/rest" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.8 to 2.2.9. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.2.8...2.2.9) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.14.3 to 7.14.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.5/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) --- updated-dependencies: - dependency-name: y18n dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.3 to 6.3.4. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.3.3...v6.3.4) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 09 Jun, 2021 1 commit
-
-
Kyle Keating authored
The main difference is that configFrom returned config key:value pairs, but now configDefinitions returns key:object pairs. Where the object may hold additional flags and methods for each specific config value. Currently the only method included is valueFn() which gets the value from its source. Others will follow. Additionally: - Remove `experimental` from configDefinitions/configFrom as it is not used
-
- 08 Jun, 2021 5 commits
-
-
Robert Knight authored
-
Robert Knight authored
Comments without a double `**` are not parsed as JSDoc.
-
Robert Knight authored
Convert the `initialState` functions in store modules to `const` values for modules where the state is static (ie. does not depend on `settings`) and add better type documentation. Most references to the state are not currently type-checked, but they will be in future. In the interim this serves as useful documentation for humans.
-
Lyza Danger Gardner authored
-
Robert Knight authored
`HTMLMetadata` read `document.baseURI` only once in the constructor, risking issues to the cached value becoming stale. `document.baseURI` is available in all supported browsers and is easily mocked where needed in tests, so just always read the current value when needed. Also remove a `normalizeURI` test seam that was unused. If we did want to mock this in future we'd use the `$imports` object as we do in other tests.
-
- 07 Jun, 2021 11 commits
-
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.27.0 to 7.28.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.27.0...v7.28.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.5.0 to 6.5.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.5.0...6.5.1) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Rename the `it`/`describe` blocks for tests for the `getDocumentMetadata` method to make it clearer what APIs the tests refer to. This also includes some minor related cleanup: - Function expressions => arrow functions - Fix a test for Twitter metadata being disabled because it was embedded within another test - Remove a duplicated test for the `uri` method
-
Robert Knight authored
-
Robert Knight authored
- Extract `Link` type used in several places and document it as the return type of `_getLinks` - Document the `metadata` argument to `getLinks` and provide a default value for it - Add a comment to clarify why `_getLinks` is called in the `uri` method
-
Robert Knight authored
`getDocumentMetadata` returns the first available title from a prioritized list of sources. Previously the tests only checked the highest priority source. Update the test so that it covers all cases.
-
Robert Knight authored
The `HTMLMetadata` class provided two ways to get at the document metadata: 1. A `getDocumentMetadata` method which reads the current metadata from the document and returns it 2. A `metadata` field which returns the last-read metadata The `metadata` field was not used outside the tests and shouldn't be used because it might return stale metadata (in a web page with client-side JS that updates `<meta>` and `<link>` tags etc. after the page loads). This field was also used internally by the various helper methods that gather metadata, with non-obvious constraints on the order in which the helpers are called. Remove the field to prevent external mis-use of the class and make the data flow and dependencies clearer internally.
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.3.0...2.3.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Kyle Keating authored
This reverts commit 719da85b2e82bff166376f337ff4bd5f90bb5e35.
-
Kyle Keating authored
This reverts commit e4b6004183fc4fe8b8b10000c700cdb4613b528d.
-
Kyle Keating authored
Currently, this config value is unused, but added for test coverage
-