- 15 Nov, 2022 7 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Simplify internal components (remove `HeaderRow` local component).
-
Lyza Danger Gardner authored
Visual change: hover on expand-replies is `brand` instead of `brand-dark`—this is a standard hover color for a light-colored link.
-
Robert Knight authored
Ensure that hovered annotations are cleared in the store when `null` is passed to `FrameSyncService.hoverAnnotations`.
-
Robert Knight authored
Following https://github.com/hypothesis/client/pull/4962, we can now identify annotations that should be scrolled to/focused after they anchor by their tag rather than ID, since the annotation in the sidebar's store persists across the chapter navigation.
-
Robert Knight authored
When a user hovers an annotation card for an EPUB chapter that is different than the one currently loaded in the guest, and then clicks on that annotation to navigate the guest to that chapter, ensure that the highlights in the document are displayed in a hovered state once anchoring completes. This is handled similar to `FrameSyncService.scrollToAnnotation`, by setting a flag if the annotation is not loaded in the guest, which triggers a "hoverAnnotations" RPC call once the annotation is anchored.
-
Robert Knight authored
This information is not currently displayed in the UI, but it is captured with annotations in the `EPUBContentSelector` selector.
-
- 14 Nov, 2022 14 commits
-
-
Robert Knight authored
Per feedback at https://github.com/hypothesis/client/pull/4944#pullrequestreview-1178131884, try to make `create-store.ts` easier to scan by moving some of the typing-related utilities into a separate module.
-
Robert Knight authored
-
Robert Knight authored
In particular, improve the documentation for properties of the `ModuleConfig` object which is passed to `createStoreModule`.
-
Robert Knight authored
This module contains the most complex types in the codebase, so this is useful as a reference for how to handle more complex cases.
-
dependabot[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.19.6 to 7.20.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.20.2/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.2.2 to 3.2.4. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/compare/v3.2.2...v3.2.4) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.56.0 to 1.56.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.56.0...1.56.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.18 to 8.4.19. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.18...8.4.19) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [chai](https://github.com/chaijs/chai) from 4.3.6 to 4.3.7. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/4.x.x/History.md) - [Commits](https://github.com/chaijs/chai/compare/v4.3.6...v4.3.7) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1243.0 to 2.1253.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1243.0...v2.1253.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.41.0 to 5.42.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.42.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 7.17.4 to 7.19.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.17.4...7.19.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@npmcli/arborist](https://github.com/npm/cli/tree/HEAD/workspaces/arborist) from 6.1.1 to 6.1.2. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/workspaces/arborist/CHANGELOG.md) - [Commits](https://github.com/npm/cli/commits/arborist-v6.1.2/workspaces/arborist) --- updated-dependencies: - dependency-name: "@npmcli/arborist" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.19.4 to 7.20.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.20.2/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 11 Nov, 2022 12 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
In the future, the `NavigationButton` pattern should be extracted Special CSS class is no longer needed (removed).
-
Robert Knight authored
Introduce the concept of "persistent" frames in the sidebar. This is a flag which can be set on a `Frame` in the sidebar's store to prevent annotations from being unloaded when the associated guest unloads. This flag is set in response to a hint provided by the `Guest` in its `documentInfoChanged` message. The guest in turn gets this hint via `Integration.persistFrame`, which returns true for VitalSource content frames. Marking VitalSource content frames as persistent prevents the book's annotations from being unloaded after a chapter navigation, when the old guest goes away, and then the same set of annotations immediately being re-fetched from the server when the new guest connects. This reload of annotations looked ugly but also lost the user's scroll position in the sidebar. With this change the sidebar retains the annotations during a chapter navigation and just re-sends the appropriate ones to the new guest when it connects.
-
Robert Knight authored
This type is for a message sent from the guest to the sidebar, so it belongs with other shared types.
-
Robert Knight authored
Add missing period. Co-authored-by: Lyza Gardner <439947+lyzadanger@users.noreply.github.com>
-
Robert Knight authored
Rewrite the description of this service to state that annotations are synchronized between the sidebar and _guest_ frames, not the host. Also note some (but not all) of the service's additional responsibilities. In the process it becomes clear that the service is tending towards being a little overloaded and it may make sense to split up some of these roles in future.
-
Robert Knight authored
These types are now only used in the PDF integration.
-
Lyza Danger Gardner authored
Refactor the computation of a couple of props set on MenuItem for clarity and improved typing.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
Replace the third-party minification plugin with the one maintained by the Rollup developers.
-
- 10 Nov, 2022 7 commits
-
-
Lyza Danger Gardner authored
-
Robert Knight authored
In order to facilitate a seamless transition after a chapter navigation in VitalSource, it will be necessary for the Guest in the new frame to report document information based on the same `book_as_single_document` feature flag state as for the previous frame. Allow integrations to signal whether the Guest should wait to receive feature flags from the sidebar before sending document info via `documentInfoChanged`, and enable this for VitalSource. We don't enable this for all integrations because it adds latency on the critical path to fetching and displaying annotations.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
This gives us two assurances: 1. Highlight background colors, if not amazing on dark backgrounds in HTML documents, are at least readable 2. We know the exact contrast between foreground and background text in highlight elements —— think accessibility here in the future
-
Lyza Danger Gardner authored
This will allow us to see how highlighting features work on inverted documents.
-
Lyza Danger Gardner authored
Fixed positioning is always relative to the viewport, so set the top position of the fixed-position highlight controls to take the integration's content container's vertical offset from the viewport into account. Translation: ensure that highlight controls are not obscured by PDFjs' top menu/controls bar.
-