1. 04 Mar, 2016 3 commits
    • Nick Stenning's avatar
      Merge pull request #3052 from hypothesis/fix-js-lint · 4b0982ab
      Nick Stenning authored
      Fix JS error checking via Hound
      4b0982ab
    • Robert Knight's avatar
      Disable Hound CI JSCS checks · 46f4ee6f
      Robert Knight authored
      Since enabling JSCS, Hound CI reviews for PRs
      which contain JS code changes have been failing
      to complete.
      
      ThoughtBot have advised us that the JSCS
      checker is in beta and that we should simply disable it.
      They noted that ESLint has received a better response
      from other testers so we might want to look
      at that instead.
      46f4ee6f
    • Robert Knight's avatar
      Make JSHint config compatible with JSHint v2.8.x and v2.9.x · 4cca09df
      Robert Knight authored
       - Use the legacy 'esnext' option only instead of both
         'esnext' and 'esversion' for compatibility with JSHint v2.8.x
         on Hound and developers who have the current stable version
         installed locally.
      
       - Remove the 'maxErrors' option from the JSCS config, as this
         prevents use of the '-x' option to autofix files which is
         a little annoying.
      4cca09df
  2. 03 Mar, 2016 2 commits
  3. 02 Mar, 2016 2 commits
    • Robert Knight's avatar
      Use Element.scrollIntoView() to scroll new annotations into view · dbbeadf8
      Robert Knight authored
      The previous method of scrolling a newly created annotation
      into view in the sidebar resulted in the input field for
      the new annotation losing focus.
      
      Note that only top level annotations have an 'id'
      attribute set on the corresponding HTML element.
      It might make sense to change this in future although
      it would add an extra binding. For now I've just noted this.
      dbbeadf8
    • Robert Knight's avatar
      Focus annotation editor when a new annotation is created · ec0e0f9f
      Robert Knight authored
      When a new annotation card was added, the sidebar tried
      to focus it but this failed because the sidebar iframe
      itself did not have focus.
      
      When a new annotation is created, first focus the sidebar
      in the Annotator host and then let the sidebar focus the
      input field.
      
       * Remove unnecessary use of the $timeout service which
         triggers a root scope digest.
      ec0e0f9f
  4. 01 Mar, 2016 8 commits
  5. 29 Feb, 2016 6 commits
  6. 26 Feb, 2016 7 commits
  7. 25 Feb, 2016 7 commits
  8. 24 Feb, 2016 5 commits