- 15 Jul, 2016 4 commits
-
-
Robert Knight authored
The group invite icon is only used in the H web service
-
Robert Knight authored
* The corejs polyfills are not needed in the Gulpfile since we switched to a more recent version of Node * The Object.assign() polyfill does not need to be included in 'raven' or 'settings' because it is already included by the polyfills.js script
-
Robert Knight authored
This was left over from when the Hypothesis client was extracted out from the hypothesis/h repository, where the extension code currently remains.
-
Robert Knight authored
Enforce that all paths through a function either return a value or do not return a value. This cause several cases of spurious returns left in by CoffeeScript -> JS conversion and return statements with missing values.
-
- 14 Jul, 2016 12 commits
-
-
Sheetal Umesh Kumar authored
Fix 'time' tests in timezones behind UTC
-
Robert Knight authored
Several test fixtures have expectations that the "current date", where "current" is reset to the Unix epoch at the start of the tests, is 1st Jan 1970. This is true in timezones equal to or ahead of UTC but not the case for timezones behind UTC. Resolve the issue by just advancing the fake clock forwards to midnight on 01/01/1970 if the timezone is behind UTC at the start of the tests.
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
Annotation / Notes tabs copy update and style tweaks
-
Sheetal Umesh Kumar authored
Update UI state after search API request completes with no results
-
Sheetal Umesh Kumar authored
Remove sticky tab bar behavior
-
Robert Knight authored
When a search API request returns results, the returned annotations are added to the app state and this transition triggers a digest cycle. When there are no results however, this was not happening and the value of the 'isLoading()' function changed but no digest cycle was triggered to pick this up and reflect it in the UI. Since SearchClient's 'end' event is emitted asynchronously via a Promise callback, $scope.$apply() or $evalAsync() must be used to ensure that change detection runs. The real solution will be to store all the information required to determine the loading/not-loading state in the Redux store, so that any transition automatically triggers a digest cycle. This requires some more extensive refactoring however.
-
Robert Knight authored
The sticky tab bar behavior has some UI issues that need to be resolved before we could ship it. For example, when switching between tabs the scroll position needs to be reset to the top. For the time being, this commit removes the behavior.
-
Robert Knight authored
Following feedback and design review, change the label from 'Notes' to 'Page Notes' to better distinguish notes from annotations and make the empty state text for the Annotations tab more helpful by explaining to users how to create a new annotation.
-
Robert Knight authored
Shift the 'No annotations in this group' message down slightly to prevent the border from being clipped. Also prevent text selection in the tabs.
-
Nick Stenning authored
ESLint - Enable 'Best practices' rules
-
Robert Knight authored
Usage of Hound has been replaced by a Travis task that runs `npm run lint`
-
- 13 Jul, 2016 16 commits
-
-
Robert Knight authored
Enable additional rules from the 'Best Practices' list on ESLint's Rules page.
-
Robert Knight authored
Use `.delete` instead of `['delete']` etc. since all browsers we target support ES5.
-
Nick Stenning authored
Add ESLint configuration and use it to replace JSCS / JSHint
-
Robert Knight authored
-
Robert Knight authored
These have been replaced by ESLint
-
Robert Knight authored
For stylistic consistency, require semicolons rather than relying on ASI.
-
Robert Knight authored
Checking for return values in Array callbacks found several incorrect uses of Array.map() where Array.forEach() should have been used.
-
Robert Knight authored
This will aid migration to let/const in future
-
Robert Knight authored
This will ease migration to let/const in future.
-
Robert Knight authored
-
Robert Knight authored
- Remove unused variables. Note that ESLint is smarter than JSHint in that it realizes that vars which are assigned but never read are unused. - Add missing `angular` require statements. - Add ESLint suppressions where necessary
-
Robert Knight authored
Add a basic ESLint configuration which uses ESLint' recommended settings to check for basic errors such as undefined vars and unused variables.
-
Nick Stenning authored
-
Nick Stenning authored
-
Nick Stenning authored
-
Sheetal Umesh Kumar authored
Improve tab bar input handling and accessibility
-
- 12 Jul, 2016 3 commits
-
-
Robert Knight authored
Use anchor rather than link elements for the tab bar items so that they are focusable via keyboard navigation. Also follow code conventions and use 'is-<state>' for element states set in JS.
-
Robert Knight authored
Focus the Annotation and Notes tabs on touch or mouse down rather than click. This makes the tabs act more like tabs in native apps and feel more responsive. Since Angular does not provide a built-in attribute directive for handling touch events, implement a custom one.
-
Sheetal Umesh Kumar authored
Make Annotation and Notes tab bar sticky
-
- 11 Jul, 2016 3 commits
-
-
Robert Knight authored
Make Annotation and Notes tab bar stick to top of the viewport when the annotation list is scrolled down. This relies on support for `position: sticky` which is available in recent versions of Firefox and Safari*. On browsers where `position: sticky` is not supported, the tab bar will just scroll off-screen when scrolling the annotation list down. Because annotation cards may now be displayed under the tabs, add a background color, Z index and negative horizontal margin to the tabs component so that any part of an annotation card under the tab bar is not visible. * In Chrome v52 this feature is available but only when the 'Experimental web platform features' flag is on.
-
Robert Knight authored
Selection tabs tweaks.
-
Sheetal Umesh Kumar authored
Fix PR comments including some UI tweaks and bug fixes. Hide no annotations/notes message when annotations are still loading. When the annotations are still loading, a 0 annotations message shows for a flash of a second before the list loads. Avoid this by only displaying the 0 state after the annotations have finished loading. If selected annotation/note is deleted, default selected tab to annotation. If a user lands on a direct link for a deleted annotation, the button to take the user back to the list of annotations/notes should by default be for annotations. On clearning the selection, filter annotations according to the selected tab type. Fix broken standalone page for notes. selectedTab was set to annotations by default, even for standalone pages. selectedTab should be undefined for a standalone page because there are no tabs to select from. select the annotations tab by default for the sidebar alone. Change copy for empty annotaitons/notes state.
-
- 08 Jul, 2016 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
Add a set of `npm version` scripts which can be used to tag and publish a new release of the client with: npm version major|minor|patch npm publish Where most releases will use `npm version minor`.
-