- 19 Apr, 2018 1 commit
-
-
Robert Knight authored
As noted in CR feedback, having a selector named `focusedGroup` which returns a `Group` and a state property named `focusedGroup` is `string|null` is confusing. Also change a `g` variable to `group` for clarity.
-
- 10 Apr, 2018 2 commits
-
-
Robert Knight authored
Update the groups service to use the Redux store for storing and reading groups state instead of storing it internally in private variables.
-
Robert Knight authored
Add a Redux module that stores state related to groups, including the currently focused group and the list of all known groups. This is an initial step towards moving this state from the groups service into the store, which will make reacting to changes in the set of loaded groups, or the focused group, easier.
-
- 06 Apr, 2018 9 commits
-
-
Hannah Stepanek authored
Extract `createStore` helper out of `store` service
-
Sean Hammond authored
Replace "inherits" package with ES 2015 class inheritance
-
Sean Hammond authored
Convert Adder to an ES2015 class
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Remove the need to alias the `Adder` instance to `self` by using arrow-functions.
-
Robert Knight authored
This commit and the next few refactor `Adder` to a "proper" class for easier readability.
-
- 05 Apr, 2018 1 commit
-
-
Robert Knight authored
Add `expand` param to all groups.list requests
-
- 04 Apr, 2018 1 commit
-
-
Lyza Danger Gardner authored
-
- 29 Mar, 2018 5 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Minor bug fix
-
Robert Knight authored
Replace use of "inherits" package to create classes that derive from `EventEmitter` with ES 2015 `class Foo extends EventEmitter` syntax, for readability.
-
Robert Knight authored
-
- 28 Mar, 2018 1 commit
-
-
Robert Knight authored
This method is part of the Redux store API so we don't need to test it in detail, but this is additional verification that `createStore` returns a working Redux store.
-
- 27 Mar, 2018 4 commits
-
-
Sean Hammond authored
Move date, time & retry utility code to `util/` dir
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Pdf subframe annotation
-
- 26 Mar, 2018 6 commits
-
-
Josh Bird authored
-
Robert Knight authored
As per #648, move several modules containing utility functions which have no dependencies on other code to `src/sidebar/util`.
-
Robert Knight authored
The `thunk` middleware is used by the `annotations` module and likely others in future. Rather than require it to be passed to `createStore` in each test that uses it, I think it makes sense to always include it as the standard way to handle async/non-pure actions in the client.
-
Robert Knight authored
This functionality is now covered by tests for the `createStore` helper.
-
Robert Knight authored
The `store` factory function contains some useful logic for composing a store out of a set of _modules_ which handle different parts of the application state, exposing the actions and selectors from each module as methods on the store. To facilitate re-use of this logic in tests and to make it easier to test this logic directly, extract it out of the `store` function into a separate `createStore` helper. Doing this enables removal of `modules/index.js` which existed to combine parts of the modules together.
-
Sean Hammond authored
Rename "annotationUI" => "store"
-
- 22 Mar, 2018 10 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
-
Robert Knight authored
Rename the fake/stub implementations of the Redux store used in various component and service tests.
-
Robert Knight authored
Update the name of the identifier used for the Redux store in various contexts, following the previous refactoring to move store-related code into `store/`.
-
Robert Knight authored
Move Redux modules and entry point to `store/` directory
-
Robert Knight authored
Changed background to selected element in PDF.js to visualize the searched content
-
Robert Knight authored
Remove reference to `group.url`
-
Robert Knight authored
Remove `group.public` property from annotation component
-